)]}'
{"oslo_config/generator.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0a1b3d758e4f4671da2f77fd47d5454b4ed8e935","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # UPPER_CASE_GROUP_NAMES"},{"line_number":354,"context_line":"            if group:"},{"line_number":355,"context_line":"                group_name \u003d getattr(group, \u0027name\u0027, str(group))"},{"line_number":356,"context_line":"                if re.search(group_name, \u0027\u0027.join(UPPER_CASE_GROUP_NAMES),"},{"line_number":357,"context_line":"                             re.IGNORECASE):"},{"line_number":358,"context_line":"                    group_name \u003d group_name.upper()"},{"line_number":359,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_32c42b3f","line":356,"updated":"2016-12-19 19:27:27.000000000","message":"It would be simpler to just use an \"in\" check here. We also lost the nice warning message from the last version. So maybe something like:\n\n  if group_name.upper() in UPPER_CASE_GROUP_NAMES:\n    normalized_gn \u003d group_name.upper()\n  else:\n    normalized_gn \u003d group_name.lower()\n  if normalized_gn !\u003d group_name:\n    LOG.warning(\u0027normalizing group name %r to %r\u0027, group_name, normalized_gn)","commit_id":"b538b4aae2cefbfcc219d468617464722a8a7d51"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ec5d1e343d9aff0f3f4e3228ab37cef4d302390d","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # UPPER_CASE_GROUP_NAMES"},{"line_number":354,"context_line":"            if group:"},{"line_number":355,"context_line":"                group_name \u003d getattr(group, \u0027name\u0027, str(group))"},{"line_number":356,"context_line":"                if re.search(group_name, \u0027\u0027.join(UPPER_CASE_GROUP_NAMES),"},{"line_number":357,"context_line":"                             re.IGNORECASE):"},{"line_number":358,"context_line":"                    group_name \u003d group_name.upper()"},{"line_number":359,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_bc800a48","line":356,"in_reply_to":"1a6eadb0_32c42b3f","updated":"2016-12-19 23:24:37.000000000","message":"I realized that I wasn\u0027t considering invalid cases like DeFault.  But you\u0027re right, I\u0027ll revert this to the original approach with log messages.","commit_id":"b538b4aae2cefbfcc219d468617464722a8a7d51"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0a1b3d758e4f4671da2f77fd47d5454b4ed8e935","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    # from the cleaned structure."},{"line_number":373,"context_line":"    cleaned_opts \u003d ["},{"line_number":374,"context_line":"        (namespace, [(g, list(clean[namespace][g].values()))"},{"line_number":375,"context_line":"                     for g in clean[namespace]])"},{"line_number":376,"context_line":"        for namespace in clean"},{"line_number":377,"context_line":"    ]"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_721143af","line":375,"updated":"2016-12-19 19:27:27.000000000","message":"I\u0027m not sure why you\u0027re changing this block, but if you\u0027re going to change it it could just be:\n\n  cleaned_opts \u003d [\n    (namespace, [(g, list(v)) for g, v in clean[namespace].items()]\n    for namespace in clean\n  ]","commit_id":"b538b4aae2cefbfcc219d468617464722a8a7d51"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ec5d1e343d9aff0f3f4e3228ab37cef4d302390d","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    # from the cleaned structure."},{"line_number":373,"context_line":"    cleaned_opts \u003d ["},{"line_number":374,"context_line":"        (namespace, [(g, list(clean[namespace][g].values()))"},{"line_number":375,"context_line":"                     for g in clean[namespace]])"},{"line_number":376,"context_line":"        for namespace in clean"},{"line_number":377,"context_line":"    ]"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_5b68dbba","line":375,"in_reply_to":"1a6eadb0_721143af","updated":"2016-12-19 23:24:37.000000000","message":"I changed because I was having some conflict with the name of the variables during tox validation.","commit_id":"b538b4aae2cefbfcc219d468617464722a8a7d51"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"8764c4ef10aa1b17c5829bc625568941ba357480","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    # from the cleaned structure."},{"line_number":373,"context_line":"    cleaned_opts \u003d ["},{"line_number":374,"context_line":"        (namespace, [(g, list(clean[namespace][g].values()))"},{"line_number":375,"context_line":"                     for g in clean[namespace]])"},{"line_number":376,"context_line":"        for namespace in clean"},{"line_number":377,"context_line":"    ]"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_7b90374f","line":375,"in_reply_to":"1a6eadb0_721143af","updated":"2016-12-19 23:40:39.000000000","message":"I tried the format that you proposed but it didn\u0027t work :(  \n\nI need to change it in order to avoid this error\n\n./oslo_config/generator.py:376:26: F812 list comprehension redefines \u0027group\u0027 from line 365\n                     for group in clean[namespace]])\n                         ^","commit_id":"b538b4aae2cefbfcc219d468617464722a8a7d51"}]}
