)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b452c67f7747b19b87d235027bfd4d75823177e7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"html_last_updated_fmt option is interpreted as a"},{"line_number":10,"context_line":"byte string in python3, causing Sphinx build to break."},{"line_number":11,"context_line":"This patch makes it utf-8 string."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changing Popen to .check_output because of 2 reasons:"},{"line_number":14,"context_line":"1. check_output() will raise CalledProcessError if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_29e53edc","line":11,"updated":"2017-06-06 16:37:04.000000000","message":"I think this part of the message isn\u0027t needed? We already had the decode() call. If the problem was that communicate() did not raise an exception, then we only need the parts on line 13-16.","commit_id":"a2ebe56ec9bf6d77568024ceea99219d573482dd"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"1344707b49a02f176e1b60a305654a724552c344","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"html_last_updated_fmt option is interpreted as a"},{"line_number":10,"context_line":"byte string in python3, causing Sphinx build to break."},{"line_number":11,"context_line":"This patch makes it utf-8 string."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changing Popen to .check_output because of 2 reasons:"},{"line_number":14,"context_line":"1. check_output() will raise CalledProcessError if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_47860dde","line":11,"in_reply_to":"df140735_29e53edc","updated":"2017-06-07 02:33:12.000000000","message":"Hi Doug Hellmann,\nThanks for your comment,\n\nYes, you\u0027re correct. As your suggestion, I\u0027ve just updated commit message.\n\nHave a great day ahead.","commit_id":"a2ebe56ec9bf6d77568024ceea99219d573482dd"}],"doc/source/conf.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c1425c4d37071f7743310846c60c0a39d13c1c25","unresolved":false,"context_lines":[{"line_number":62,"context_line":"git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\","},{"line_number":63,"context_line":"           \"-n1\"]"},{"line_number":64,"context_line":"try:"},{"line_number":65,"context_line":"    html_last_updated_fmt \u003d subprocess.check_output(git_cmd).decode(\u0027utf-8\u0027)"},{"line_number":66,"context_line":"except Exception:"},{"line_number":67,"context_line":"    warnings.warn(\u0027Cannot get last updated time from git repository. \u0027"},{"line_number":68,"context_line":"                  \u0027Not setting \"html_last_updated_fmt\".\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_8139e7d7","line":65,"updated":"2017-06-05 17:46:57.000000000","message":"The decode() call is already there in the old version. Does check_output() do something differently to its return value than Popen().communicate()?","commit_id":"34f3b0910afc92fdc6e11c2d32e2ca080c851a9d"},{"author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"change_message_id":"1007a4386bcd9174610ed8a6c9e96b917c01dbf2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\","},{"line_number":63,"context_line":"           \"-n1\"]"},{"line_number":64,"context_line":"try:"},{"line_number":65,"context_line":"    html_last_updated_fmt \u003d subprocess.check_output(git_cmd).decode(\u0027utf-8\u0027)"},{"line_number":66,"context_line":"except Exception:"},{"line_number":67,"context_line":"    warnings.warn(\u0027Cannot get last updated time from git repository. \u0027"},{"line_number":68,"context_line":"                  \u0027Not setting \"html_last_updated_fmt\".\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_47acf6eb","line":65,"in_reply_to":"df140735_8139e7d7","updated":"2017-06-06 02:18:43.000000000","message":"Hi Doug Hellmann,\nThanks for your comment.\n\nBecause of 2 reasons:\n1. check_output() will raise CalledProcessError if the called process returns a non-zero return code.\n2. For consistency with keystone [1] and cinder [2]\n\n[1] https://review.openstack.org/#/c/457142/\n[2] https://review.openstack.org/#/c/433081","commit_id":"34f3b0910afc92fdc6e11c2d32e2ca080c851a9d"}]}
