)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"2b488a1e5e8960c5148b0042d72fe224e91c2c96","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lars Butler \u003cLars.Butler@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-29 15:30:41 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ConfigParser no longer obscures IOErrors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ConfigParser no longer interprets all IOErrors as \u0027No such file or"},{"line_number":10,"context_line":"directory\u0027. The current behavior does not change: \u0027No such file\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FtLc%3D","line":7,"updated":"2013-10-30 07:17:38.000000000","message":"Oh, and to get really nitpicky ... see e.g. https://wiki.openstack.org/wiki/GitCommitMessages#Examples_of_good_practice\n\nI read that summary initially as \"there was a regression recently which means ConfigParser no longer obscures IOErrors\" rather than \"This commit makes ConfigParser no longer obscure IOErrors\"\n\nI guess I mean I prefer commit messages to use the imperative mood? http://en.wikipedia.org/wiki/Imperative_mood","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":9166,"name":"Lars Butler","email":"lars.butler@gmail.com","username":"larsbutler"},"change_message_id":"a055747d43e0756873073dfc84ec896cd8c01685","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lars Butler \u003cLars.Butler@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-29 15:30:41 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ConfigParser no longer obscures IOErrors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ConfigParser no longer interprets all IOErrors as \u0027No such file or"},{"line_number":10,"context_line":"directory\u0027. The current behavior does not change: \u0027No such file\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2Fsy4%3D","line":7,"in_reply_to":"AAAATn%2F%2FtLc%3D","updated":"2013-10-30 09:18:48.000000000","message":"Nitpickiness is appreciated! :)","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"2b488a1e5e8960c5148b0042d72fe224e91c2c96","unresolved":false,"context_lines":[{"line_number":11,"context_line":"IOErrors are swallowed and dealt with elsewhere. The fundamental change"},{"line_number":12,"context_line":"here is that other types of IOErrors are re-raised. (Before this, all"},{"line_number":13,"context_line":"types of IOErrors--including, for example, \u0027Too many open files\u0027--were"},{"line_number":14,"context_line":"treated as \u0027No such file\u0027, which is obviously not correct.)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also added a test to exercise the case where IOErrors are reraised. The"},{"line_number":17,"context_line":"\u0027No such file\u0027 case is already covered by existing tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FtLE%3D","line":14,"updated":"2013-10-30 07:17:38.000000000","message":"Oh, and this isn\u0027t about a change to the behaviour of ConfigParser\u0027s public API (note that _parse_file() is a private API) - it\u0027s about the behaviour of ConfigOpts","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":9166,"name":"Lars Butler","email":"lars.butler@gmail.com","username":"larsbutler"},"change_message_id":"a055747d43e0756873073dfc84ec896cd8c01685","unresolved":false,"context_lines":[{"line_number":11,"context_line":"IOErrors are swallowed and dealt with elsewhere. The fundamental change"},{"line_number":12,"context_line":"here is that other types of IOErrors are re-raised. (Before this, all"},{"line_number":13,"context_line":"types of IOErrors--including, for example, \u0027Too many open files\u0027--were"},{"line_number":14,"context_line":"treated as \u0027No such file\u0027, which is obviously not correct.)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also added a test to exercise the case where IOErrors are reraised. The"},{"line_number":17,"context_line":"\u0027No such file\u0027 case is already covered by existing tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2Fs5g%3D","line":14,"in_reply_to":"AAAATn%2F%2FtLE%3D","updated":"2013-10-30 09:18:48.000000000","message":"Yes, you\u0027re right. I\u0027ll revise the message to be a bit more clear. Thanks for the feedback!","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"}],"oslo/config/cfg.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"f693cc5bda520eefdaba90937edd56c516808827","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"            # If the error type is \u0027No such file or directory\u0027,"},{"line_number":1281,"context_line":"            # keep track of the files not found and deal with it later."},{"line_number":1282,"context_line":"            # NOTE(larsbutler): Don\u0027t assume that all IOErrors are caused by"},{"line_number":1283,"context_line":"            # missing files."},{"line_number":1284,"context_line":"            if err.errno \u003d\u003d errno.ENOENT:"},{"line_number":1285,"context_line":"                namespace._file_not_found(config_file)"},{"line_number":1286,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FtOU%3D","line":1283,"updated":"2013-10-30 07:10:30.000000000","message":"FWIW, I\u0027m not sure the comment is needed - certainly the second part is pretty obvious","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":9166,"name":"Lars Butler","email":"lars.butler@gmail.com","username":"larsbutler"},"change_message_id":"a055747d43e0756873073dfc84ec896cd8c01685","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"            # If the error type is \u0027No such file or directory\u0027,"},{"line_number":1281,"context_line":"            # keep track of the files not found and deal with it later."},{"line_number":1282,"context_line":"            # NOTE(larsbutler): Don\u0027t assume that all IOErrors are caused by"},{"line_number":1283,"context_line":"            # missing files."},{"line_number":1284,"context_line":"            if err.errno \u003d\u003d errno.ENOENT:"},{"line_number":1285,"context_line":"                namespace._file_not_found(config_file)"},{"line_number":1286,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fs8k%3D","line":1283,"in_reply_to":"AAAATn%2F%2FtOU%3D","updated":"2013-10-30 09:18:48.000000000","message":"You\u0027re right; it is pretty obvious. I\u0027ll remove this comment altogether.","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"415728dbd5b93ac5710c3c4308d366ad2f09b57b","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"            if err.errno \u003d\u003d errno.ENOENT:"},{"line_number":1285,"context_line":"                namespace._file_not_found(config_file)"},{"line_number":1286,"context_line":"                return"},{"line_number":1287,"context_line":"            raise err"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"        namespace.add_parsed_config_file(sections, normalized)"},{"line_number":1290,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FuXo%3D","line":1287,"updated":"2013-10-29 21:41:26.000000000","message":"In general I prefer to use a plain \"raise\" to re-raise the exception so we don\u0027t lose the stack trace up to this point.","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":9166,"name":"Lars Butler","email":"lars.butler@gmail.com","username":"larsbutler"},"change_message_id":"a055747d43e0756873073dfc84ec896cd8c01685","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"            if err.errno \u003d\u003d errno.ENOENT:"},{"line_number":1285,"context_line":"                namespace._file_not_found(config_file)"},{"line_number":1286,"context_line":"                return"},{"line_number":1287,"context_line":"            raise err"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"        namespace.add_parsed_config_file(sections, normalized)"},{"line_number":1290,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fs8g%3D","line":1287,"in_reply_to":"AAAATn%2F%2FuXo%3D","updated":"2013-10-30 09:18:48.000000000","message":"Okay, I\u0027ll change that.","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"086e152928a215860f430a62f20d1f38ae8f58a8","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"    def _parse_file(cls, config_file, namespace):"},{"line_number":1264,"context_line":"        \"\"\"Parse a config file and store any values in the namespace."},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        :raises: ConfigFileParseError, ConfigFileValueError, IOError"},{"line_number":1267,"context_line":"        \"\"\""},{"line_number":1268,"context_line":"        config_file \u003d _fixpath(config_file)"},{"line_number":1269,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FkVo%3D","line":1266,"updated":"2013-11-01 06:41:28.000000000","message":"I wouldn\u0027t include this here - IOError is not something callers should explicitly catch since we handle it for all \"expected\" circumstances","commit_id":"375f7378f114f1c51105d925ffc7104753f73e8b"}],"tests/test_cfg.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"415728dbd5b93ac5710c3c4308d366ad2f09b57b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import argparse"},{"line_number":18,"context_line":"import errno"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import shutil"},{"line_number":22,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FuWw%3D","line":19,"updated":"2013-10-29 21:41:26.000000000","message":"This is a third-party lib so it should go in the next group.","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"},{"author":{"_account_id":9166,"name":"Lars Butler","email":"lars.butler@gmail.com","username":"larsbutler"},"change_message_id":"a055747d43e0756873073dfc84ec896cd8c01685","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import argparse"},{"line_number":18,"context_line":"import errno"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import shutil"},{"line_number":22,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fs7s%3D","line":19,"in_reply_to":"AAAATn%2F%2FuWw%3D","updated":"2013-10-30 09:18:48.000000000","message":"Okay, I\u0027ll fix that. Thanks!","commit_id":"f385ce0c79fe66b197afff6a2c831854597cbdd7"}]}
