)]}'
{"oslo_config/sphinxext.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"91594bb0168f1d93a06bd8a541ad6fb71e458cb4","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        result \u003d ViewList()"},{"line_number":311,"context_line":"        source_name \u003d self.state.document.current_source"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        with tempfile.NamedTemporaryFile(suffix\u003d\u0027.rst\u0027, delete\u003dFalse) as tmp:"},{"line_number":314,"context_line":"            # NOTE(stephenfin): We dump the output to a tempfile to assist"},{"line_number":315,"context_line":"            # people in debugging their broken config options. It would be good"},{"line_number":316,"context_line":"            # to conditionalize this but that would require access to error"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_75a90d7a","line":313,"range":{"start_line":313,"start_character":56,"end_line":313,"end_character":68},"updated":"2018-04-11 18:03:34.000000000","message":"Is the ShowOptionsDirective only called on error?  Just wondering if this will ever silently leave temp files lying around.  Bear in mind that I have no idea how this all works. :-)","commit_id":"9ec776b87848f594a67d30c6e105ccce9b67c9c7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f2e895f55199e0499434b9b18bc4a82b23469b4","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        result \u003d ViewList()"},{"line_number":311,"context_line":"        source_name \u003d self.state.document.current_source"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        with tempfile.NamedTemporaryFile(suffix\u003d\u0027.rst\u0027, delete\u003dFalse) as tmp:"},{"line_number":314,"context_line":"            # NOTE(stephenfin): We dump the output to a tempfile to assist"},{"line_number":315,"context_line":"            # people in debugging their broken config options. It would be good"},{"line_number":316,"context_line":"            # to conditionalize this but that would require access to error"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_59daf177","line":313,"range":{"start_line":313,"start_character":56,"end_line":313,"end_character":68},"in_reply_to":"bf659307_75a90d7a","updated":"2018-04-12 10:06:52.000000000","message":"Nope, it\u0027s called all the time. As a directive, we run and then we\u0027re done: we\u0027ve no way to figure out the eventual build state and therefore no way to check for errors. This will generate temporary files but I figured that was OK as tmpfs gets wiped on reboot.","commit_id":"9ec776b87848f594a67d30c6e105ccce9b67c9c7"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f52e7772c0ad2c5f8a2212757dd10e917ffe958d","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            LOG.info(\u0027dumping output to %r\u0027, tmp.name)"},{"line_number":318,"context_line":"            offset \u003d 0"},{"line_number":319,"context_line":"            for count, line in enumerate(_format_option_help("},{"line_number":320,"context_line":"                    app, namespaces, split_namespaces)):"},{"line_number":321,"context_line":"                # FIXME(stephenfin): Some lines emitted are actually multiple"},{"line_number":322,"context_line":"                # lines. This throws off our counter, which is rather annoying."},{"line_number":323,"context_line":"                # We handle this here but we should really handle it higher up."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_43694423","line":320,"range":{"start_line":320,"start_character":20,"end_line":320,"end_character":24},"updated":"2018-05-03 16:05:53.000000000","message":"Looks like this needs to be removed now.","commit_id":"f2424f56973c32e6f01a6557526294f137c2a27e"}]}
