)]}'
{"oslo_config/sources.py":[{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"7e72c7663d6ecc8387375694149bdcc4cf9422c0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @abc.abstractmethod"},{"line_number":28,"context_line":"    def open_source_from_opt_group(cls, conf, group_name):"},{"line_number":29,"context_line":"        \"\"\"Return an open option source."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        Use group_name to find the configuration settings for the new"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_27939451","line":28,"range":{"start_line":28,"start_character":35,"end_line":28,"end_character":38},"updated":"2018-04-19 16:58:22.000000000","message":"We don\u0027t need an instance of ConfigurationSourceDriver, they are abstract factories for ConfigurationSources.","commit_id":"94816bf3ca11099ce76962277b4c38719f1382db"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9576bc96aae90f8fb227d2a089975aacf84eff60","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @abc.abstractmethod"},{"line_number":28,"context_line":"    def open_source_from_opt_group(cls, conf, group_name):"},{"line_number":29,"context_line":"        \"\"\"Return an open option source."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        Use group_name to find the configuration settings for the new"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_47db281a","line":28,"range":{"start_line":28,"start_character":35,"end_line":28,"end_character":38},"in_reply_to":"9f6a8fd7_27939451","updated":"2018-04-19 17:01:46.000000000","message":"Hmm, maybe. Until we see how ConfigOpts is going to invoke the drivers I didn\u0027t want to assume that the instance wouldn\u0027t be useful.","commit_id":"94816bf3ca11099ce76962277b4c38719f1382db"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9576bc96aae90f8fb227d2a089975aacf84eff60","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class INIConfigurationSourceDriver(ConfigurationSourceDriver):"},{"line_number":64,"context_line":"    \"\"\"A configuration source driver for INI files served through http[s]."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"       Required options:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_87d140fe","line":63,"updated":"2018-04-19 17:01:46.000000000","message":"Let\u0027s place each driver and its source into a separate file, to keep this one from suffering from the same problem that cfg.py has. Maybe sources.py should actually be sources/base.py and then this stuff could go into sources/ini.py.","commit_id":"94816bf3ca11099ce76962277b4c38719f1382db"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"7d58914a50a9b255ab7bc7d7d8bc3a1ece1110fd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class INIConfigurationSourceDriver(ConfigurationSourceDriver):"},{"line_number":64,"context_line":"    \"\"\"A configuration source driver for INI files served through http[s]."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"       Required options:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_c15e3675","line":63,"in_reply_to":"9f6a8fd7_87d140fe","updated":"2018-05-07 13:49:19.000000000","message":"the base could also be at sources/__init__.py","commit_id":"94816bf3ca11099ce76962277b4c38719f1382db"}],"oslo_config/sources/__init__.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9de90dd11c0e0813c63c0c5a0e4830f7970d5532","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        pass"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_b35f2140","line":41,"updated":"2018-05-07 13:20:19.000000000","message":"I\u0027m having trouble seeing the circumstances under which this name would exist already. What did you have in mind here?","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"cceb8af7394fbea44395b78c740dfc38c71b78a7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        pass"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_8445f9b5","line":41,"in_reply_to":"5f7c97a3_86c2e132","updated":"2018-05-07 14:56:59.000000000","message":"OK, reloading isn\u0027t something we usually worry about supporting.","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"7d58914a50a9b255ab7bc7d7d8bc3a1ece1110fd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        pass"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_86c2e132","line":41,"in_reply_to":"5f7c97a3_b35f2140","updated":"2018-05-07 13:49:19.000000000","message":"This happens if I remove the `try`:\n\n\u003e\u003e\u003e from oslo_config import sources\n\u003e\u003e\u003e v \u003d sources._NoValue\n\u003e\u003e\u003e v\n\u003coslo_config.sources._NoValueType at 0x7f8027d479d0\u003e\n\n\u003e\u003e\u003e import imp\n\u003e\u003e\u003e imp.reload(sources)\n\u003cmodule \u0027oslo_config.sources\u0027 from \u0027/home/moguimar/.ve/oslo.config/lib/python2.7/site-packages/oslo_config/sources/__init__.pyc\u0027\u003e\n\n\u003e\u003e\u003e v\n\u003coslo_config.sources._NoValueType at 0x7f8027d479d0\u003e\n\n\u003e\u003e\u003e sources._NoValue\n\u003coslo_config.sources._NoValueType at 0x7f802616a590\u003e","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9de90dd11c0e0813c63c0c5a0e4830f7970d5532","unresolved":false,"context_lines":[{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_531fad6b","line":43,"updated":"2018-05-07 13:20:19.000000000","message":"Is there any reason NoValue can\u0027t just be an instance of object()? We need a singleton, but if we create it when the module is imported then we will have one. It shouldn\u0027t really need any behaviors other than having an identity so we can ask if a response from the driver \"is\" NoValue.","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"7d58914a50a9b255ab7bc7d7d8bc3a1ece1110fd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_86f0a192","line":43,"in_reply_to":"5f7c97a3_531fad6b","updated":"2018-05-07 13:49:19.000000000","message":"`_NoValue \u003d object()` is vulnerable to copy, deepcopy and pickle. I\u0027m adding unit tests for this.","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"cceb8af7394fbea44395b78c740dfc38c71b78a7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_e40dcd90","line":43,"in_reply_to":"5f7c97a3_86f0a192","updated":"2018-05-07 14:56:59.000000000","message":"Why do we care about those operations? Do we expect the caller who receives _NoValue to do any of those things?","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9de90dd11c0e0813c63c0c5a0e4830f7970d5532","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":47,"context_line":"class ConfigurationSourceDriver(object):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_060ed133","line":44,"updated":"2018-05-07 13:20:19.000000000","message":"We could probably call the variable _NoValue, since it\u0027s an internal implementation detail of the configuration library.","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"7d58914a50a9b255ab7bc7d7d8bc3a1ece1110fd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    NoValue"},{"line_number":42,"context_line":"except NameError:"},{"line_number":43,"context_line":"    NoValue \u003d object.__new__(_NoValueType)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":47,"context_line":"class ConfigurationSourceDriver(object):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_460b698d","line":44,"in_reply_to":"5f7c97a3_060ed133","updated":"2018-05-07 13:49:19.000000000","message":"Done","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4083c7d79ea9f961b5916fdef03946801ef8530d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import six"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class _NoValueType(object):"},{"line_number":17,"context_line":"    \"\"\"Class used to define `NoValue`."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    We cannot use None as a sentinel indicating a missing value because it"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_4f5eb576","line":16,"updated":"2018-05-11 15:09:34.000000000","message":"I still don\u0027t think we need to do all of this. Setting _NoValue \u003d object() should be sufficient for the cases we support with this library (i.e., not reloading). _NoValue is an internal implementation detail of oslo.config, so no callers outside of the library should ever see or use the value.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"2801421499998c5a5140aea8b5b7e0e0d0419a54","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import six"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class _NoValueType(object):"},{"line_number":17,"context_line":"    \"\"\"Class used to define `NoValue`."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    We cannot use None as a sentinel indicating a missing value because it"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_45575bcb","line":16,"in_reply_to":"5f7c97a3_4f5eb576","updated":"2018-05-14 11:06:40.000000000","message":"Done","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"}],"oslo_config/sources/ini.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e6a8a0ad3ccc3ddc1c9e03dd8e1b029c4abf87af","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self, uri):"},{"line_number":45,"context_line":"        with contextlib.closing(requests.get(uri)) as response:"},{"line_number":46,"context_line":"            response.raise_for_status()  # raises only in case of HTTPError"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            data \u003d response.text"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_adc288e8","line":45,"updated":"2018-05-03 14:05:41.000000000","message":"The response object returned by requests.get() is already a context manager, do you don\u0027t need contextlib.closing().","commit_id":"646c28255db0859b7b6435db466e97a954f693da"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4fff684811ac0aee71ef05a532f8d26012aae0a1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            if option_name !\u003d opt.name:"},{"line_number":72,"context_line":"                raise"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            return opt._get_from_namespace(self._namespace, group_name)[0]"},{"line_number":75,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_0214949f","line":72,"updated":"2018-05-04 16:29:00.000000000","message":"It\u0027s possible that the name won\u0027t match, if the caller is looking for a deprecated version of the name. The Source object should use the name given in option_name for its lookup, and get other settings like the type from the opt object.","commit_id":"59b37836c6c3b7b0d27a202fabb77851e6baf2d8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"a5e9b60ee18b85dbeeba296531198c8983df6ab7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            if option_name !\u003d opt.name:"},{"line_number":72,"context_line":"                raise"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            return opt._get_from_namespace(self._namespace, group_name)[0]"},{"line_number":75,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_a9400e37","line":72,"in_reply_to":"5f7c97a3_0214949f","updated":"2018-05-07 14:01:23.000000000","message":"In this case, do I need to create a new instance of the opt object so I can call `tmp_opt._get_from_namespace(...)` or is there another way to fetch the option from the namespace?","commit_id":"59b37836c6c3b7b0d27a202fabb77851e6baf2d8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"efdfde0aa8b7f537f1e10c6ee7fd5282893c6a7e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            if option_name !\u003d opt.name:"},{"line_number":72,"context_line":"                raise"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            return opt._get_from_namespace(self._namespace, group_name)[0]"},{"line_number":75,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_e49e2d06","line":72,"in_reply_to":"5f7c97a3_a9400e37","updated":"2018-05-07 15:03:30.000000000","message":"The logic for dealing with deprecated names is inside _get_from_namspace() so I don\u0027t think we want to rely on calling that. It will mean this driver works differently from all of the other drivers, which will just do simple lookups for the (group, name) pair in their database.\n\nI think we have enough information to call _Namespace._get_value() directly. The first argument, names, is a list of possible names, which in our case should just be [option_name]. We can get the value for the multi argument from the opt as opt.multi. The positional argument should always be false (we don\u0027t support registering command line options in drivers, at least for now). I think we can leave current_name and normalized set to their default values.","commit_id":"59b37836c6c3b7b0d27a202fabb77851e6baf2d8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9de90dd11c0e0813c63c0c5a0e4830f7970d5532","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            data \u003d response.text"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            with tempfile.NamedTemporaryFile() as tmpfile:"},{"line_number":54,"context_line":"                tmpfile.write(six.b(data))"},{"line_number":55,"context_line":"                tmpfile.flush()"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_e62155a1","line":53,"updated":"2018-05-07 13:20:19.000000000","message":"This is OK for now. I wonder if we could easily refactor _parse_file() later so we can avoid writing to a file.","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9de90dd11c0e0813c63c0c5a0e4830f7970d5532","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            data \u003d response.text"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            with tempfile.NamedTemporaryFile() as tmpfile:"},{"line_number":54,"context_line":"                tmpfile.write(six.b(data))"},{"line_number":55,"context_line":"                tmpfile.flush()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                cfg.ConfigParser._parse_file(tmpfile.name, self._namespace)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_e66f15c3","line":54,"updated":"2018-05-07 13:20:19.000000000","message":"We should be explicit about encoding here and use data.encode(\u0027utf-8\u0027) instead of just converting the string to bytes using a default encoding.\n\n  \u003e\u003e\u003e s \u003d \u0027\\u0123\u0027\n  \u003e\u003e\u003e print(s)\n  ģ\n  \u003e\u003e\u003e six.b(s)\n  Traceback (most recent call last):\n    File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    File \"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/six.py\", line 626, in b\n      return s.encode(\"latin-1\")\n  UnicodeEncodeError: \u0027latin-1\u0027 codec can\u0027t encode character \u0027\\u0123\u0027 in position 0: ordinal not in range(256)","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"7d58914a50a9b255ab7bc7d7d8bc3a1ece1110fd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            data \u003d response.text"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            with tempfile.NamedTemporaryFile() as tmpfile:"},{"line_number":54,"context_line":"                tmpfile.write(six.b(data))"},{"line_number":55,"context_line":"                tmpfile.flush()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                cfg.ConfigParser._parse_file(tmpfile.name, self._namespace)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_a627dd12","line":54,"in_reply_to":"5f7c97a3_e66f15c3","updated":"2018-05-07 13:49:19.000000000","message":"Done","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9de90dd11c0e0813c63c0c5a0e4830f7970d5532","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            if option_name !\u003d opt.name:"},{"line_number":72,"context_line":"                raise"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            return opt.type("},{"line_number":75,"context_line":"                opt._get_from_namespace(self._namespace, group_name)[0]"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_269bcdc9","line":72,"updated":"2018-05-07 13:20:19.000000000","message":"See my earlier comment about the likelihood that the name won\u0027t match.","commit_id":"fe1aff95dec95f9c553bcec40f59323a91ab53c8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4083c7d79ea9f961b5916fdef03946801ef8530d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        :return: Option value or NoValue."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            return opt.type("},{"line_number":71,"context_line":"                self._namespace._get_value("},{"line_number":72,"context_line":"                    [(group_name, option_name)],"},{"line_number":73,"context_line":"                    multi\u003dopt.multi)[0]"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_6f2cd101","line":70,"updated":"2018-05-11 15:09:34.000000000","message":"I think the spec says the caller will do the type conversion, so you probably don\u0027t need this.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"2801421499998c5a5140aea8b5b7e0e0d0419a54","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        :return: Option value or NoValue."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            return opt.type("},{"line_number":71,"context_line":"                self._namespace._get_value("},{"line_number":72,"context_line":"                    [(group_name, option_name)],"},{"line_number":73,"context_line":"                    multi\u003dopt.multi)[0]"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_25725f7c","line":70,"in_reply_to":"5f7c97a3_6f2cd101","updated":"2018-05-14 11:06:40.000000000","message":"Done","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4083c7d79ea9f961b5916fdef03946801ef8530d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            return opt.type("},{"line_number":71,"context_line":"                self._namespace._get_value("},{"line_number":72,"context_line":"                    [(group_name, option_name)],"},{"line_number":73,"context_line":"                    multi\u003dopt.multi)[0]"},{"line_number":74,"context_line":"            )"},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            return sources._NoValue"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_ef3f8122","line":73,"updated":"2018-05-11 15:09:34.000000000","message":"If the option is a multi-opt, the return value should be a list, not just the first item in the list.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"41b3c94010afe0bc433a61080028057a40987f54","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            return opt.type("},{"line_number":71,"context_line":"                self._namespace._get_value("},{"line_number":72,"context_line":"                    [(group_name, option_name)],"},{"line_number":73,"context_line":"                    multi\u003dopt.multi)[0]"},{"line_number":74,"context_line":"            )"},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            return sources._NoValue"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_50e5da36","line":73,"in_reply_to":"5f7c97a3_25f7bfd5","updated":"2018-05-14 12:26:59.000000000","message":"Oh, duh, of course. Thanks.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"2801421499998c5a5140aea8b5b7e0e0d0419a54","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            return opt.type("},{"line_number":71,"context_line":"                self._namespace._get_value("},{"line_number":72,"context_line":"                    [(group_name, option_name)],"},{"line_number":73,"context_line":"                    multi\u003dopt.multi)[0]"},{"line_number":74,"context_line":"            )"},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            return sources._NoValue"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_25f7bfd5","line":73,"in_reply_to":"5f7c97a3_ef3f8122","updated":"2018-05-14 11:06:40.000000000","message":"The return of _Namespace._get_value() is a tuple: (value, location). When the opt is multi, it returns a list in the first item of the tuple.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4083c7d79ea9f961b5916fdef03946801ef8530d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    [(group_name, option_name)],"},{"line_number":73,"context_line":"                    multi\u003dopt.multi)[0]"},{"line_number":74,"context_line":"            )"},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            return sources._NoValue"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_8f7fedde","line":75,"updated":"2018-05-11 15:09:34.000000000","message":"I\u0027m not sure we want to hide all errors from the caller. If the value isn\u0027t present, we do, but if there is some other issue getting the value, we don\u0027t. So I think we need to be more specific about which exceptions we are catching here.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"2801421499998c5a5140aea8b5b7e0e0d0419a54","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    [(group_name, option_name)],"},{"line_number":73,"context_line":"                    multi\u003dopt.multi)[0]"},{"line_number":74,"context_line":"            )"},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            return sources._NoValue"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_c5ffeba8","line":75,"in_reply_to":"5f7c97a3_8f7fedde","updated":"2018-05-14 11:06:40.000000000","message":"Done","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d8c36573e8179bf7688ccf5ccfad677cb8abd3e7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        conf.register_opt(cfg.URIOpt(\"uri\","},{"line_number":29,"context_line":"                                     schemes\u003d[\"http\", \"https\"],"},{"line_number":30,"context_line":"                                     required\u003dTrue),"},{"line_number":31,"context_line":"                          cfg.OptGroup(group_name))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        return INIConfigurationSource(conf, conf[group_name].uri)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_0d50a90a","line":31,"updated":"2018-05-14 11:41:05.000000000","message":"if we allow https, it might be worth adding the CAfile and verify options somewhere here too.","commit_id":"2476cb5593e516e856fa00a73f0812ba11388b7e"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"6603a6f5016f2d8b4cd2c7e1d0ff0b5ffed098f6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        conf.register_opt(cfg.URIOpt(\"uri\","},{"line_number":29,"context_line":"                                     schemes\u003d[\"http\", \"https\"],"},{"line_number":30,"context_line":"                                     required\u003dTrue),"},{"line_number":31,"context_line":"                          cfg.OptGroup(group_name))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        return INIConfigurationSource(conf, conf[group_name].uri)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_d0feca69","line":31,"in_reply_to":"5f7c97a3_0d50a90a","updated":"2018-05-14 12:45:39.000000000","message":"Done","commit_id":"2476cb5593e516e856fa00a73f0812ba11388b7e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"990f23f2045947b81584f8ec63b2c1d3ebc16aa1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                          cfg.OptGroup(group_name))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        conf.register_opt(cfg.StrOpt(\"ca-path\"),"},{"line_number":45,"context_line":"                          cfg.OptGroup(group_name))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        conf.register_opt(cfg.StrOpt(\"client-cert\"),"},{"line_number":48,"context_line":"                          cfg.OptGroup(group_name))"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_50fcfa3c","line":45,"updated":"2018-05-14 12:52:28.000000000","message":"This one is a bit tricky. Because using verify\u003dNone will not check the CA from the remote URI. So to get proper verification, you would always need to provide the path to the CA cert. However, sometimes you might just want to use the OpenSSL bundle coming from your system. With the way it\u0027s coded right now, you can\u0027t use it, as that would require you to pass a boolean \"verify\u003dTrue\".","commit_id":"e129b6139c2174b51439be36ad485c9a7cd0c1cc"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"10b756a7e1ac93b692e1ebe33901585086e5214e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                          cfg.OptGroup(group_name))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        conf.register_opt(cfg.StrOpt(\"ca-path\"),"},{"line_number":45,"context_line":"                          cfg.OptGroup(group_name))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        conf.register_opt(cfg.StrOpt(\"client-cert\"),"},{"line_number":48,"context_line":"                          cfg.OptGroup(group_name))"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_338aa869","line":45,"in_reply_to":"5f7c97a3_50fcfa3c","updated":"2018-05-14 13:07:01.000000000","message":"Done","commit_id":"e129b6139c2174b51439be36ad485c9a7cd0c1cc"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"4f8d4f93dc1fb7271dacf6f5f3532dc14120dd85","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def __init__(self, conf, uri, ca_path, client_cert):"},{"line_number":81,"context_line":"        self._uri \u003d uri"},{"line_number":82,"context_line":"        self._namespace \u003d cfg._Namespace(conf)"},{"line_number":83,"context_line":"        self.session \u003d requests.Session()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        with requests.get(uri, verify\u003dca_path, cert\u003dclient_cert) as response:"},{"line_number":86,"context_line":"            response.raise_for_status()  # raises only in case of HTTPError"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_d05a4a81","line":83,"updated":"2018-05-14 12:50:12.000000000","message":"No need to create a session object if you won\u0027t use it.","commit_id":"e129b6139c2174b51439be36ad485c9a7cd0c1cc"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"10b756a7e1ac93b692e1ebe33901585086e5214e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def __init__(self, conf, uri, ca_path, client_cert):"},{"line_number":81,"context_line":"        self._uri \u003d uri"},{"line_number":82,"context_line":"        self._namespace \u003d cfg._Namespace(conf)"},{"line_number":83,"context_line":"        self.session \u003d requests.Session()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        with requests.get(uri, verify\u003dca_path, cert\u003dclient_cert) as response:"},{"line_number":86,"context_line":"            response.raise_for_status()  # raises only in case of HTTPError"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_939a9cb6","line":83,"in_reply_to":"5f7c97a3_d05a4a81","updated":"2018-05-14 13:07:01.000000000","message":"Done","commit_id":"e129b6139c2174b51439be36ad485c9a7cd0c1cc"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d4bddaa664630eff56d5d433e25638c64d1bbfb8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        conf.register_opt(cfg.URIOpt(\"uri\","},{"line_number":40,"context_line":"                                     schemes\u003d[\"http\", \"https\"],"},{"line_number":41,"context_line":"                                     required\u003dTrue),"},{"line_number":42,"context_line":"                          cfg.OptGroup(group_name))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        conf.register_opt(cfg.StrOpt(\"ca_path\"),"},{"line_number":45,"context_line":"                          cfg.OptGroup(group_name))"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_0a333d64","line":42,"updated":"2018-06-05 19:43:14.000000000","message":"We could use the same OptGroup instance for all of the calls, but that can be cleaned up later.","commit_id":"f5182fa44e858515dd8061e072d0f43878391727"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d4bddaa664630eff56d5d433e25638c64d1bbfb8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                 specified but does not includes the private key."},{"line_number":76,"context_line":"    \"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, conf, uri, ca_path, client_cert, client_key):"},{"line_number":79,"context_line":"        self._uri \u003d uri"},{"line_number":80,"context_line":"        self._namespace \u003d cfg._Namespace(conf)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_8a466dc0","line":78,"updated":"2018-06-05 19:43:14.000000000","message":"In order for this class to safely use the conf parameter to look up values it would need to know the group name it was constructed from. It doesn\u0027t seem to be used that way, though, so I think we can probably just drop the argument entirely for now.","commit_id":"f5182fa44e858515dd8061e072d0f43878391727"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d4bddaa664630eff56d5d433e25638c64d1bbfb8","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, conf, uri, ca_path, client_cert, client_key):"},{"line_number":79,"context_line":"        self._uri \u003d uri"},{"line_number":80,"context_line":"        self._namespace \u003d cfg._Namespace(conf)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        verify \u003d ca_path if ca_path else True"},{"line_number":83,"context_line":"        cert \u003d (client_cert, client_key) if client_cert and client_key else \\"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_2a8639dd","line":80,"updated":"2018-06-05 19:43:14.000000000","message":"Passing the external ConfigOpts object to this _Namespace is going to potentially let it modify settings that this class does not own. If we need a ConfigOpts we will need to instantiate our own to avoid polluting the one we don\u0027t own.\n\nIt would be useful to refactor _Namespace to avoid needing that argument entirely, but I don\u0027t expect you to do that work as part of this series of patches.","commit_id":"f5182fa44e858515dd8061e072d0f43878391727"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d4bddaa664630eff56d5d433e25638c64d1bbfb8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        cert \u003d (client_cert, client_key) if client_cert and client_key else \\"},{"line_number":84,"context_line":"            client_cert"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        with requests.get(uri, verify\u003dverify, cert\u003dcert) as response:"},{"line_number":87,"context_line":"            response.raise_for_status()  # raises only in case of HTTPError"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            data \u003d response.text"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_eda93bdd","line":86,"updated":"2018-06-05 19:43:14.000000000","message":"It would be a little cleaner to set up the mocks for this class if fetching the data was done in a separate method. That way the method of this class could be mocked to return the response text, instead of the test knowing to mock out the request module. We can clean that up later if you want to focus on the other changes mentioned above.","commit_id":"f5182fa44e858515dd8061e072d0f43878391727"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f68ea78d0f76a5167432b6dfc3aed89dc7142d3e","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        with tempfile.NamedTemporaryFile() as tmpfile:"},{"line_number":81,"context_line":"            tmpfile.write(data.encode(\"utf-8\"))"},{"line_number":82,"context_line":"            tmpfile.flush()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            cfg.ConfigParser._parse_file(tmpfile.name, self._namespace)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"5f7c97a3_9899197c","line":82,"updated":"2018-06-27 15:01:21.000000000","message":"Since we\u0027re just going to throw away data and the tmpfile after __init__ is done, does it make sense to parse data directly?\n\nIf ConfigParse can only parse a fileahandle, one option would be to use StringIO or a tempfile.SpooledTemporaryFile\n\nThen nothing needs to be written to disk.\n\nAnother option might be to use response.iter_content from requests.\n\nI\u0027m not sure it really matters, but it seems like writing to disk is a notable waste. Especially when file: URIs are used.","commit_id":"9dfca146835ea7dcaf6db1ca2c673e4b8278f1fa"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0d14a8f7716dce7c68e66ddf439b58571b932a6c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        :type option_name: str"},{"line_number":103,"context_line":"        :param opt: The option definition."},{"line_number":104,"context_line":"        :type opt: Opt"},{"line_number":105,"context_line":"        :return: Option value or NoValue."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            return self._namespace._get_value("}],"source_content_type":"text/x-python","patch_set":29,"id":"5f7c97a3_39708740","line":105,"updated":"2018-06-08 17:25:10.000000000","message":"Nit: This actually returns a tuple of the value, location now.  That can be fixed in a followup though.","commit_id":"9dfca146835ea7dcaf6db1ca2c673e4b8278f1fa"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"77bada26a954a6e147ae101eca1dd98999e4c89f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        :type option_name: str"},{"line_number":103,"context_line":"        :param opt: The option definition."},{"line_number":104,"context_line":"        :type opt: Opt"},{"line_number":105,"context_line":"        :return: Option value or NoValue."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            return self._namespace._get_value("}],"source_content_type":"text/x-python","patch_set":29,"id":"5f7c97a3_af30a9ea","line":105,"in_reply_to":"5f7c97a3_39708740","updated":"2018-06-11 11:13:09.000000000","message":"Done","commit_id":"9dfca146835ea7dcaf6db1ca2c673e4b8278f1fa"}],"oslo_config/tests/test_sources.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4083c7d79ea9f961b5916fdef03946801ef8530d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.conf, _extra_ini_opt_group)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # non-existing option"},{"line_number":136,"context_line":"        assert sources._NoValue \u003d\u003d source.get("},{"line_number":137,"context_line":"            \"DEFAULT\", \"bar\", cfg.StrOpt(\"bar\"))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # \u0027g\u0027 for group, \u0027o\u0027 for option and \u0027v\u0027 for (type, value)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_efdb01ea","line":136,"updated":"2018-05-11 15:09:34.000000000","message":"use self.assertIs() to test for the singleton.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"2801421499998c5a5140aea8b5b7e0e0d0419a54","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.conf, _extra_ini_opt_group)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # non-existing option"},{"line_number":136,"context_line":"        assert sources._NoValue \u003d\u003d source.get("},{"line_number":137,"context_line":"            \"DEFAULT\", \"bar\", cfg.StrOpt(\"bar\"))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # \u0027g\u0027 for group, \u0027o\u0027 for option and \u0027v\u0027 for (type, value)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_e5fc67b6","line":136,"in_reply_to":"5f7c97a3_efdb01ea","updated":"2018-05-14 11:06:40.000000000","message":"Done","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4083c7d79ea9f961b5916fdef03946801ef8530d","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # \u0027g\u0027 for group, \u0027o\u0027 for option and \u0027v\u0027 for (type, value)"},{"line_number":140,"context_line":"        for g in _extra_conf_data:"},{"line_number":141,"context_line":"            for o, v in _extra_conf_data[g].items():"},{"line_number":142,"context_line":"                assert _extra_conf_data[g][o][1] \u003d\u003d source.get(g, o, v[0](o))"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_6ff1316b","line":141,"updated":"2018-05-11 15:09:34.000000000","message":"this could be\n\n  for o, (t, v) in ...\n\nto avoid having to dereference the tuple on the next line.","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"2801421499998c5a5140aea8b5b7e0e0d0419a54","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # \u0027g\u0027 for group, \u0027o\u0027 for option and \u0027v\u0027 for (type, value)"},{"line_number":140,"context_line":"        for g in _extra_conf_data:"},{"line_number":141,"context_line":"            for o, v in _extra_conf_data[g].items():"},{"line_number":142,"context_line":"                assert _extra_conf_data[g][o][1] \u003d\u003d source.get(g, o, v[0](o))"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_852fb33d","line":141,"in_reply_to":"5f7c97a3_6ff1316b","updated":"2018-05-14 11:06:40.000000000","message":"Done","commit_id":"676785c82c208a94e4ad66184ce8c7f3f74e31e8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"43e194859485ec9b851e56bd60519ad40ea453a9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return result"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def mocked_get(*args, **kwargs):"},{"line_number":81,"context_line":"    class MockResponse(object):"},{"line_number":82,"context_line":"        def __init__(self, text_data, status_code):"},{"line_number":83,"context_line":"            self.text \u003d text_data"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_90761270","line":80,"updated":"2018-05-14 12:31:37.000000000","message":"Eventually we\u0027re going to want to replace this with something like https://pypi.org/project/requests-mock/ but we can do that in a later patch.","commit_id":"2476cb5593e516e856fa00a73f0812ba11388b7e"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"2e6d82e71970e5c1e4d2abf799ed6089da448d68","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return result"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def mocked_get(*args, **kwargs):"},{"line_number":81,"context_line":"    class MockResponse(object):"},{"line_number":82,"context_line":"        def __init__(self, text_data, status_code):"},{"line_number":83,"context_line":"            self.text \u003d text_data"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_d6448276","line":80,"in_reply_to":"5f7c97a3_90761270","updated":"2018-05-14 14:08:27.000000000","message":"Done","commit_id":"2476cb5593e516e856fa00a73f0812ba11388b7e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bba4265f82600be28b3ed41103d47112fc12b4c7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import requests_mock"},{"line_number":14,"context_line":"import tempfile"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_a19adeb5","line":13,"updated":"2018-05-14 14:21:24.000000000","message":"Because this is a third party library, the import should be down below the one for oslotest. We usually have 3 groups of imports, in order: standard library modules, modules from the current package, then other modules. Each group should be sorted alphabetically.","commit_id":"70b7f4806fad186e4121a73f81debaba9945d7ce"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"7d4574289a23b3ae23907a1f35a62757072ee787","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import requests_mock"},{"line_number":14,"context_line":"import tempfile"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_a1589e87","line":13,"in_reply_to":"5f7c97a3_a19adeb5","updated":"2018-05-14 14:39:23.000000000","message":"Done","commit_id":"70b7f4806fad186e4121a73f81debaba9945d7ce"}],"test-requirements.txt":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1ff3ede5c352c0cf62fccc97eef588d49299970e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# mocking framework"},{"line_number":21,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":22,"context_line":"requests_mock\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Bandit security code scanner"},{"line_number":25,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":16,"id":"5f7c97a3_41a18af7","line":22,"updated":"2018-05-14 14:16:03.000000000","message":"lets change it to:\n\nrequests-mock # Apache-2.0\n\nper https://github.com/openstack/requirements/blob/master/global-requirements.txt#L415","commit_id":"70b7f4806fad186e4121a73f81debaba9945d7ce"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f20577164157a35839dd2cd08202c13315d22907","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# mocking framework"},{"line_number":21,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":22,"context_line":"requests_mock\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Bandit security code scanner"},{"line_number":25,"context_line":"bandit\u003e\u003d1.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":16,"id":"5f7c97a3_015cf2ea","line":22,"in_reply_to":"5f7c97a3_41a18af7","updated":"2018-05-14 14:21:15.000000000","message":"per discussion with dhelmman in IRC; chaning it to what I mentioned is not needed. Lets leave this as-is.","commit_id":"70b7f4806fad186e4121a73f81debaba9945d7ce"}]}
