)]}'
{"oslo_config/validator.py":[{"author":{"_account_id":8911,"name":"Sergey Vilgelm","email":"sergey@vilgelm.info","username":"sergey.vilgelm"},"change_message_id":"a80760b975d789ad530fac52a086cdb1fcd1fc64","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":117,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0236a450","line":117,"updated":"2018-09-26 19:34:47.000000000","message":"main function returns 0 for valid config and 1 for invalid, but the script always returns 0\nplease wrap it in sys.exit:\n\n     sys.exit(main())\n\notherwise the code is useless","commit_id":"dd4778f67459f9238b014d877d7d8a9dc23f9900"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"fde2d925762506bbe22eb054dc5513d82f5cadf3","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":117,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_426c9c06","line":117,"in_reply_to":"3f79a3b5_0236a450","updated":"2018-09-26 19:48:27.000000000","message":"Fair point. This was only there for testing since generally the tool would be used via the console script entrypoint, but I should fix this is if the code is going to be there.","commit_id":"dd4778f67459f9238b014d877d7d8a9dc23f9900"}]}
