)]}'
{"oslo_config/_list_opts.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"431972aedc66aade004523fed6aa1992778f7033","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_config import cfg"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from stevedore import ExtensionManager"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_46041c4a","line":15,"updated":"2018-06-13 17:57:41.000000000","message":"Our normal import standards are to just import the module and then refer to the class via the module\n\n  import stevedore\n\n  stevedore.ExtensionManager(...)","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"f5baca2b199b43845ac6b00503e70cab9ffbdbb0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_config import cfg"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from stevedore import ExtensionManager"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_41087325","line":15,"in_reply_to":"5f7c97a3_46041c4a","updated":"2018-06-14 12:36:48.000000000","message":"Done","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"}],"oslo_config/sources/_uri.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b16cad875ee6fe86e954d38062e89183f89c196c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    ]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def list_options_for_discovery(self):"},{"line_number":65,"context_line":"        # NOTE(moguimar): This option is only used to provide a better"},{"line_number":66,"context_line":"        #                 description of the driver option registered"},{"line_number":67,"context_line":"        #                 by ConfigOpts._open_source_from_opt_group()."},{"line_number":68,"context_line":"        driver_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_60659744","line":65,"updated":"2018-06-25 19:11:01.000000000","message":"It would be good if the caller added this one. That way if we end up with other common options, or we want to change its name or help text, we only have to do that in one place.\n\nWe should have the caller set sample_default instead of default. That way it\u0027s clear that the option isn\u0027t actually set by default, but that \u0027remote_file\u0027 is a valid value. In fact, we could have the caller set the \"choices\" argument, just like ConfigOpts does, so the output will show all of the valid values.","commit_id":"8b1a0ff4177f0e78ec37c2f29f61711f5b525d49"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"356a5e885db524bdea0fe7e8185df470cb6facf9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    ]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def list_options_for_discovery(self):"},{"line_number":65,"context_line":"        # NOTE(moguimar): This option is only used to provide a better"},{"line_number":66,"context_line":"        #                 description of the driver option registered"},{"line_number":67,"context_line":"        #                 by ConfigOpts._open_source_from_opt_group()."},{"line_number":68,"context_line":"        driver_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_be787dc1","line":65,"in_reply_to":"5f7c97a3_60659744","updated":"2018-06-27 16:14:50.000000000","message":"I made this change in the follow-up patch https://review.openstack.org/578461","commit_id":"8b1a0ff4177f0e78ec37c2f29f61711f5b525d49"}],"oslo_config/sources/ini.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d8c62476edc12f3628f6d91e4372a48922f278ea","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                    specified but does not includes the private key."},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # NOTE(moguimar): This instances are reused by list_opts()."},{"line_number":39,"context_line":"    _driver_opt \u003d cfg.StrOpt("},{"line_number":40,"context_line":"        \u0027driver\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027ini\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_46565c5e","line":38,"updated":"2018-06-13 17:55:54.000000000","message":"Instead of making each driver include this option, we should have the caller add it.","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"4d730ed3b3670193c20c97772623d263abfb1335","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                    specified but does not includes the private key."},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # NOTE(moguimar): This instances are reused by list_opts()."},{"line_number":39,"context_line":"    _driver_opt \u003d cfg.StrOpt("},{"line_number":40,"context_line":"        \u0027driver\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027ini\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f96cdd36","line":38,"in_reply_to":"5f7c97a3_46565c5e","updated":"2018-06-14 08:47:04.000000000","message":"The driver option is actually included by ConfigOpts._open_source_from_opt_group() to identify which driver to load. This one is only for sample generation purpose. I\u0027ll move it inside the method and give it a better description.","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d8c62476edc12f3628f6d91e4372a48922f278ea","unresolved":false,"context_lines":[{"line_number":73,"context_line":"              \u0027specified but does not includes the private key.\u0027),"},{"line_number":74,"context_line":"    )"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    _ini_driver_opts \u003d ["},{"line_number":77,"context_line":"        _uri_opt,"},{"line_number":78,"context_line":"        _ca_path_opt,"},{"line_number":79,"context_line":"        _client_cert_opt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_064ce4c5","line":76,"updated":"2018-06-13 17:55:54.000000000","message":"It looks like we only ever use the options via this list, so maybe we don\u0027t need the separate class attributes?","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"4d730ed3b3670193c20c97772623d263abfb1335","unresolved":false,"context_lines":[{"line_number":73,"context_line":"              \u0027specified but does not includes the private key.\u0027),"},{"line_number":74,"context_line":"    )"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    _ini_driver_opts \u003d ["},{"line_number":77,"context_line":"        _uri_opt,"},{"line_number":78,"context_line":"        _ca_path_opt,"},{"line_number":79,"context_line":"        _client_cert_opt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_992e09f8","line":76,"in_reply_to":"5f7c97a3_064ce4c5","updated":"2018-06-14 08:47:04.000000000","message":"Done","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d8c62476edc12f3628f6d91e4372a48922f278ea","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    ]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def _list_options_for_discovery(cls):"},{"line_number":85,"context_line":"        return [cls._driver_opt] + cls._ini_driver_opts"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def open_source_from_opt_group(self, conf, group_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e6ca0818","line":84,"updated":"2018-06-13 17:55:54.000000000","message":"Since this method is going to be part of the API for the driver, we should make sure it appears in the abstract base class. We also don\u0027t need the _ prefix, since the entire driver is private to anything outside of oslo.config.","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"4d730ed3b3670193c20c97772623d263abfb1335","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    ]"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @classmethod"},{"line_number":84,"context_line":"    def _list_options_for_discovery(cls):"},{"line_number":85,"context_line":"        return [cls._driver_opt] + cls._ini_driver_opts"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def open_source_from_opt_group(self, conf, group_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5934f148","line":84,"in_reply_to":"5f7c97a3_e6ca0818","updated":"2018-06-14 08:47:04.000000000","message":"Done","commit_id":"9bc3b9c07ea311286fea9bf881463d3cbd63f717"}]}