)]}'
{"oslo_config/_list_opts.py":[{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"8c67006abebbc6541e497351b8b89e5c5264b5e0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1ba4084b","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"updated":"2018-06-28 13:56:48.000000000","message":"woudn\u0027t this state that all available drivers are a possible value for this option? Right now there is only \u0027remote_file\u0027 listed in the possible values, but what will happen when we have other available drivers?","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"acbbb72ee860b3062ae4c1c21729fd79943b0709","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_84fbb9bc","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"in_reply_to":"5f7c97a3_1647e879","updated":"2018-06-29 14:48:12.000000000","message":"Done","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c159a2a4f4d76cb4fc52419ec9a99d0f3ddcee25","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b1489562","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"in_reply_to":"5f7c97a3_1ba4084b","updated":"2018-06-28 14:31:05.000000000","message":"Well, technically those are all valid options. The actual default will be shown as the name of the current source, though, so they can see that.","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c99a8d83e9aaa79ba658f8c295ca477413e668b8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5bd8327f","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"in_reply_to":"5f7c97a3_1cbdddd6","updated":"2018-06-28 22:06:55.000000000","message":"\"If we do not show the other valid values when we describe the driver option, where would we show them?\"\n\nI suppose the other way to look at it would be that we are enumerating all of the possible driver groups, so it\u0027s kind of documented that way.\n\nI don\u0027t have super strong feelings one way or another on it though.  No matter how we document it, people need to understand that if they change the value of \"driver\" then the available options may also change.  That\u0027s independent of how we define the driver opt itself.","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"fe742c842377ac2e5cf4d2732eebf6f0fe02bd2e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_96dd38df","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"in_reply_to":"5f7c97a3_5bd8327f","updated":"2018-06-29 09:52:17.000000000","message":"When other drivers become available, there will be a sample group for each one, pinning the driver option to that specific value.","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"c7472b0ec6e90a819e0a743ae94e2863c1e8c46b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1647e879","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"in_reply_to":"5f7c97a3_96dd38df","updated":"2018-06-29 10:05:15.000000000","message":"I added a foo driver, just the two classes and the driver definition at setup.cfg:\n\n\n[DEFAULT]\n\n#\n# From oslo.config\n#\n\n# Path to a config file to use. Multiple config files can be\n# specified, with values in later files taking precedence. Defaults to\n# %(default)s. (unknown value)\n#config_file \u003d ~/.project/project.conf,~/project.conf,/etc/project/project.conf,/etc/project.conf\n\n# Path to a config directory to pull `*.conf` files from. This file\n# set is sorted, so as to provide a predictable parse order if\n# individual options are over-ridden. The set is parsed after the\n# file(s) specified via previous --config-file, arguments hence over-\n# ridden options in the directory take precedence. (list value)\n#config_dir \u003d ~/.project/project.conf.d/,~/project.conf.d/,/etc/project/project.conf.d/,/etc/project.conf.d/\n\n# Lists configuration groups that provide more details for accessing\n# configuration settings from locations other than local files. (list\n# value)\n#config_source \u003d\n\n\n[sample_foo_source]\n# Example of using a foo source\n\n#\n# From oslo.config\n#\n\n# The name of the driver that can load this configuration source.\n# (string value)\n# Possible values:\n# foo - A dummy configuration source driver.\n# remote_file - A configuration source driver for remote files served\n# through http[s].\n#driver \u003d foo\n\n# The bar string. (string value)\n#foo \u003d bar\n\n\n[sample_remote_file_source]\n# Example of using a remote_file source\n\n#\n# From oslo.config\n#\n\n# The name of the driver that can load this configuration source.\n# (string value)\n# Possible values:\n# foo - A dummy configuration source driver.\n# remote_file - A configuration source driver for remote files served\n# through http[s].\n#driver \u003d remote_file\n\n# Required option with the URI of the extra configuration file\u0027s\n# location. (uri value)\n#uri \u003d https://example.com/my-configuration.ini\n\n# The path to a CA_BUNDLE file or directory with certificates of\n# trusted CAs. (string value)\n#ca_path \u003d /etc/ca-certificates\n\n# Client side certificate, as a single file path containing either the\n# certificate only or the private key and the certificate. (string\n# value)\n#client_cert \u003d /etc/ca-certificates/service-client-keystore\n\n# Client side private key, in case client_cert is specified but does\n# not includes the private key. (string value)\n#client_key \u003d \u003cNone\u003e\n\n-----------------------------------------------------------\n\nAfter removing the choices from the driver opt in the opt discovery I get both driver opts exposed like this:\n\n# The name of the driver that can load this configuration source.\n# (string value)\n#driver \u003d foo\n\n\n# The name of the driver that can load this configuration source.\n# (string value)\n#driver \u003d remote_file","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d4c2402a3e9e2abc0cbd9f24584892956fb6d4b1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1cbdddd6","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"in_reply_to":"5f7c97a3_9c624dd9","updated":"2018-06-28 15:48:37.000000000","message":"I guess it depends on how you look at what the config generator is doing.\n\nThe definition of the \"driver\" option does not change based on which driver is selected. All of the valid driver names are valid choices for that Opt object. By changing the sample_default each time, I am trying to get the generator to show how setting the value of the driver option to a specific value does change the *other* options that work with it.\n\nIf we do not show the other valid values when we describe the driver option, where would we show them?","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"16e8443991068d0719d8dc684d7fe5d73ff5b7fb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cfg.StrOpt("},{"line_number":52,"context_line":"                name\u003d\u0027driver\u0027,"},{"line_number":53,"context_line":"                sample_default\u003dsource_name,"},{"line_number":54,"context_line":"                choices\u003dsource_descriptions,"},{"line_number":55,"context_line":"                help\u003dcfg._SOURCE_DRIVER_OPTION_HELP,"},{"line_number":56,"context_line":"            )"},{"line_number":57,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9c624dd9","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":44},"in_reply_to":"5f7c97a3_b1489562","updated":"2018-06-28 15:38:37.000000000","message":"I don\u0027t think they will be valid options in conjunction with the other options listed by that specific driver.\n\nThe user can\u0027t just go from {driver: remote_file, uri: https://..., ca_path: ...} to {driver: castellan, uri: https://..., ca_path: ...}\n\nTherefore, I don\u0027t think that the other drivers should be listed as valid options in this cases. Each driver will produce its own group with sample config and exposing their options.","commit_id":"1574a91da8eaa6235210102b7f72d57b214975ae"}]}
