)]}'
{"oslo_config/generator.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b3df854caec8045c207a2c612808cff979123327","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt("},{"line_number":74,"context_line":"        \u0027sphinx_option_replacement\u0027,"},{"line_number":75,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\u0027,"},{"line_number":76,"context_line":"        help\u003dr\u0027When the sphinx :oslo.config:option:`group.name` directive is \u0027"},{"line_number":77,"context_line":"        r\u0027found in help text, it is replaced in config files using the \u0027"},{"line_number":78,"context_line":"        r\u0027specified regex substitution string. The group and option names are \u0027"},{"line_number":79,"context_line":"        r\u0027saved in the backreferences \\g\u003cgroup\u003e and \\g\u003cname\u003e, respectively. \u0027"},{"line_number":80,"context_line":"        r\u0027For example, if the help text contains \u0027"},{"line_number":81,"context_line":"        r\u0027\":oslo.config:option:`libvirt.virt_type`\" and this conf option is \u0027"},{"line_number":82,"context_line":"        r\u0027set to r\"[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\", the help text will be converted to \u0027"},{"line_number":83,"context_line":"        r\u0027contain \"[libvirt]/virt_type\".\u0027),"},{"line_number":84,"context_line":"    cfg.StrOpt("},{"line_number":85,"context_line":"        \u0027sphinx_group_replacement\u0027,"},{"line_number":86,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f938c1ed","line":83,"range":{"start_line":76,"start_character":0,"end_line":83,"end_character":43},"updated":"2018-07-17 13:55:27.000000000","message":"nit: Could you just use a multi-line string here? It would make this much easier to read","commit_id":"982eacd49929658426ef4bdc3d91ab0323abe0c5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"74c1474a415b997b92ecc5f81fd875259d1fa772","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt("},{"line_number":74,"context_line":"        \u0027sphinx_option_replacement\u0027,"},{"line_number":75,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\u0027,"},{"line_number":76,"context_line":"        help\u003dr\u0027When the sphinx :oslo.config:option:`group.name` directive is \u0027"},{"line_number":77,"context_line":"        r\u0027found in help text, it is replaced in config files using the \u0027"},{"line_number":78,"context_line":"        r\u0027specified regex substitution string. The group and option names are \u0027"},{"line_number":79,"context_line":"        r\u0027saved in the backreferences \\g\u003cgroup\u003e and \\g\u003cname\u003e, respectively. \u0027"},{"line_number":80,"context_line":"        r\u0027For example, if the help text contains \u0027"},{"line_number":81,"context_line":"        r\u0027\":oslo.config:option:`libvirt.virt_type`\" and this conf option is \u0027"},{"line_number":82,"context_line":"        r\u0027set to r\"[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\", the help text will be converted to \u0027"},{"line_number":83,"context_line":"        r\u0027contain \"[libvirt]/virt_type\".\u0027),"},{"line_number":84,"context_line":"    cfg.StrOpt("},{"line_number":85,"context_line":"        \u0027sphinx_group_replacement\u0027,"},{"line_number":86,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bc21d2b7","line":83,"range":{"start_line":76,"start_character":0,"end_line":83,"end_character":43},"in_reply_to":"5f7c97a3_676de865","updated":"2018-07-17 17:38:21.000000000","message":"Done","commit_id":"982eacd49929658426ef4bdc3d91ab0323abe0c5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0ffd63d4ca58f04dfadbcc46aa1b96ce53f8a193","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.StrOpt("},{"line_number":74,"context_line":"        \u0027sphinx_option_replacement\u0027,"},{"line_number":75,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\u0027,"},{"line_number":76,"context_line":"        help\u003dr\u0027When the sphinx :oslo.config:option:`group.name` directive is \u0027"},{"line_number":77,"context_line":"        r\u0027found in help text, it is replaced in config files using the \u0027"},{"line_number":78,"context_line":"        r\u0027specified regex substitution string. The group and option names are \u0027"},{"line_number":79,"context_line":"        r\u0027saved in the backreferences \\g\u003cgroup\u003e and \\g\u003cname\u003e, respectively. \u0027"},{"line_number":80,"context_line":"        r\u0027For example, if the help text contains \u0027"},{"line_number":81,"context_line":"        r\u0027\":oslo.config:option:`libvirt.virt_type`\" and this conf option is \u0027"},{"line_number":82,"context_line":"        r\u0027set to r\"[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\", the help text will be converted to \u0027"},{"line_number":83,"context_line":"        r\u0027contain \"[libvirt]/virt_type\".\u0027),"},{"line_number":84,"context_line":"    cfg.StrOpt("},{"line_number":85,"context_line":"        \u0027sphinx_group_replacement\u0027,"},{"line_number":86,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_676de865","line":83,"range":{"start_line":76,"start_character":0,"end_line":83,"end_character":43},"in_reply_to":"5f7c97a3_f938c1ed","updated":"2018-07-17 14:43:06.000000000","message":"Sure; was just trying to be consistent with the surrounding code.","commit_id":"982eacd49929658426ef4bdc3d91ab0323abe0c5"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0b369f20af977370105f820943729988a8a53e26","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        default\u003dFalse,"},{"line_number":71,"context_line":"        help\u003d\u0027Only output summaries of help text to config files. Retain \u0027"},{"line_number":72,"context_line":"        \u0027longer help text for Sphinx documents.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt("},{"line_number":74,"context_line":"        \u0027sphinx_option_replacement\u0027,"},{"line_number":75,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\u0027,"},{"line_number":76,"context_line":"        help\u003dr\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5f745b68","line":73,"updated":"2019-02-11 22:10:06.000000000","message":"Is there any particular reason to make these configurable?","commit_id":"68d5b8ffd067c6c32a1fd1c4f863fef4d2446d4c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c66470fd2902306f633288aba184a6addc6bd3c5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        default\u003dFalse,"},{"line_number":71,"context_line":"        help\u003d\u0027Only output summaries of help text to config files. Retain \u0027"},{"line_number":72,"context_line":"        \u0027longer help text for Sphinx documents.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt("},{"line_number":74,"context_line":"        \u0027sphinx_option_replacement\u0027,"},{"line_number":75,"context_line":"        default\u003dr\u0027[\\g\u003cgroup\u003e]/\\g\u003cname\u003e\u0027,"},{"line_number":76,"context_line":"        help\u003dr\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_65743269","line":73,"in_reply_to":"9fdfeff1_5f745b68","updated":"2019-02-11 23:32:14.000000000","message":"Probably not worth bothering with, assuming we all immediately agree that the defaults are reasonable :)\n\nI\u0027ll swap this out once we\u0027ve heard back from Stephen (assuming non-negative response there).","commit_id":"68d5b8ffd067c6c32a1fd1c4f863fef4d2446d4c"}]}