)]}'
{"oslo_config/migrator.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9cfb2dfd8874459db5650e774f0fa518ee58d6c7","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    for map_old2new_opt in map_old2new_opts:"},{"line_number":178,"context_line":"        if (new_section, new_key) \u003d\u003d map_old2new_opt[\u0027new-opt\u0027]:"},{"line_number":179,"context_line":"            return (x for x in map_old2new_opt[\u0027old-opt\u0027])"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def register_cli_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_db7ee719","line":179,"updated":"2018-10-02 13:44:58.000000000","message":"This just turns the list into a generator expression. Is there any reason not to do\n\n  return map_old2new_opt[\u0027old-opt\u0027]\n\nhere?","commit_id":"6745487ab7e650a11844a4bbd12ca6fd519661f0"},{"author":{"_account_id":28278,"name":"Duc Nguyen","email":"ducnv41@viettel.com.vn","username":"ducnv"},"change_message_id":"cfa2d4384094646d8a67068aa804d3b8ca24961c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    for map_old2new_opt in map_old2new_opts:"},{"line_number":178,"context_line":"        if (new_section, new_key) \u003d\u003d map_old2new_opt[\u0027new-opt\u0027]:"},{"line_number":179,"context_line":"            return (x for x in map_old2new_opt[\u0027old-opt\u0027])"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def register_cli_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_48fd1ab0","line":179,"in_reply_to":"3f79a3b5_db7ee719","updated":"2018-10-03 09:03:57.000000000","message":"This is my mistake. Your suggest is correct, I will update in the next patch, thanks.","commit_id":"6745487ab7e650a11844a4bbd12ca6fd519661f0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9cfb2dfd8874459db5650e774f0fa518ee58d6c7","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.new_conf \u003d None"},{"line_number":246,"context_line":"        self.old_opts_in_file \u003d []"},{"line_number":247,"context_line":"        self.new_opts_in_file \u003d []"},{"line_number":248,"context_line":"        self.map_old2new_opts \u003d []"},{"line_number":249,"context_line":"        self.deprecated_opts \u003d {}"},{"line_number":250,"context_line":"        self.all_opts \u003d {}"},{"line_number":251,"context_line":"        self.wrong_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_fb8163fb","line":248,"updated":"2018-10-02 13:44:58.000000000","message":"If this is \"mapping\" from old to new, could we use a dictionary?","commit_id":"6745487ab7e650a11844a4bbd12ca6fd519661f0"},{"author":{"_account_id":28278,"name":"Duc Nguyen","email":"ducnv41@viettel.com.vn","username":"ducnv"},"change_message_id":"cfa2d4384094646d8a67068aa804d3b8ca24961c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        self.new_conf \u003d None"},{"line_number":246,"context_line":"        self.old_opts_in_file \u003d []"},{"line_number":247,"context_line":"        self.new_opts_in_file \u003d []"},{"line_number":248,"context_line":"        self.map_old2new_opts \u003d []"},{"line_number":249,"context_line":"        self.deprecated_opts \u003d {}"},{"line_number":250,"context_line":"        self.all_opts \u003d {}"},{"line_number":251,"context_line":"        self.wrong_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_db0b3279","line":248,"in_reply_to":"3f79a3b5_fb8163fb","updated":"2018-10-03 09:03:57.000000000","message":"This attribute mapping all opts in old config file to new opt, so it is list of dictionary. You can see line 268..270\n\nIt is mapping between \u0027old_opts_in_file\u0027 and \u0027new_opts_in_file\u0027","commit_id":"6745487ab7e650a11844a4bbd12ca6fd519661f0"},{"author":{"_account_id":28278,"name":"Duc Nguyen","email":"ducnv41@viettel.com.vn","username":"ducnv"},"change_message_id":"b4a9ac6eebaf3eab9896aa33e48b828e10fb4897","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"def _mapping_configuration(vars_config):"},{"line_number":288,"context_line":"    \"\"\"Mapping old configuration to new configuration.\"\"\""},{"line_number":289,"context_line":"    old_opts \u003d copy.deepcopy(vars_config.old_opts_in_file)"},{"line_number":290,"context_line":"    for section, options in vars_config.deprecated_opts.items():"},{"line_number":291,"context_line":"        for option in options:"},{"line_number":292,"context_line":"            old_key \u003d option[\u0027name\u0027]"},{"line_number":293,"context_line":"            new_key \u003d option[\u0027replacement_name\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":294,"context_line":"            new_section \u003d option[\u0027replacement_group\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":295,"context_line":"            old_value \u003d _get_value(vars_config.old_conf, new_section, new_key)"},{"line_number":296,"context_line":"            group \u003d (section, old_key)"},{"line_number":297,"context_line":"            if group not in vars_config.old_opts_in_file:"},{"line_number":298,"context_line":"                continue"},{"line_number":299,"context_line":"            upgrade_converter \u003d _get_upgrade_converter("},{"line_number":300,"context_line":"                options\u003dvars_config.all_opts,"},{"line_number":301,"context_line":"                section\u003dnew_section,"},{"line_number":302,"context_line":"                key\u003dnew_key)"},{"line_number":303,"context_line":"            new_value \u003d _upgrade_value(upgrade_converter, option, old_value)"},{"line_number":304,"context_line":"            # TODO(namnh): In case of, mapping from M*N -\u003e 1 option."},{"line_number":305,"context_line":"            # \"transport_url\" is a big example for this case."},{"line_number":306,"context_line":"            # M is the number of options in a driver for"},{"line_number":307,"context_line":"            # message queue, N is the number of drivers (N\u003e1)."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            _change_default_value(section\u003dnew_section,"},{"line_number":310,"context_line":"                                  name\u003dnew_key, value\u003dnew_value,"},{"line_number":311,"context_line":"                                  vars_config\u003dvars_config)"},{"line_number":312,"context_line":"            old_opts.remove(group)"},{"line_number":313,"context_line":"            vars_config.new_opts_in_file.remove((new_section, new_key))"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    for section, options in vars_config.all_opts.items():"},{"line_number":316,"context_line":"        for option in options[\u0027opts\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_620b867b","side":"PARENT","line":313,"range":{"start_line":289,"start_character":4,"end_line":313,"end_character":71},"updated":"2018-10-12 09:27:14.000000000","message":"this block of codes is considered redundant, so it\u0027s deleted to clean and optimize the function.","commit_id":"c251529cc0f595f2df2f745ca37fee3f7af31fd3"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4d7b5e536954ac9549684b3ddf09dad5a6024379","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                new_section \u003d option[\u0027replacement_group\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":255,"context_line":"                old_key \u003d option[\u0027name\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":256,"context_line":"                if (section, old_key) in self.old_opts_in_file:"},{"line_number":257,"context_line":"                    map_old2new_opt \u003d {\u0027old-opt\u0027: (section, old_key),"},{"line_number":258,"context_line":"                                       \u0027new-opt\u0027: (new_section, new_key)}"},{"line_number":259,"context_line":"                    self.map_old2new_opts.append(map_old2new_opt)"},{"line_number":260,"context_line":"                    self.new_opts_in_file.append((new_section, new_key))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_25f00766","line":257,"updated":"2018-10-26 22:19:43.000000000","message":"Tuples can be dict keys, so this structure could be simplified to just {(section, old_key): (new_section, new_key)}","commit_id":"c1f81a2013938bdace1b6f71084bb764db8edbad"},{"author":{"_account_id":28278,"name":"Duc Nguyen","email":"ducnv41@viettel.com.vn","username":"ducnv"},"change_message_id":"2e6ffd37efb7bdceed3dbcb20dadda40a9faa407","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                new_section \u003d option[\u0027replacement_group\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":255,"context_line":"                old_key \u003d option[\u0027name\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":256,"context_line":"                if (section, old_key) in self.old_opts_in_file:"},{"line_number":257,"context_line":"                    map_old2new_opt \u003d {\u0027old-opt\u0027: (section, old_key),"},{"line_number":258,"context_line":"                                       \u0027new-opt\u0027: (new_section, new_key)}"},{"line_number":259,"context_line":"                    self.map_old2new_opts.append(map_old2new_opt)"},{"line_number":260,"context_line":"                    self.new_opts_in_file.append((new_section, new_key))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_f3a5d101","line":257,"in_reply_to":"3f79a3b5_25f00766","updated":"2018-10-30 11:03:01.000000000","message":"Thanks, good comment for me. I will update it","commit_id":"c1f81a2013938bdace1b6f71084bb764db8edbad"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4d7b5e536954ac9549684b3ddf09dad5a6024379","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                    # Note(namnh): We only solve options that have in"},{"line_number":302,"context_line":"                    # the config file"},{"line_number":303,"context_line":"                    continue"},{"line_number":304,"context_line":"                else:"},{"line_number":305,"context_line":"                    old_section, old_key \u003d _find_new2old_opt("},{"line_number":306,"context_line":"                        vars_config.map_old2new_opts, section, key)"},{"line_number":307,"context_line":"                    old_value \u003d _get_value_file(vars_config.old_conf,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_25bec763","line":304,"updated":"2018-10-26 22:19:43.000000000","message":"else is not necessary here. If we take the if branch above then the continue will skip all this code anyway.","commit_id":"c1f81a2013938bdace1b6f71084bb764db8edbad"},{"author":{"_account_id":28278,"name":"Duc Nguyen","email":"ducnv41@viettel.com.vn","username":"ducnv"},"change_message_id":"2e6ffd37efb7bdceed3dbcb20dadda40a9faa407","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                    # Note(namnh): We only solve options that have in"},{"line_number":302,"context_line":"                    # the config file"},{"line_number":303,"context_line":"                    continue"},{"line_number":304,"context_line":"                else:"},{"line_number":305,"context_line":"                    old_section, old_key \u003d _find_new2old_opt("},{"line_number":306,"context_line":"                        vars_config.map_old2new_opts, section, key)"},{"line_number":307,"context_line":"                    old_value \u003d _get_value_file(vars_config.old_conf,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_f3415109","line":304,"in_reply_to":"3f79a3b5_25bec763","updated":"2018-10-30 11:03:01.000000000","message":"Done :)","commit_id":"c1f81a2013938bdace1b6f71084bb764db8edbad"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"770edf52424d67634b0fbd1e6a5f2f60fbc673d1","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                new_section \u003d option[\u0027replacement_group\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":258,"context_line":"                old_key \u003d option[\u0027name\u0027].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":259,"context_line":"                if (section, old_key) in self.old_opts_in_file:"},{"line_number":260,"context_line":"                    self.map_old2new_opts[(section, old_key)] \u003d ("},{"line_number":261,"context_line":"                        new_section, new_key)"},{"line_number":262,"context_line":"                    self.new_opts_in_file.append((new_section, new_key))"},{"line_number":263,"context_line":"                    copy_old_opts.remove((section, old_key))"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_a2697723","line":260,"updated":"2018-11-08 20:11:22.000000000","message":"If we invert this mapping, then the _find_new2old_opt function becomes just a dict lookup. So instead of making the map {old: new}, we make the map {new: old} and then when we need to find the old opt that goes with a new opt you can just do map_old2new_opts[new] (also, that variable should be renamed map_new2old_opts).","commit_id":"a8a9511c0421b24c13e6efce664a5c510b7fcd07"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"770edf52424d67634b0fbd1e6a5f2f60fbc673d1","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                    # the config file"},{"line_number":301,"context_line":"                    old_section, old_key \u003d _find_new2old_opt("},{"line_number":302,"context_line":"                        vars_config.map_old2new_opts, section, key)"},{"line_number":303,"context_line":"                    old_value \u003d _get_value_file(vars_config.old_conf,"},{"line_number":304,"context_line":"                                                old_section, old_key)[0]"},{"line_number":305,"context_line":"                    new_value \u003d _upgrade_value(option[\u0027convert_on_upgrade\u0027],"},{"line_number":306,"context_line":"                                               option,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_229a4711","line":303,"range":{"start_line":303,"start_character":32,"end_line":303,"end_character":47},"updated":"2018-11-08 20:11:22.000000000","message":"If I\u0027m understanding correctly, this is the actual fix. Previously we were trying to look up a value from an old config using _get_value, but using the new config opts. This didn\u0027t work because the old values weren\u0027t valid for the new opts.\n\nHowever, _get_value_file reads directly from the underlying namespace data, which bypasses the sanity checking of the config types and allows us to read values that would actually be invalid for the new config opts.","commit_id":"a8a9511c0421b24c13e6efce664a5c510b7fcd07"}],"oslo_config/tests/test_migrator.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4d7b5e536954ac9549684b3ddf09dad5a6024379","unresolved":false,"context_lines":[{"line_number":545,"context_line":"                                  deprecated_name\u003d\u0027deprecated_choices_opt\u0027,"},{"line_number":546,"context_line":"                                  deprecated_group\u003d\u0027group1\u0027,"},{"line_number":547,"context_line":"                                  choices\u003d(\u0027a_update\u0027, \u0027b_update\u0027, \u0027c_update\u0027,"},{"line_number":548,"context_line":"                                           \u0027a\u0027, \u0027b\u0027, \u0027c\u0027),"},{"line_number":549,"context_line":"                                  convert_on_upgrade\u003dchoice_opt_converter,"},{"line_number":550,"context_line":"                                  help\u003d\u0027This option is to replace \u0027"},{"line_number":551,"context_line":"                                       \u0027deprecated_choices_opt\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_85247b0f","side":"PARENT","line":548,"updated":"2018-10-26 22:19:43.000000000","message":"I don\u0027t think this is a valid change to the opt definition as long as it has a deprecated opt set that still allows these values. It would break anyone still using the deprecated form of the opt.","commit_id":"c251529cc0f595f2df2f745ca37fee3f7af31fd3"},{"author":{"_account_id":28278,"name":"Duc Nguyen","email":"ducnv41@viettel.com.vn","username":"ducnv"},"change_message_id":"2e6ffd37efb7bdceed3dbcb20dadda40a9faa407","unresolved":false,"context_lines":[{"line_number":545,"context_line":"                                  deprecated_name\u003d\u0027deprecated_choices_opt\u0027,"},{"line_number":546,"context_line":"                                  deprecated_group\u003d\u0027group1\u0027,"},{"line_number":547,"context_line":"                                  choices\u003d(\u0027a_update\u0027, \u0027b_update\u0027, \u0027c_update\u0027,"},{"line_number":548,"context_line":"                                           \u0027a\u0027, \u0027b\u0027, \u0027c\u0027),"},{"line_number":549,"context_line":"                                  convert_on_upgrade\u003dchoice_opt_converter,"},{"line_number":550,"context_line":"                                  help\u003d\u0027This option is to replace \u0027"},{"line_number":551,"context_line":"                                       \u0027deprecated_choices_opt\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_2e09a281","side":"PARENT","line":548,"in_reply_to":"3f79a3b5_85247b0f","updated":"2018-10-30 11:03:01.000000000","message":"Yes! (a,b,c) are old values, so the \u0027choices\u0027 list should be (\u0027a_update\u0027, \u0027b_update\u0027, \u0027c_update\u0027)","commit_id":"c251529cc0f595f2df2f745ca37fee3f7af31fd3"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4d7b5e536954ac9549684b3ddf09dad5a6024379","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        \u0027choices_opt\u0027: cfg.StrOpt(\u0027choices_opt\u0027,"},{"line_number":536,"context_line":"                                  deprecated_name\u003d\u0027deprecated_choices_opt\u0027,"},{"line_number":537,"context_line":"                                  deprecated_group\u003d\u0027group1\u0027,"},{"line_number":538,"context_line":"                                  choices\u003d(\u0027a_update\u0027, \u0027b\u0027, \u0027c_update\u0027),"},{"line_number":539,"context_line":"                                  convert_on_upgrade\u003dchoice_opt_converter,"},{"line_number":540,"context_line":"                                  help\u003d\u0027This option is to replace \u0027"},{"line_number":541,"context_line":"                                       \u0027deprecated_choices_opt\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_2579e7f9","line":538,"updated":"2018-10-26 22:19:43.000000000","message":"That said, I do like testing the case where some choices are changed but not others. That seems like a very valid use case, if maybe a driver gets renamed or something. So maybe we leave a and c as choices too, but leave b alone like you do here.","commit_id":"c1f81a2013938bdace1b6f71084bb764db8edbad"},{"author":{"_account_id":28278,"name":"Duc Nguyen","email":"ducnv41@viettel.com.vn","username":"ducnv"},"change_message_id":"fe5f39fa5cfc5e06ad460c862d041b808dc4c22c","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        \u0027choices_opt\u0027: cfg.StrOpt(\u0027choices_opt\u0027,"},{"line_number":536,"context_line":"                                  deprecated_name\u003d\u0027deprecated_choices_opt\u0027,"},{"line_number":537,"context_line":"                                  deprecated_group\u003d\u0027group1\u0027,"},{"line_number":538,"context_line":"                                  choices\u003d(\u0027a_update\u0027, \u0027b\u0027, \u0027c_update\u0027),"},{"line_number":539,"context_line":"                                  convert_on_upgrade\u003dchoice_opt_converter,"},{"line_number":540,"context_line":"                                  help\u003d\u0027This option is to replace \u0027"},{"line_number":541,"context_line":"                                       \u0027deprecated_choices_opt\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_f1e902e4","line":538,"in_reply_to":"3f79a3b5_2579e7f9","updated":"2018-11-02 08:45:21.000000000","message":"Sorry for making it confusing. The choices list should be (\u0027a_update\u0027, \u0027b_update\u0027, \u0027c_update\u0027) for it to be compatible with the base patch set. I used a shortcut, while it should be divided into two cases: one with \u0027b_update\u0027 and one with \u0027b\u0027","commit_id":"c1f81a2013938bdace1b6f71084bb764db8edbad"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"770edf52424d67634b0fbd1e6a5f2f60fbc673d1","unresolved":false,"context_lines":[{"line_number":464,"context_line":"scenario_12 \u003d {"},{"line_number":465,"context_line":"    \u0027name\u0027: \u0027scenario 12\u0027,"},{"line_number":466,"context_line":"    \u0027purpose\u0027: \u0027\u0027\u0027"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"\u0027\u0027\u0027,"},{"line_number":469,"context_line":"    \u0027old_content_file\u0027: \u0027\u0027\u0027[DEFAULT]"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_47867518","line":467,"updated":"2018-11-08 20:11:22.000000000","message":"I would prefer that purpose be filled in if we\u0027re going to have that field on the scenarios.","commit_id":"a8a9511c0421b24c13e6efce664a5c510b7fcd07"}]}
