)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9ad0a284235a15906f624510dc2ad3ca9faa42ed","unresolved":false,"context_lines":[{"line_number":18,"context_line":"These implementations sometimes forgot to use a safe loader"},{"line_number":19,"context_line":"or safe dumper, our implementation use safe by default."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"You can deactive safe by passing the argument is_safe to false when"},{"line_number":22,"context_line":"you call oslo_config.utils.yaml.load or oslo_config.utils.yaml.dump."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I63e85a2b4fc999e6acac12ae51c2ab8c64bddbc6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b297e237","line":21,"updated":"2018-11-05 11:28:06.000000000","message":"I suggest to explain that the API is \"safe by default\".","commit_id":"90d92be97862f0a823a5c071a71ce975c1ebff06"}],"oslo_config/tests/utils/test_yaml.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9ad0a284235a15906f624510dc2ad3ca9faa42ed","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from oslotest import base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config.utils import yaml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ExceptionsLoadTestCase(base.BaseTestCase):"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1284960d","line":17,"updated":"2018-11-05 11:28:06.000000000","message":"It would like to see a test for a valid YAML file, not only errors :-) Test a few YAML formats, like a list, value on multiple lines, etc. (Not test the full YAML syntax, just 2 or 3 most common formats).\n\nShould we test Unicode, for example ensure that we always use UTF-8? I\u0027m not sure, since your functions expect an already open file. Do we need functions accept a filename instead, to open the file with the correct encoding?","commit_id":"90d92be97862f0a823a5c071a71ce975c1ebff06"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9ad0a284235a15906f624510dc2ad3ca9faa42ed","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_constructor_error(self):"},{"line_number":22,"context_line":"        payload \u003d \"!!python/object/apply:os.system [\u0027uname -a\u0027]\""},{"line_number":23,"context_line":"        self.assertRaises(yaml.ConstructorError, yaml.load, payload)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_contructor_error_false(self):"},{"line_number":26,"context_line":"        payload \u003d \u0027\u0027\u0027!!python/object/apply:os.system [\u0027echo \"hello\"\u0027]\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b289222a","line":23,"updated":"2018-11-05 11:28:06.000000000","message":"Can you please add a test with is_safe\u003dFalse and execute arbitrary Python code, a very simple exception like \"Hello %s\" % \"World\", or something like that.","commit_id":"90d92be97862f0a823a5c071a71ce975c1ebff06"}],"oslo_config/utils/yaml.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9ad0a284235a15906f624510dc2ad3ca9faa42ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import yaml"},{"line_number":14,"context_line":"from yaml.constructor import ConstructorError as BaseConstructorError"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_72be2acf","line":11,"updated":"2018-11-05 11:28:06.000000000","message":"I don\u0027t see the point of creating a subdirectory. Please put it at the top level, oslo_config/yaml.py.","commit_id":"90d92be97862f0a823a5c071a71ce975c1ebff06"}]}