)]}'
{"oslo_config/sphinxext.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b290f8df691be048bc1130ae13afd041f8872cae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from typing import Any, Dict  # noqa"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from docutils import nodes"},{"line_number":16,"context_line":"from docutils.parsers import rst"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_59df93d5","line":13,"updated":"2019-01-27 15:57:14.000000000","message":"Rather than using noqa, we should update the flake8 section of tox.ini to allow imports like this from the typing module. See https://docs.openstack.org/oslo.i18n/latest/user/usage.html#handling-hacking-objections-to-imports for an example of how to do that.","commit_id":"e084744c0087d16ac00638e5ad84680babd9ce0e"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"e107c3e137f47fc94c8a64fe8cf725834026e792","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from typing import Any, Dict  # noqa"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from docutils import nodes"},{"line_number":16,"context_line":"from docutils.parsers import rst"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ba754366","line":13,"in_reply_to":"9fdfeff1_3791734f","updated":"2019-01-28 15:38:04.000000000","message":"Yes, the issue here is not the \"import style\", but rather the fact that \"Any\" and \"Dict\" are unused since they only appear in comments. I am not sure hacking can suppress these warnings, but I may be mistaken.","commit_id":"e084744c0087d16ac00638e5ad84680babd9ce0e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"517c45ae7b1ddf1a18cb4d0f23866169073cce54","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from typing import Any, Dict  # noqa"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from docutils import nodes"},{"line_number":16,"context_line":"from docutils.parsers import rst"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3791734f","line":13,"in_reply_to":"9fdfeff1_59df93d5","updated":"2019-01-28 10:52:32.000000000","message":"Yes and no. The reason it\u0027s noqa is because we\u0027re using the comment-style syntax. Once we could move to the proper Py3 syntax in U, we\u0027d be able to remove these. I\u0027d personally suffer the pain until then","commit_id":"e084744c0087d16ac00638e5ad84680babd9ce0e"}]}
