)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0a656f64d271125ceffd81ac14e146558256e753","unresolved":false,"context_lines":[{"line_number":18,"context_line":"personally question whether anyone is configuring this, but that\u0027s a"},{"line_number":19,"context_line":"fight for another day."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also note that this might caught issues for people who are using invalid"},{"line_number":22,"context_line":"rST in their docstrings or use roles/directives in their config options"},{"line_number":23,"context_line":"that aren\u0027t part of the standard Sphinx set or oslo.config set. They"},{"line_number":24,"context_line":"will already be seeing the former issues if they are using the"},{"line_number":25,"context_line":"\u0027sphinxext\u0027 extension though, and the latter sounds like it would be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_81b20f93","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":23},"updated":"2019-02-28 15:19:46.000000000","message":"When people do this, they\u0027ll see messages like the following emitted to their configuration files.\n\n  # \u003cSYSTEM MESSAGE: \u003cstring\u003e:1: (WARNING/2) Inline literal start-string\n  # without end-string.\u003e\n\nThis seems valid, so I suggest we either keep them or add a toggle to switch between rst-ified parsing and straight forward dumping of descriptions.","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7fde93275462b6e84f3e71bf706bb07d0c6d3330","unresolved":false,"context_lines":[{"line_number":19,"context_line":"fight for another day."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also note that this might caught issues for people who are using invalid"},{"line_number":22,"context_line":"rST in their docstrings or use roles/directives in their config options"},{"line_number":23,"context_line":"that aren\u0027t part of the standard Sphinx set or oslo.config set. They"},{"line_number":24,"context_line":"will already be seeing the former issues if they are using the"},{"line_number":25,"context_line":"\u0027sphinxext\u0027 extension though, and the latter sounds like it would be"},{"line_number":26,"context_line":"fairly rare."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_a1d633c2","line":23,"range":{"start_line":22,"start_character":26,"end_line":23,"end_character":63},"updated":"2019-02-28 15:17:12.000000000","message":"When people do this, they\u0027ll see messages like the following emitted to their configuration files.\n\n  # \u003cSYSTEM MESSAGE: \u003cstring\u003e:1: (ERROR/3) Unknown interpreted text role\n  # \"oslo.config:option\".\u003e\n\nI can work around by this by simply stripping the and emitting the body of the role in rst2txt, but I\u0027m not sure if this is always such a sensible thing to do.","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5283fb3dae81e800938baa873e529255a17d4ecb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"fight for another day."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also note that this might caught issues for people who are using invalid"},{"line_number":22,"context_line":"rST in their docstrings or use roles/directives in their config options"},{"line_number":23,"context_line":"that aren\u0027t part of the standard Sphinx set or oslo.config set. They"},{"line_number":24,"context_line":"will already be seeing the former issues if they are using the"},{"line_number":25,"context_line":"\u0027sphinxext\u0027 extension though, and the latter sounds like it would be"},{"line_number":26,"context_line":"fairly rare."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_9ed12926","line":23,"range":{"start_line":22,"start_character":26,"end_line":23,"end_character":63},"in_reply_to":"5fc1f717_33eef088","updated":"2019-03-26 23:32:52.000000000","message":"I think I was asking if we (already) render e.g. links_, ``literals``, etc. in the generated *html* document for config options. It looks like we do. So do we also (today, before this change) try to apply roles like :oslo.config:option: in the html config reference? I\u0027m sure I tried that first when I started on this project, but I can\u0027t remember if it worked (and I just needed to deal with the ugliness in the text based genconfig) or not (and I had to add it first).","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3370c6f888db32c3c63f75fbd4a27bf5fa303ec","unresolved":false,"context_lines":[{"line_number":19,"context_line":"fight for another day."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also note that this might caught issues for people who are using invalid"},{"line_number":22,"context_line":"rST in their docstrings or use roles/directives in their config options"},{"line_number":23,"context_line":"that aren\u0027t part of the standard Sphinx set or oslo.config set. They"},{"line_number":24,"context_line":"will already be seeing the former issues if they are using the"},{"line_number":25,"context_line":"\u0027sphinxext\u0027 extension though, and the latter sounds like it would be"},{"line_number":26,"context_line":"fairly rare."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_33eef088","line":23,"range":{"start_line":22,"start_character":26,"end_line":23,"end_character":63},"in_reply_to":"9fdfeff1_924d7173","updated":"2019-03-05 19:11:35.000000000","message":"\u003e Perhaps the answer here is to make this functionality opt-in via a\n \u003e configuration setting. Projects that want to make use of real\n \u003e sphinx-isms in their config opt help can switch it on, vet their\n \u003e output, fix stuff, and then turn on -W to catch future violations.\n \u003e But folks who don\u0027t care and/or are currently seriously broken and\n \u003e don\u0027t want to fix it, don\u0027t have to.\n\nThat\u0027s what I\u0027m thinking too. The only reason I haven\u0027t is because I\u0027m trying to assess how likely this is. I\u0027ve no idea where to even start with that.\n\n \u003e But wait, am I misunderstanding? Do the HTML-ified config docs\n \u003e already attempt to render sphinxisms? And how do those show up in\n \u003e the sample config today? (I\u0027m sure I knew that answer when I\n \u003e started this whole thing, but I\u0027ve slept since then.)\n\nThe Sphinx\u0027isms are rendered in the HTML docs (i.e. docs.o.o). They\u0027re not rendered for sample configs (nova.conf.sample) generated by oslo-config-generator though. Is that what you meant?","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4a34cf8ebf0136faf468eac2fa1967d59f2b2ca2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"fight for another day."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also note that this might caught issues for people who are using invalid"},{"line_number":22,"context_line":"rST in their docstrings or use roles/directives in their config options"},{"line_number":23,"context_line":"that aren\u0027t part of the standard Sphinx set or oslo.config set. They"},{"line_number":24,"context_line":"will already be seeing the former issues if they are using the"},{"line_number":25,"context_line":"\u0027sphinxext\u0027 extension though, and the latter sounds like it would be"},{"line_number":26,"context_line":"fairly rare."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_924d7173","line":23,"range":{"start_line":22,"start_character":26,"end_line":23,"end_character":63},"in_reply_to":"9fdfeff1_a1d633c2","updated":"2019-02-28 23:17:53.000000000","message":"Perhaps the answer here is to make this functionality opt-in via a configuration setting. Projects that want to make use of real sphinx-isms in their config opt help can switch it on, vet their output, fix stuff, and then turn on -W to catch future violations. But folks who don\u0027t care and/or are currently seriously broken and don\u0027t want to fix it, don\u0027t have to.\n\nBut wait, am I misunderstanding? Do the HTML-ified config docs already attempt to render sphinxisms? And how do those show up in the sample config today? (I\u0027m sure I knew that answer when I started this whole thing, but I\u0027ve slept since then.)","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"}],"oslo_config/generator.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c522bf93b8c6600df417a9f9fefa95085f5ab1ec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import json"},{"line_number":29,"context_line":"import logging"},{"line_number":30,"context_line":"import operator"},{"line_number":31,"context_line":"import sys"},{"line_number":32,"context_line":"from docutils import core as docutils_core"},{"line_number":33,"context_line":"from docutils.parsers.rst import nodes as docutils_nodes"},{"line_number":34,"context_line":"from docutils.parsers.rst import roles as docutils_roles"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_817d9ce8","line":31,"updated":"2020-07-15 17:19:42.000000000","message":"Need linebreak before the docutils imports so the third party imports are grouped separately from the std lib imports.","commit_id":"1dde5ae0897062025f265928bb3e7702a8aff04d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b939a76777beb6b0377dd503a223e376d44c2582","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import logging"},{"line_number":30,"context_line":"import operator"},{"line_number":31,"context_line":"import sys"},{"line_number":32,"context_line":"from docutils import core as docutils_core"},{"line_number":33,"context_line":"from docutils.parsers.rst import nodes as docutils_nodes"},{"line_number":34,"context_line":"from docutils.parsers.rst import roles as docutils_roles"},{"line_number":35,"context_line":"import rst2txt"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e16d78cc","line":32,"updated":"2020-07-15 17:01:38.000000000","message":"pep8: H306: imports not in alphabetical order (sys, docutils.core)","commit_id":"1dde5ae0897062025f265928bb3e7702a8aff04d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6843b0638eea2eb135ebf043396ed16ed469f1ed","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from docutils.parsers.rst import nodes as docutils_nodes"},{"line_number":34,"context_line":"from docutils.parsers.rst import roles as docutils_roles"},{"line_number":35,"context_line":"import rst2txt"},{"line_number":36,"context_line":"from sphinx import roles as sphinx_roles"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"try:"},{"line_number":39,"context_line":"    # For Python 3.8 and later"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_8193dc4e","line":36,"updated":"2020-07-15 17:11:51.000000000","message":"Sphinx would need to be included in the extra dependencies, too.","commit_id":"1dde5ae0897062025f265928bb3e7702a8aff04d"}],"oslo_config/tests/test_generator.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4a34cf8ebf0136faf468eac2fa1967d59f2b2ca2","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"[group1]"},{"line_number":270,"context_line":"# Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do"},{"line_number":271,"context_line":"# eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad"},{"line_number":272,"context_line":"# minim veniam, quis nostrud exercitation ullamco laboris nisi ut"},{"line_number":273,"context_line":"# aliquip ex ea commodo consequat. Duis aute irure dolor in."},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_df2a228f","line":271,"range":{"start_line":271,"start_character":70,"end_line":271,"end_character":72},"updated":"2019-02-28 23:17:53.000000000","message":"bunch of unrelated reparagraphing; was this the result of the line wrap thing you mentioned?","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3370c6f888db32c3c63f75fbd4a27bf5fa303ec","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"[group1]"},{"line_number":270,"context_line":"# Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do"},{"line_number":271,"context_line":"# eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad"},{"line_number":272,"context_line":"# minim veniam, quis nostrud exercitation ullamco laboris nisi ut"},{"line_number":273,"context_line":"# aliquip ex ea commodo consequat. Duis aute irure dolor in."},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_33a35052","line":271,"range":{"start_line":271,"start_character":70,"end_line":271,"end_character":72},"in_reply_to":"9fdfeff1_df2a228f","updated":"2019-03-05 19:11:35.000000000","message":"Yup. I\u0027m not entirely sure why either. It\u0027s a weird one.","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4a34cf8ebf0136faf468eac2fa1967d59f2b2ca2","unresolved":false,"context_lines":[{"line_number":372,"context_line":"# This is some rst-ified help text. We reference commands like"},{"line_number":373,"context_line":"# **sphinx**, use \"literals\", make the most of hyperlinks, and even use"},{"line_number":374,"context_line":"# *oslo.config*\u0027s very own roles to reference options like"},{"line_number":375,"context_line":"# **rst_help**...but none of this escapes to the sample configuration"},{"line_number":376,"context_line":"# file. (string value)"},{"line_number":377,"context_line":"#rst_help \u003d \u003cNone\u003e"},{"line_number":378,"context_line":"\u0027\u0027\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_126ae1b1","line":375,"range":{"start_line":375,"start_character":2,"end_line":375,"end_character":14},"updated":"2019-02-28 23:17:53.000000000","message":"So if the source had said :oslo.config:option:`mygroup.rst_help`, it would render as **mygroup.rst_help** ?\n\nI guess that\u0027s okay.\n\nIt\u0027s slightly sad-making that we can\u0027t add DEFAULT. to this kind, but I can live with it.","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5283fb3dae81e800938baa873e529255a17d4ecb","unresolved":false,"context_lines":[{"line_number":372,"context_line":"# This is some rst-ified help text. We reference commands like"},{"line_number":373,"context_line":"# **sphinx**, use \"literals\", make the most of hyperlinks, and even use"},{"line_number":374,"context_line":"# *oslo.config*\u0027s very own roles to reference options like"},{"line_number":375,"context_line":"# **rst_help**...but none of this escapes to the sample configuration"},{"line_number":376,"context_line":"# file. (string value)"},{"line_number":377,"context_line":"#rst_help \u003d \u003cNone\u003e"},{"line_number":378,"context_line":"\u0027\u0027\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7ea55d9e","line":375,"range":{"start_line":375,"start_character":2,"end_line":375,"end_character":14},"in_reply_to":"5fc1f717_b3f9804e","updated":"2019-03-26 23:32:52.000000000","message":"I think it would play better, yeah.","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3370c6f888db32c3c63f75fbd4a27bf5fa303ec","unresolved":false,"context_lines":[{"line_number":372,"context_line":"# This is some rst-ified help text. We reference commands like"},{"line_number":373,"context_line":"# **sphinx**, use \"literals\", make the most of hyperlinks, and even use"},{"line_number":374,"context_line":"# *oslo.config*\u0027s very own roles to reference options like"},{"line_number":375,"context_line":"# **rst_help**...but none of this escapes to the sample configuration"},{"line_number":376,"context_line":"# file. (string value)"},{"line_number":377,"context_line":"#rst_help \u003d \u003cNone\u003e"},{"line_number":378,"context_line":"\u0027\u0027\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b3f9804e","line":375,"range":{"start_line":375,"start_character":2,"end_line":375,"end_character":14},"in_reply_to":"9fdfeff1_126ae1b1","updated":"2019-03-05 19:11:35.000000000","message":"Yup. I could add \u0027DEFAULT.\u0027 to non-grouped options, if you\u0027d like. It\u0027s an easy change.","commit_id":"e1a39f25d49b1581176f2cb04a48a09cc46ee7fd"}],"requirements.txt":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6843b0638eea2eb135ebf043396ed16ed469f1ed","unresolved":false,"context_lines":[{"line_number":9,"context_line":"rfc3986\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":10,"context_line":"PyYAML\u003e\u003d3.12 # MIT"},{"line_number":11,"context_line":"requests\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":12,"context_line":"rst2txt\u003e\u003d1.1.0 # BSD"},{"line_number":13,"context_line":"importlib_metadata\u003e\u003d1.7.0;python_version\u003c\u00273.8\u0027 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"bf51134e_619cc869","line":12,"updated":"2020-07-15 17:11:51.000000000","message":"Can we add this dependency using the \"extras\" feature so it isn\u0027t required for running services that use oslo.config?","commit_id":"1dde5ae0897062025f265928bb3e7702a8aff04d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c522bf93b8c6600df417a9f9fefa95085f5ab1ec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"rfc3986\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":10,"context_line":"PyYAML\u003e\u003d3.12 # MIT"},{"line_number":11,"context_line":"requests\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":12,"context_line":"rst2txt\u003e\u003d1.1.0 # BSD"},{"line_number":13,"context_line":"importlib_metadata\u003e\u003d1.7.0;python_version\u003c\u00273.8\u0027 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"bf51134e_e159f88d","line":12,"in_reply_to":"bf51134e_619cc869","updated":"2020-07-15 17:19:42.000000000","message":"+1","commit_id":"1dde5ae0897062025f265928bb3e7702a8aff04d"}],"setup.cfg":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"cc45d212becae65e054b161dfd1702e794be5a45","unresolved":false,"context_lines":[{"line_number":25,"context_line":"[extras]"},{"line_number":26,"context_line":"# package dependencies for optional (non-rabbitmq) messaging drivers."},{"line_number":27,"context_line":"# e.g.: oslo.config[sphinx]"},{"line_number":28,"context_line":"sphinx \u003d"},{"line_number":29,"context_line":"    rst2txt\u003e\u003d1.1.0 # BSD"},{"line_number":30,"context_line":"    sphinx\u003e\u003d1.8.0,!\u003d2.1.0 # BSD"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"bf51134e_2a29f288","line":28,"updated":"2020-07-16 20:28:38.000000000","message":"It would be better to name this something related to the library, rather than the dependency. Maybe \"generator\" since these are extra dependencies for the generator CLI?","commit_id":"cf8e67fb4375ae9d681e5242544ea31d20cc5dfe"}]}