)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c58fa38762c2840d17eb88e6b8787b0d2eceee0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve removing quotes logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cover case when sting consists of one quote only."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1fed30f6e365e18d3e3ec11d436a432b08c6c344"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_bc4d8b3c","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":21},"updated":"2019-08-12 13:38:10.000000000","message":"nits","commit_id":"daddb91211446cf4b67bd7e11a202f10ad891d21"}],"oslo_config/types.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c58fa38762c2840d17eb88e6b8787b0d2eceee0c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        value \u003d str(value)"},{"line_number":145,"context_line":"        if self.quotes and value:"},{"line_number":146,"context_line":"            if value[0] in \"\\\"\u0027\":"},{"line_number":147,"context_line":"                if value[-1] !\u003d value[0] or len(value) \u003d\u003d 1:"},{"line_number":148,"context_line":"                    raise ValueError(\u0027Non-closed quote: %s\u0027 % value)"},{"line_number":149,"context_line":"                value \u003d value[1:-1]"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1c829f01","line":147,"range":{"start_line":147,"start_character":44,"end_line":147,"end_character":59},"updated":"2019-08-12 13:38:10.000000000","message":"hm... I guess you can to test it first to optimize condition execution and avoid to compare the same index with himself:\n\n```\nvalue[-1] !\u003d value[0]\n```\n\nSo, in other words your code will be more optimized if you pass your test first:\n\n```\nif len(value) \u003d\u003d 1 or value[-1] !\u003d value[0]:\n```","commit_id":"daddb91211446cf4b67bd7e11a202f10ad891d21"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"00af08bdb6d7a42400b79db88eef024f701762f4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        value \u003d str(value)"},{"line_number":145,"context_line":"        if self.quotes and value:"},{"line_number":146,"context_line":"            if value[0] in \"\\\"\u0027\":"},{"line_number":147,"context_line":"                if value[-1] !\u003d value[0] or len(value) \u003d\u003d 1:"},{"line_number":148,"context_line":"                    raise ValueError(\u0027Non-closed quote: %s\u0027 % value)"},{"line_number":149,"context_line":"                value \u003d value[1:-1]"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7f15c59a","line":147,"range":{"start_line":147,"start_character":44,"end_line":147,"end_character":59},"in_reply_to":"7faddb67_1c829f01","updated":"2019-08-12 14:20:24.000000000","message":"right. thank you","commit_id":"daddb91211446cf4b67bd7e11a202f10ad891d21"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"ff3124f5d6e5b55763a8c85257b6af6a409e8d4e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        value \u003d str(value)"},{"line_number":145,"context_line":"        if self.quotes and value:"},{"line_number":146,"context_line":"            if value[0] in \"\\\"\u0027\":"},{"line_number":147,"context_line":"                if value[-1] !\u003d value[0] or len(value) \u003d\u003d 1:"},{"line_number":148,"context_line":"                    raise ValueError(\u0027Non-closed quote: %s\u0027 % value)"},{"line_number":149,"context_line":"                value \u003d value[1:-1]"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_5f2fa9a6","line":147,"range":{"start_line":147,"start_character":44,"end_line":147,"end_character":59},"in_reply_to":"7faddb67_7f15c59a","updated":"2019-08-12 14:28:48.000000000","message":"I addressed you comment and after that thought that on the other hand it\u0027s rather rare occurrence when value[-1] !\u003d value[0] is false and len(value) \u003d\u003d 1 is true. So switching them may make things worse. What do you think?","commit_id":"daddb91211446cf4b67bd7e11a202f10ad891d21"}]}