)]}'
{"id":"openstack%2Foslo.config~699525","triplet_id":"openstack%2Foslo.config~stable%2Fqueens~Id3b28465d645a24f0fcebff2dd68a9bd30e21594","project":"openstack/oslo.config","branch":"stable/queens","topic":"bug/1856312","hashtags":[],"change_id":"Id3b28465d645a24f0fcebff2dd68a9bd30e21594","subject":"Ensure option groups don\u0027t change during logging","status":"ABANDONED","created":"2019-12-18 00:54:29.000000000","updated":"2019-12-18 11:56:43.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8b512b5a9c2b9c16887b52c3419f17efd6160447","_number":699525,"virtual_id_number":699525,"owner":{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-12-18 02:26:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":-1,"date":"2019-12-18 02:16:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"date":"2019-12-18 00:54:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-18 00:54:29.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-12-18 02:16:03.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-12-18 02:26:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f036c8cc4084976141f4eace8fdded9d0dc5fb18","author":{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"},"date":"2019-12-18 00:54:29.000000000","message":"Patch Set 1: Cherry Picked from branch stable/rocky.","accounts_in_message":[],"_revision_number":1},{"id":"d88296fe08f213ca0e36adc2bbff26c755e7c548","author":{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"},"date":"2019-12-18 00:54:44.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit 3870824346e4d9b6876ebab606d1ac2fd46bb059","accounts_in_message":[],"_revision_number":1},{"id":"86c819612c4207c6cadf51f74423e88c500c45f9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-18 02:14:59.000000000","message":"Topic changed from bug/1856312-stable/train-stable/stein-stable/rocky-stable/queens to bug/1856312","accounts_in_message":[],"_revision_number":1},{"id":"0803e5ddfe81ba7e16eb4ce93c0d058de283edd1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-12-18 02:16:03.000000000","message":"Patch Set 1: Code-Review-1\n\nstable/queens is in extended maintenance mode [1] which means it\u0027s not going to be released on this branch anyway so I don\u0027t see a point in doing this.\n\n[1] https://docs.openstack.org/project-team-guide/stable-branches.html#extended-maintenance","accounts_in_message":[],"_revision_number":1},{"id":"b3def14f752973298aa6cbdd26bc2800584ddcaa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 02:26:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dbc71a22ca6f47408836ea0f5ee4b3d9 : SUCCESS in 4m 10s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/461f7d32230546579e9e7167743656aa : SUCCESS in 4m 16s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/d8d6ea2f719f4a5494e5da1c44d8d815 : SUCCESS in 4m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ab0732860fc64d8d81630d11b7b7e83e : SUCCESS in 5m 42s\n- tempest-full https://zuul.opendev.org/t/openstack/build/06efc725ebd4415386812e10283b8797 : SUCCESS in 1h 24m 59s","accounts_in_message":[],"_revision_number":1},{"id":"8b512b5a9c2b9c16887b52c3419f17efd6160447","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-18 11:56:43.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bd2ea18a75ae96d02b30d30e9cf131e5941c10ba","revisions":{"bd2ea18a75ae96d02b30d30e9cf131e5941c10ba":{"kind":"REWORK","_number":1,"created":"2019-12-18 00:54:29.000000000","uploader":{"_account_id":30858,"name":"zhen","email":"zhen00fa@gmail.com","username":"zhen"},"ref":"refs/changes/25/699525/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.config","ref":"refs/changes/25/699525/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.config refs/changes/25/699525/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.config refs/changes/25/699525/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.config refs/changes/25/699525/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.config refs/changes/25/699525/1"}}},"commit":{"parents":[{"commit":"31c11ab4289efa1a91835f3daa928fe927ac4276","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.config/commit/31c11ab4289efa1a91835f3daa928fe927ac4276"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-12-13 16:18:33.000000000","tz":0},"committer":{"name":"zhen","email":"2997214615@qq.com","date":"2019-12-18 00:54:29.000000000","tz":0},"subject":"Ensure option groups don\u0027t change during logging","message":"Ensure option groups don\u0027t change during logging\n\noslo.config allows us to configure groups and options dynamically. This\ncan cause a race with our logging as we attempt to iterate through\noption groups that are changing under our feet. This wouldn\u0027t be a huge\nissue, since these are just logs are we can always log again, if needed,\nbut we store groups in a dictionary and Python doesn\u0027t like us changing\nthe size of a dict it\u0027s iterating through:\n\n  RuntimeError: dictionary changed size during iteration\n\nGiven that we\u0027re only reading through this option group and don\u0027t need\nto worry about a group _disappearing_, the solution is pretty simple:\ncreate a copy of our option group names ahead of time so we don\u0027t need\nto worry about new ones coming and messing things up.\n\nNo tests are included since this is a race and the only way I see to\nreproduce this would involve lots of ugly threading.\n\nChange-Id: Id3b28465d645a24f0fcebff2dd68a9bd30e21594\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1856312\n(cherry picked from commit e3e2ba55eeeb86a9bc0624bb2592e46583e839e7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.config/commit/bd2ea18a75ae96d02b30d30e9cf131e5941c10ba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.config/commit/bd2ea18a75ae96d02b30d30e9cf131e5941c10ba"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}