)]}'
{"tests/test_cfg.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d14d122b8e6bc2a087e74229598060e2ded91283","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        self.assertTrue(\u0027--config-file\u0027 in sys.stdout.getvalue())"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    def test_version(self):"},{"line_number":482,"context_line":"        # In Python 3.4+, argparse prints the version on stdout; before 3.4, it"},{"line_number":483,"context_line":"        # printed it on stderr."},{"line_number":484,"context_line":"        if sys.version \u003e\u003d \u00273.4\u0027:"},{"line_number":485,"context_line":"            file_desc \u003d \u0027sys.stdout\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9Qic%3D","line":482,"updated":"2014-04-07 15:42:29.000000000","message":"it looks like you added a non-ASCII non-breaking space somewhere in this line. Jenkins output:\n\n\nSyntaxError: Non-ASCII character \u0027\\xc2\u0027 in file /home/jenkins/workspace/gate-oslo.config-python26/tests/test_cfg.py on line 482, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details (test_cfg.py, line 482)","commit_id":"863fb890826d5fc759427f8ea0dd4f73a88391e8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"435ada27288138cdcaa776a4bc1a0b8616235ff2","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    def test_version(self):"},{"line_number":482,"context_line":"        # In Python 3.4+, argparse prints the version on stdout; before 3.4, it"},{"line_number":483,"context_line":"        # printed it on stderr."},{"line_number":484,"context_line":"        if sys.version \u003e\u003d \u00273.4\u0027:"},{"line_number":485,"context_line":"            file_desc \u003d \u0027sys.stdout\u0027"},{"line_number":486,"context_line":"        else:"},{"line_number":487,"context_line":"            file_desc \u003d \u0027sys.stderr\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9QkI%3D","line":484,"updated":"2014-04-07 15:40:26.000000000","message":"It\u0027s more reliable to compare sys.version_info:\n\nsys.version_info \u003e\u003d (3, 4)","commit_id":"863fb890826d5fc759427f8ea0dd4f73a88391e8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"14ea141b47f9bf35103dcafe92fc9caebf1b6318","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            file_desc \u003d \u0027sys.stderr\u0027"},{"line_number":488,"context_line":"        self.useFixture(fixtures.MonkeyPatch(file_desc, moves.StringIO()))"},{"line_number":489,"context_line":"        self.assertRaises(SystemExit, self.conf, [\u0027--version\u0027])"},{"line_number":490,"context_line":"        self.assertTrue(\u00271.0\u0027 in eval(file_desc).getvalue())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def test_config_file(self):"},{"line_number":493,"context_line":"        paths \u003d self.create_tempfiles([(\u00271\u0027, \u0027[DEFAULT]\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9OAo%3D","line":490,"updated":"2014-04-07 21:18:06.000000000","message":"Why not using getattr(sys, stream_name) here?\n\nWhere stream_name would be \"stdout\" or \"stderr\".\n\n(I don\u0027t like eval().)","commit_id":"9f73450d382f19011907f4a07b89a0ac1920dccf"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"80ceeffdb6f77eb4706063de1d0269c00e6bf1ac","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            file_desc \u003d \u0027sys.stderr\u0027"},{"line_number":488,"context_line":"        self.useFixture(fixtures.MonkeyPatch(file_desc, moves.StringIO()))"},{"line_number":489,"context_line":"        self.assertRaises(SystemExit, self.conf, [\u0027--version\u0027])"},{"line_number":490,"context_line":"        self.assertTrue(\u00271.0\u0027 in eval(file_desc).getvalue())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def test_config_file(self):"},{"line_number":493,"context_line":"        paths \u003d self.create_tempfiles([(\u00271\u0027, \u0027[DEFAULT]\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWn%2F%2F96I%3D","line":490,"in_reply_to":"AAAAWH%2F9NxY%3D","updated":"2014-04-08 07:35:29.000000000","message":"I propose the following change to avoid eval():\n\nif sys.version_info \u003e\u003d (3, 4):\n  stream_name \u003d\u0027stdout\u0027\nelse:\n  stream_name \u003d\u0027stderr\u0027\n self.useFixture(fixtures.MonkeyPatch(\"sys.%s\" % stream_name, moves.StringIO()))\nself.assertRaises(SystemExit, self.conf, [\u0027--version\u0027])\nself.assertTrue(\u00271.0\u0027 in getattr(sys, stream_name).getvalue())","commit_id":"9f73450d382f19011907f4a07b89a0ac1920dccf"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"55341353c0c8ff590d54e5053fd6d81e37a0ed72","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            file_desc \u003d \u0027sys.stderr\u0027"},{"line_number":488,"context_line":"        self.useFixture(fixtures.MonkeyPatch(file_desc, moves.StringIO()))"},{"line_number":489,"context_line":"        self.assertRaises(SystemExit, self.conf, [\u0027--version\u0027])"},{"line_number":490,"context_line":"        self.assertTrue(\u00271.0\u0027 in eval(file_desc).getvalue())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def test_config_file(self):"},{"line_number":493,"context_line":"        paths \u003d self.create_tempfiles([(\u00271\u0027, \u0027[DEFAULT]\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9NxY%3D","line":490,"in_reply_to":"AAAAWH%2F9OAo%3D","updated":"2014-04-07 21:41:28.000000000","message":"What\u0027s \u0027stream_name\u0027 ? Could you point me to the relevant doc ?","commit_id":"9f73450d382f19011907f4a07b89a0ac1920dccf"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"c39ae695d4fa627e9b021842a2b119486fe512ad","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            file_desc \u003d \u0027sys.stderr\u0027"},{"line_number":488,"context_line":"        self.useFixture(fixtures.MonkeyPatch(file_desc, moves.StringIO()))"},{"line_number":489,"context_line":"        self.assertRaises(SystemExit, self.conf, [\u0027--version\u0027])"},{"line_number":490,"context_line":"        self.assertTrue(\u00271.0\u0027 in eval(file_desc).getvalue())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def test_config_file(self):"},{"line_number":493,"context_line":"        paths \u003d self.create_tempfiles([(\u00271\u0027, \u0027[DEFAULT]\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2F6V8%3D","line":490,"in_reply_to":"AAAAWn%2F%2F96I%3D","updated":"2014-04-16 14:52:56.000000000","message":"agreed","commit_id":"9f73450d382f19011907f4a07b89a0ac1920dccf"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"45985173a149a6393f75699e02778eeb2039d12b","unresolved":false,"context_lines":[{"line_number":485,"context_line":"            stream_name \u003d \u0027stdout\u0027"},{"line_number":486,"context_line":"        else:"},{"line_number":487,"context_line":"            stream_name \u003d \u0027stderr\u0027"},{"line_number":488,"context_line":"        self.useFixture(fixtures.MonkeyPatch(\"sys.%s\" % stream_name, moves.StringIO()))"},{"line_number":489,"context_line":"        self.assertRaises(SystemExit, self.conf, [\u0027--version\u0027])"},{"line_number":490,"context_line":"        self.assertTrue(\u00271.0\u0027 in getattr(sys, stream_name).getvalue())"},{"line_number":491,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FyOg%3D","line":488,"updated":"2014-04-17 13:37:47.000000000","message":"2014-04-17 11:43:07.453 | ./tests/test_cfg.py:488:80: E501 line too long (87 \u003e 79 characters)\n2014-04-17 11:43:07.453 |         self.useFixture(fixtures.MonkeyPatch(\"sys.%s\" % stream_name, moves.StringIO()))","commit_id":"f6e7866d0882b1e8d7a378ffc6d272b9d61a7469"}]}