)]}'
{"oslo_config/sources/_uri.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"78d1668490668d8e6e065f75946a266c35fae223","unresolved":true,"context_lines":[{"line_number":157,"context_line":"            client_cert"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        with requests.get(uri, verify\u003dverify, cert\u003dcert,"},{"line_number":160,"context_line":"                          timeout\u003d5) as response:"},{"line_number":161,"context_line":"            response.raise_for_status()  # raises only in case of HTTPError"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            return response.text"}],"source_content_type":"text/x-python","patch_set":2,"id":"464f019e_b267ae9f","line":160,"range":{"start_line":160,"start_character":26,"end_line":160,"end_character":35},"updated":"2023-05-17 09:19:56.000000000","message":"I wonder if we should allow to pass the timeout value as the other params. I\u0027ll update the patch to allow that with 5 as the default value.","commit_id":"643f42f32c00dc3115c34c164f0c84a189953d05"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9ed100d7514bf4401b0f64dfd005b9d38d9d9cc6","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            cfg.ConfigParser._parse_file(tmpfile.name, self._namespace)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _fetch_uri(self, uri, ca_path, client_cert, client_key, timeout\u003d5):"},{"line_number":155,"context_line":"        verify \u003d ca_path if ca_path else True"},{"line_number":156,"context_line":"        cert \u003d (client_cert, client_key) if client_cert and client_key else \\"},{"line_number":157,"context_line":"            client_cert"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b4aa6cf_0956dad0","line":154,"range":{"start_line":154,"start_character":64,"end_line":154,"end_character":73},"updated":"2023-04-10 02:11:25.000000000","message":"I agree we can add timeout but we should make this configurable.\n\nAlso, I think 5 seconds is a bit tight and a larger value such as 30 seconds(or even 60 seconds) would work better with slow networks.","commit_id":"39d91cb6ee410528efcfd0757d5ca61e8dc6f123"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"78d1668490668d8e6e065f75946a266c35fae223","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"            cfg.ConfigParser._parse_file(tmpfile.name, self._namespace)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _fetch_uri(self, uri, ca_path, client_cert, client_key, timeout\u003d5):"},{"line_number":155,"context_line":"        verify \u003d ca_path if ca_path else True"},{"line_number":156,"context_line":"        cert \u003d (client_cert, client_key) if client_cert and client_key else \\"},{"line_number":157,"context_line":"            client_cert"}],"source_content_type":"text/x-python","patch_set":3,"id":"ef42eb65_7dfdc9a2","line":154,"range":{"start_line":154,"start_character":64,"end_line":154,"end_character":73},"in_reply_to":"6b4aa6cf_0956dad0","updated":"2023-05-17 09:19:56.000000000","message":"done","commit_id":"39d91cb6ee410528efcfd0757d5ca61e8dc6f123"}]}
