)]}'
{"oslo/config/types.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0066246e8f6665fb0fe7e88d12cf34f079db2eaa","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        )"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"class IPAddress(object):"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    \"\"\"IP address type"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_45cc4b35","line":340,"updated":"2014-06-14 19:33:00.000000000","message":"Do we need 3 different type classes, or could we have one type that takes an optional version parameter to tell it whether to enforce v4, v6, or either?","commit_id":"9ff7296db8e70514efe3e9976a22374fda0342ff"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7694ceba34dd08b8f530014ee7988a2cadd25269","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        )"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"class IPAddress(object):"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    \"\"\"IP address type"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_cc5240dd","line":340,"in_reply_to":"1ae5cdf2_45cc4b35","updated":"2014-06-15 09:49:07.000000000","message":"I think the type should be given by class, not parameter e.g. you have type for float and int instead of having Number class consuming parameter.","commit_id":"9ff7296db8e70514efe3e9976a22374fda0342ff"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5d2da1822d38f050fd227d1d072cea3b1019733a","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"class IPAddress(object):"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    \"\"\"IP address type"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    IP address can be either v4 or v6. Input is returned as string."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_445eff7a","line":341,"updated":"2014-06-16 06:29:27.000000000","message":"I think I\u0027m with Doug on this. A better analogy would be the min/max parameters on IntOpt. I like the idea of\n\n  cfg.IPOpt(...)\n  cfg.IPOpt(..., version\u003d4)\n  cfg.IPOpt(..., version\u003d6)\n\nfor both, ipv4 and ipv6 respectively\n\nOr, if you don\u0027t like that:\n\n  cfg.IPOpt()\n  cfg.IPOpt(..., ipv6\u003dFalse)\n  cfg.IPOpt(..., ipv4\u003dFalse)\n\nWe want to avoid having a massive proliferation of classes as we add more validation","commit_id":"9ff7296db8e70514efe3e9976a22374fda0342ff"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"976fb9bc7ff9f6610232fa678f4331875743681e","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"class IPAddress(object):"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    \"\"\"IP address type"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    IP address can be either v4 or v6. Input is returned as string."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d3ad6f34","line":341,"in_reply_to":"1ae5cdf2_445eff7a","updated":"2014-06-16 08:57:57.000000000","message":"Done","commit_id":"9ff7296db8e70514efe3e9976a22374fda0342ff"}],"tests/test_cfg.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5d2da1822d38f050fd227d1d072cea3b1019733a","unresolved":false,"context_lines":[{"line_number":365,"context_line":"         dict(opt_class\u003dcfg.FloatOpt, default\u003dNone,"},{"line_number":366,"context_line":"              cli_args\u003d[\u0027--old-oof\u0027, \u00272.0\u0027], value\u003d2.0, deps\u003d(\u0027oof\u0027, \u0027old\u0027))),"},{"line_number":367,"context_line":"        (\u0027ipv4addr_arg\u0027,"},{"line_number":368,"context_line":"         dict(opt_class\u003dcfg.IPv4Opt, default\u003dNone,"},{"line_number":369,"context_line":"              cli_args\u003d[\u0027--foo\u0027, \u0027192.168.0.1\u0027], value\u003d\u0027192.168.0.1\u0027,"},{"line_number":370,"context_line":"              deps\u003d(None, None))),"},{"line_number":371,"context_line":"        (\u0027ipaddr_arg_implicitv4\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_2472d311","line":368,"updated":"2014-06-16 06:29:27.000000000","message":"for convenience while testing, you could do\n\n  class CLIOptsTestCase(BaseTestCase):\n\n      IPv4Opt \u003d functools.partial(cfg.IPOpt, ipv6\u003dFalse)","commit_id":"9ff7296db8e70514efe3e9976a22374fda0342ff"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"976fb9bc7ff9f6610232fa678f4331875743681e","unresolved":false,"context_lines":[{"line_number":365,"context_line":"         dict(opt_class\u003dcfg.FloatOpt, default\u003dNone,"},{"line_number":366,"context_line":"              cli_args\u003d[\u0027--old-oof\u0027, \u00272.0\u0027], value\u003d2.0, deps\u003d(\u0027oof\u0027, \u0027old\u0027))),"},{"line_number":367,"context_line":"        (\u0027ipv4addr_arg\u0027,"},{"line_number":368,"context_line":"         dict(opt_class\u003dcfg.IPv4Opt, default\u003dNone,"},{"line_number":369,"context_line":"              cli_args\u003d[\u0027--foo\u0027, \u0027192.168.0.1\u0027], value\u003d\u0027192.168.0.1\u0027,"},{"line_number":370,"context_line":"              deps\u003d(None, None))),"},{"line_number":371,"context_line":"        (\u0027ipaddr_arg_implicitv4\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b3b9c37b","line":368,"in_reply_to":"1ae5cdf2_2472d311","updated":"2014-06-16 08:57:57.000000000","message":"Thanks :)","commit_id":"9ff7296db8e70514efe3e9976a22374fda0342ff"}]}
