)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6c013cd01562c14d84c89e26652524f09673777c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Berendt \u003cberendt@b1-systems.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-20 16:43:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"replace string format arguments with function parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are files containing string format arguments inside"},{"line_number":10,"context_line":"logging messages. Using logging function parameters should"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_a937a4e1","line":7,"updated":"2014-05-20 14:54:59.000000000","message":"You should mention that the change concerns the logs.","commit_id":"ca1cb06634e3f1ee5c1c602e6a2a29ad84d0a462"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6c013cd01562c14d84c89e26652524f09673777c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are files containing string format arguments inside"},{"line_number":10,"context_line":"logging messages. Using logging function parameters should"},{"line_number":11,"context_line":"be preferred."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I22aebd928a96258c08fcaa363aed0f739825fc7e"},{"line_number":14,"context_line":"Partial-Bug: #1321274"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_29539417","line":11,"updated":"2014-05-20 14:54:59.000000000","message":"By the way, your syntax is also safer because exceptions while formatting are catched and handled.","commit_id":"ca1cb06634e3f1ee5c1c602e6a2a29ad84d0a462"}],"oslo/config/cfg.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6c013cd01562c14d84c89e26652524f09673777c","unresolved":false,"context_lines":[{"line_number":2234,"context_line":""},{"line_number":2235,"context_line":"        except SystemExit as exc:"},{"line_number":2236,"context_line":"            LOG.warn(\"Caught SystemExit while reloading configure files \""},{"line_number":2237,"context_line":"                     \" with exit code: %d\", exc.code)"},{"line_number":2238,"context_line":"            return False"},{"line_number":2239,"context_line":"        except Error as err:"},{"line_number":2240,"context_line":"            LOG.warn(\"Caught Error while reloading configure files: %s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_ce4cf6ca","line":2237,"updated":"2014-05-20 14:54:59.000000000","message":"There are two spaces between \"files\" and \"with\" in the message.","commit_id":"ca1cb06634e3f1ee5c1c602e6a2a29ad84d0a462"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6c013cd01562c14d84c89e26652524f09673777c","unresolved":false,"context_lines":[{"line_number":2238,"context_line":"            return False"},{"line_number":2239,"context_line":"        except Error as err:"},{"line_number":2240,"context_line":"            LOG.warn(\"Caught Error while reloading configure files: %s\","},{"line_number":2241,"context_line":"                     err.__str__())"},{"line_number":2242,"context_line":"            return False"},{"line_number":2243,"context_line":"        else:"},{"line_number":2244,"context_line":"            self._namespace \u003d namespace"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_09297889","line":2241,"updated":"2014-05-20 14:54:59.000000000","message":"I\u0027m not sure that the explicit call to err.__str__() is needed. str(obj) calls obj.__str__(). I would avoid the formatting if the message is not logged.","commit_id":"ca1cb06634e3f1ee5c1c602e6a2a29ad84d0a462"}]}
