)]}'
{"oslo_context/context.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4ab6dd7b13c885c07484278525dc3ddc6b1b5fae","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        values \u003d self.to_dict()"},{"line_number":106,"context_line":"        # Define these attributes so that oslo.log does not throw an exception"},{"line_number":107,"context_line":"        # if use in any formatting strings"},{"line_number":108,"context_line":"        values.update({\u0027instance\u0027: \u0027\u0027,"},{"line_number":109,"context_line":"                       \u0027resource\u0027: \u0027\u0027,"},{"line_number":110,"context_line":"                       \u0027user_name\u0027: \u0027\u0027,"},{"line_number":111,"context_line":"                       \u0027project_name\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_64db2ded","line":108,"updated":"2016-01-29 20:37:19.000000000","message":"I\u0027m not sure we want to just run update() with all of these attributes. If instance is already set, for example, we\u0027ll remove it.\n\nSwitching the order would work.\n\n  values \u003d { ... literal with defaults ... }\n  values.update(self.to_dict())","commit_id":"7656b36039d9347a922a33deb72b11cf4bbd1c2b"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"6d4c03849ca951d49499317efb41794719f6ce41","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        values \u003d self.to_dict()"},{"line_number":106,"context_line":"        # Define these attributes so that oslo.log does not throw an exception"},{"line_number":107,"context_line":"        # if use in any formatting strings"},{"line_number":108,"context_line":"        values.update({\u0027instance\u0027: \u0027\u0027,"},{"line_number":109,"context_line":"                       \u0027resource\u0027: \u0027\u0027,"},{"line_number":110,"context_line":"                       \u0027user_name\u0027: \u0027\u0027,"},{"line_number":111,"context_line":"                       \u0027project_name\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_7fcf3a29","line":108,"in_reply_to":"7a5de9d1_64db2ded","updated":"2016-01-29 21:02:45.000000000","message":"good point about it being removed if set.\nIn this case none of these attributes existed from the oslo.log code (user_identity was removed specifically because it did exist).\n\nHowever I need to consider the correct approach for adding values while sub classing.","commit_id":"7656b36039d9347a922a33deb72b11cf4bbd1c2b"}],"oslo_context/tests/test_context.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4ab6dd7b13c885c07484278525dc3ddc6b1b5fae","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        self.assertEqual(\"\", d[\u0027resource\u0027])"},{"line_number":285,"context_line":"        self.assertEqual(\"\", d[\u0027user_name\u0027])"},{"line_number":286,"context_line":"        self.assertEqual(\"\", d[\u0027project_name\u0027])"},{"line_number":287,"context_line":"        self.assertEqual(\"\", d[\u0027color\u0027])"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def test_dict_empty_user_identity(self):"},{"line_number":290,"context_line":"        ctx \u003d context.RequestContext()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_84e669ae","line":287,"updated":"2016-01-29 20:37:19.000000000","message":"We should add some tests with a context that have those attributes set, so we can verify that the set values make it through into the dict properly.","commit_id":"7656b36039d9347a922a33deb72b11cf4bbd1c2b"}]}