)]}'
{"oslo_context/context.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"33bebf4777a99f302a563a079d5d44f9533c98a6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\"Construct a context object from a provided dictionary.\"\"\""},{"line_number":119,"context_line":"        allowed \u003d [arg for arg in"},{"line_number":120,"context_line":"                   inspect.getargspec(RequestContext.__init__).args"},{"line_number":121,"context_line":"                   if arg !\u003d \u0027self\u0027]"},{"line_number":122,"context_line":"        kwargs \u003d dict((k, v) for (k, v) in values.items() if k in allowed)"},{"line_number":123,"context_line":"        return cls(**kwargs)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_bddbf31a","line":121,"updated":"2016-02-03 14:49:30.000000000","message":"I see __init__ has an overwrite argument that wasn\u0027t previously accepted here, is that OK?","commit_id":"b5bf2fcb0720fc403778be42f5e323afca87cac8"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"3d9c0d8b2397d66d12ef8ef21c7650744bdeb7fd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\"Construct a context object from a provided dictionary.\"\"\""},{"line_number":119,"context_line":"        allowed \u003d [arg for arg in"},{"line_number":120,"context_line":"                   inspect.getargspec(RequestContext.__init__).args"},{"line_number":121,"context_line":"                   if arg !\u003d \u0027self\u0027]"},{"line_number":122,"context_line":"        kwargs \u003d dict((k, v) for (k, v) in values.items() if k in allowed)"},{"line_number":123,"context_line":"        return cls(**kwargs)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_a003ba72","line":121,"in_reply_to":"5a5ae5dd_bddbf31a","updated":"2016-02-03 19:14:45.000000000","message":"valid point however I do not see any reason why we should not enable a class creation to include all arguments, and specifically not store context in thread cache if overwrite\u003dFalse was specified.  \noverwrite defaults to True, so the default behavior now of not being included is the same.","commit_id":"b5bf2fcb0720fc403778be42f5e323afca87cac8"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"33bebf4777a99f302a563a079d5d44f9533c98a6","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        allowed \u003d [arg for arg in"},{"line_number":120,"context_line":"                   inspect.getargspec(RequestContext.__init__).args"},{"line_number":121,"context_line":"                   if arg !\u003d \u0027self\u0027]"},{"line_number":122,"context_line":"        kwargs \u003d dict((k, v) for (k, v) in values.items() if k in allowed)"},{"line_number":123,"context_line":"        return cls(**kwargs)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_1df6c78f","line":122,"updated":"2016-02-03 14:49:30.000000000","message":"Use a dict comprehension:\n\n  {k: v for (k, v) in values.items() if k in allowed}\n\nnot a huge gain but the right thing to do.\n\nAlso inline to L123, splitting over two lines doesn\u0027t seem to gain us anything.","commit_id":"b5bf2fcb0720fc403778be42f5e323afca87cac8"}]}