)]}'
{"oslo_context/context.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"25a359df565d23287bad610ad2ff31cb844b7384","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                          values.get(\u0027project_domain_name\u0027))"},{"line_number":420,"context_line":"        kwargs.setdefault(\u0027is_admin_project\u0027,"},{"line_number":421,"context_line":"                          values.get(\u0027is_admin_project\u0027, True))"},{"line_number":422,"context_line":"        kwargs.setdefault(\u0027system_scope\u0027, values.get(\u0027system_scope\u0027, None))"},{"line_number":423,"context_line":"        for key in cls.FROM_DICT_EXTRA_KEYS:"},{"line_number":424,"context_line":"            kwargs.setdefault(key, values.get(key))"},{"line_number":425,"context_line":"        return cls(**kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c12de477_60156fa5","line":422,"range":{"start_line":422,"start_character":69,"end_line":422,"end_character":73},"updated":"2021-07-15 12:10:08.000000000","message":"Will be `None` even without passing it [1], however, explicit is better than implicit, so LGTM.\n\nhttps://docs.python.org/3/library/stdtypes.html?highlight\u003ddict%20get#dict.get","commit_id":"4edcb6261fea89d3e9581f01547616041f580db7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"33ce0b6d2fa44974c8e704f084f7efd1e2e5420e","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                          values.get(\u0027project_domain_name\u0027))"},{"line_number":420,"context_line":"        kwargs.setdefault(\u0027is_admin_project\u0027,"},{"line_number":421,"context_line":"                          values.get(\u0027is_admin_project\u0027, True))"},{"line_number":422,"context_line":"        kwargs.setdefault(\u0027system_scope\u0027, values.get(\u0027system_scope\u0027, None))"},{"line_number":423,"context_line":"        for key in cls.FROM_DICT_EXTRA_KEYS:"},{"line_number":424,"context_line":"            kwargs.setdefault(key, values.get(key))"},{"line_number":425,"context_line":"        return cls(**kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"31b97037_52699661","line":422,"range":{"start_line":422,"start_character":69,"end_line":422,"end_character":73},"in_reply_to":"c12de477_60156fa5","updated":"2021-07-15 22:01:05.000000000","message":"Ha, yeah, that was a slip of the mind after hours of tracking down these issues across repos.","commit_id":"4edcb6261fea89d3e9581f01547616041f580db7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7d50d97be60780768c4659ba102632317a6cc815","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                          values.get(\u0027project_domain_name\u0027))"},{"line_number":420,"context_line":"        kwargs.setdefault(\u0027is_admin_project\u0027,"},{"line_number":421,"context_line":"                          values.get(\u0027is_admin_project\u0027, True))"},{"line_number":422,"context_line":"        kwargs.setdefault(\u0027system_scope\u0027, values.get(\u0027system_scope\u0027))"},{"line_number":423,"context_line":"        for key in cls.FROM_DICT_EXTRA_KEYS:"},{"line_number":424,"context_line":"            kwargs.setdefault(key, values.get(key))"},{"line_number":425,"context_line":"        return cls(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"afdf119e_6cd4a651","line":422,"updated":"2021-08-05 21:19:40.000000000","message":"Looks like we can add this to an existing test:\n\nhttps://github.com/openstack/oslo.context/blob/master/oslo_context/tests/test_context.py#L127","commit_id":"27cc7cc7a54593a29745857b98ebbb9bffe99bdd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47c93bc685c0c67eecc51a264278bd17752cfd3c","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                          values.get(\u0027project_domain_name\u0027))"},{"line_number":420,"context_line":"        kwargs.setdefault(\u0027is_admin_project\u0027,"},{"line_number":421,"context_line":"                          values.get(\u0027is_admin_project\u0027, True))"},{"line_number":422,"context_line":"        kwargs.setdefault(\u0027system_scope\u0027, values.get(\u0027system_scope\u0027))"},{"line_number":423,"context_line":"        for key in cls.FROM_DICT_EXTRA_KEYS:"},{"line_number":424,"context_line":"            kwargs.setdefault(key, values.get(key))"},{"line_number":425,"context_line":"        return cls(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"51215a9e_50f712ff","line":422,"in_reply_to":"09311955_f767bc8b","updated":"2021-08-18 20:51:13.000000000","message":"Nope - sorry if I implied that. Just wanted to point out a seem where we could increase coverage.\n\nThanks!","commit_id":"27cc7cc7a54593a29745857b98ebbb9bffe99bdd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5fa99a1b12775604a512d448933ca3c6b72bd913","unresolved":true,"context_lines":[{"line_number":419,"context_line":"                          values.get(\u0027project_domain_name\u0027))"},{"line_number":420,"context_line":"        kwargs.setdefault(\u0027is_admin_project\u0027,"},{"line_number":421,"context_line":"                          values.get(\u0027is_admin_project\u0027, True))"},{"line_number":422,"context_line":"        kwargs.setdefault(\u0027system_scope\u0027, values.get(\u0027system_scope\u0027))"},{"line_number":423,"context_line":"        for key in cls.FROM_DICT_EXTRA_KEYS:"},{"line_number":424,"context_line":"            kwargs.setdefault(key, values.get(key))"},{"line_number":425,"context_line":"        return cls(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"09311955_f767bc8b","line":422,"in_reply_to":"afdf119e_6cd4a651","updated":"2021-08-12 20:12:16.000000000","message":"I will take that comment that I have not done something dumb and will add the test coverage.","commit_id":"27cc7cc7a54593a29745857b98ebbb9bffe99bdd"}]}