)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9def20f0f6f243da403ba34de0603077d1ac528d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. The database name is a random string, so shouldn\u0027t already exist."},{"line_number":10,"context_line":"2. If it *does* already exist, we quite likely want to throw an error"},{"line_number":11,"context_line":"   rather than just delete it."},{"line_number":12,"context_line":"3. \"drop database if exists non_existant_database\" throws an error with"},{"line_number":13,"context_line":"   mysqlconnector and a noisy-but-harmless warning with others."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(We could fix (3), if it was important)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_a81ce7c2","line":12,"range":{"start_line":12,"start_character":58,"end_line":12,"end_character":66},"updated":"2014-07-09 07:15:42.000000000","message":"can you provide an example of error?","commit_id":"2004f783e11bb5d9e9806c594348023ca1b2b34c"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c4f95170268b09c3390fba99924a19076b8257d7","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(We could fix (3), if it was important)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"An example from the error from (3):"},{"line_number":18,"context_line":"running\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision create 8"},{"line_number":19,"context_line":"Traceback (most recent call last):"},{"line_number":20,"context_line":"  File \"/usr/lib/python2.7/runpy.py\", line 162, in _run_module_as_main"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_acde06d8","line":17,"updated":"2014-07-14 20:22:56.000000000","message":"I like the detail but maybe instead of the commit message it could go in a bug report that is linked from the commit message?","commit_id":"c3ddffa920a5929df8ce5ec0041c3246d817aea5"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"e9d2adbcc66137a844dc268f5d595175623775c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(We could fix (3), if it was important)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"An example from the error from (3):"},{"line_number":18,"context_line":"running\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision create 8"},{"line_number":19,"context_line":"Traceback (most recent call last):"},{"line_number":20,"context_line":"  File \"/usr/lib/python2.7/runpy.py\", line 162, in _run_module_as_main"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_921790a2","line":17,"in_reply_to":"baada198_acde06d8","updated":"2014-07-15 01:43:38.000000000","message":"Done.","commit_id":"c3ddffa920a5929df8ce5ec0041c3246d817aea5"}],"oslo/db/sqlalchemy/provision.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9def20f0f6f243da403ba34de0603077d1ac528d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        except OSError:"},{"line_number":90,"context_line":"            pass"},{"line_number":91,"context_line":"    elif driver in [\u0027mysql\u0027, \u0027postgresql\u0027]:"},{"line_number":92,"context_line":"        sql \u003d \u0027drop database if exists %s;\u0027 % engine.url.database"},{"line_number":93,"context_line":"        _execute_sql(admin_engine, [sql], driver)"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        raise ValueError(\u0027Unsupported RDBMS %s\u0027 % driver)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_48f7cb8c","line":92,"updated":"2014-07-09 07:15:42.000000000","message":"doesn\u0027t this instance have the same problem?","commit_id":"2004f783e11bb5d9e9806c594348023ca1b2b34c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"1f4992eb3bdf83e1373cf7122301aadc3108ddc1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        except OSError:"},{"line_number":90,"context_line":"            pass"},{"line_number":91,"context_line":"    elif driver in [\u0027mysql\u0027, \u0027postgresql\u0027]:"},{"line_number":92,"context_line":"        sql \u003d \u0027drop database if exists %s;\u0027 % engine.url.database"},{"line_number":93,"context_line":"        _execute_sql(admin_engine, [sql], driver)"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        raise ValueError(\u0027Unsupported RDBMS %s\u0027 % driver)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_6a7b80be","line":92,"updated":"2014-07-17 05:19:55.000000000","message":"(optional) nit: I\u0027d go for dropping \u0027if exists\u0027 here too just for the sake of consistency","commit_id":"44f504740349c3b4740d51621d4d48463fbe9827"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"03ad05bdc2d6c9b042e5884b278c83344ce6ea4a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        except OSError:"},{"line_number":90,"context_line":"            pass"},{"line_number":91,"context_line":"    elif driver in [\u0027mysql\u0027, \u0027postgresql\u0027]:"},{"line_number":92,"context_line":"        sql \u003d \u0027drop database if exists %s;\u0027 % engine.url.database"},{"line_number":93,"context_line":"        _execute_sql(admin_engine, [sql], driver)"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        raise ValueError(\u0027Unsupported RDBMS %s\u0027 % driver)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_1da2214b","line":92,"in_reply_to":"baada198_6a7b80be","updated":"2014-07-18 03:58:31.000000000","message":"Done","commit_id":"44f504740349c3b4740d51621d4d48463fbe9827"}]}