)]}'
{"oslo/db/sqlalchemy/compat/handle_error.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d9680f9ee5b4ce81e03d9975cfe4732b3bac77ae","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"                        if not ctx.is_disconnect:"},{"line_number":112,"context_line":"                            raise NotImplementedError("},{"line_number":113,"context_line":"                                \"Can\u0027t un-disconnect an exception \""},{"line_number":114,"context_line":"                                \"with this version of SQLAlchemy\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"                        sqlalchemy_exception.connection_invalidated \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d85b2952","line":113,"updated":"2014-07-12 01:34:14.000000000","message":"Can this be better worded?\n\nCan\u0027t un-disconnect? So that means \u0027Can disconnect\u0027 if I take out the negations. :-/","commit_id":"bfac8fa888c9af93b547946037aee94e6858e4d0"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"0107fe5900d6dbfce7432af69698812247670ffd","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"                        if not ctx.is_disconnect:"},{"line_number":112,"context_line":"                            raise NotImplementedError("},{"line_number":113,"context_line":"                                \"Can\u0027t un-disconnect an exception \""},{"line_number":114,"context_line":"                                \"with this version of SQLAlchemy\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"                        sqlalchemy_exception.connection_invalidated \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_93a7d20a","line":113,"in_reply_to":"baada198_d85b2952","updated":"2014-07-12 02:11:59.000000000","message":"I can change the wording, but NotImplementedError(\"Can disconnect this exception\") doesn\u0027t make much sense either, does it?  \n\nWe\u0027re not talking about a disconnecting a connection here.  We\u0027re talking about an exception message that indicates, \"hey the database disconnected, we need to dump the pool\", and changing it to say, \"hey no, this isn\u0027t a disconnect, don\u0027t dump the pool\".  But when the condition here (a second exception) is raised, we\u0027re sayingit\u0027s too late, pool is already dumped.\n\nNotImplementedError(\"Can\u0027t reset \u0027disconnect\u0027 status of exception once it is set with this version of SQLAlchemy\")\n\ni\u0027ll push that.","commit_id":"bfac8fa888c9af93b547946037aee94e6858e4d0"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e9530647441519b921923000e44336e9caefd9d7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            def _do_disconnect(self, e):"},{"line_number":129,"context_line":"                del self._is_disconnect"},{"line_number":130,"context_line":"                if utils.sqla_094:"},{"line_number":131,"context_line":"                    dbapi_conn_wrapper \u003d self.connection"},{"line_number":132,"context_line":"                    self.engine.pool._invalidate(dbapi_conn_wrapper, e)"},{"line_number":133,"context_line":"                    self.invalidate(e)"},{"line_number":134,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_e6305509","line":131,"updated":"2014-07-25 07:56:55.000000000","message":"seems to be, that `dbapi_conn_wrapper` can be moved before the `if .. else` statement","commit_id":"cbae81e6a5bdbe2073b7255a8bb4095bdaa8de32"}],"tests/sqlalchemy/test_handle_error.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e9530647441519b921923000e44336e9caefd9d7","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                conn_rec \u003d c.connection._connection_record"},{"line_number":164,"context_line":"                try:"},{"line_number":165,"context_line":"                    c.execute(\"SELECT x FROM nonexistent\")"},{"line_number":166,"context_line":"                    assert False"},{"line_number":167,"context_line":"                except sqla.exc.StatementError as st:"},{"line_number":168,"context_line":"                    self.assertFalse(expect_failure)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_463ca1e1","line":166,"updated":"2014-07-25 07:56:55.000000000","message":"nit: \n\n self.fail()","commit_id":"cbae81e6a5bdbe2073b7255a8bb4095bdaa8de32"}]}