)]}'
{".testr.conf":[{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"9579813106180bda6cbceeac4cfc2664964bddee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"test_list_option\u003d--list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instance_provision\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision echo $INSTANCE_COUNT"},{"line_number":10,"context_line":"instance_dispose\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision drop --conditional $INSTANCE_IDS"},{"line_number":11,"context_line":"instance_execute\u003dOSLO_SCHEMA_TOKEN\u003d$INSTANCE_ID $COMMAND"}],"source_content_type":"text/plain","patch_set":4,"id":"baada198_8d7ffc16","line":10,"updated":"2014-07-31 00:34:34.000000000","message":"I\u0027m slow :/  What\u0027s the importance of --conditional here?\n\nI see from the rest of the change that --conditional only drops if the database exists - but how would we get to this point with a non-existent database?","commit_id":"5bc89e352c5170f2fd9e7dcf8f7afd637e50fb1a"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"d589b2bac81446a31e350983da78349ba4262de4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"test_list_option\u003d--list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instance_provision\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision echo $INSTANCE_COUNT"},{"line_number":10,"context_line":"instance_dispose\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision drop --conditional $INSTANCE_IDS"},{"line_number":11,"context_line":"instance_execute\u003dOSLO_SCHEMA_TOKEN\u003d$INSTANCE_ID $COMMAND"}],"source_content_type":"text/plain","patch_set":4,"id":"baada198_5f5bc385","line":10,"in_reply_to":"baada198_83326b5c","updated":"2014-07-31 05:23:48.000000000","message":"Oh I see!  (Also read the testr instance_provision docs again ;)\n\nYep, while we have so few opportunistic tests I can see how we gain from laziness.  If we ever get to the point where most workers are creating databases for each backend anyway then we can reexamine lazy vs eager.","commit_id":"5bc89e352c5170f2fd9e7dcf8f7afd637e50fb1a"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a38e359cfc1eba1b515fa086a3356c988a0b945f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"test_list_option\u003d--list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instance_provision\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision echo $INSTANCE_COUNT"},{"line_number":10,"context_line":"instance_dispose\u003d${PYTHON:-python} -m oslo.db.sqlalchemy.provision drop --conditional $INSTANCE_IDS"},{"line_number":11,"context_line":"instance_execute\u003dOSLO_SCHEMA_TOKEN\u003d$INSTANCE_ID $COMMAND"}],"source_content_type":"text/plain","patch_set":4,"id":"baada198_83326b5c","line":10,"in_reply_to":"baada198_8d7ffc16","updated":"2014-07-31 02:08:59.000000000","message":"ah because!   \"provision echo\" doesn\u0027t actually create any databases, just identifiers.   then we go into running the tests, 10 processes, each has OSLO_SCHEMA_TOKEN.   So, suppose only three tests in the whole run hits Postgresql; maybe we\u0027re only running a subset of tests, or maybe we\u0027re hitting IBM DB2 or something.  At least seven processes will never need a Postgresql DB for that OSLO_SCHEMA_TOKEN, so that database never gets created.   the other one to three processes that does have a PG test, the first time provision.py is asked for the DB it checks if it exists for that OSLO_SCHEMA_TOKEN and creates if not, caches that result.   \n\nbasically we are creating the databases lazily.   A test run might not end up creating a database for backend X in every process.","commit_id":"5bc89e352c5170f2fd9e7dcf8f7afd637e50fb1a"}],"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"78a77554e06ccf5b1216428c5642d811bf44fc39","unresolved":false,"context_lines":[{"line_number":31,"context_line":"connectivity."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Ibaaefcef2678cc5b985e7c00f05f91b6f02de3f8"},{"line_number":34,"context_line":"Partially-Closes-Bug: 1339206"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_6947157b","line":34,"updated":"2014-07-30 13:34:26.000000000","message":"nit: this should be Partial-Bug: #1339206","commit_id":"2aaf82d9fa6af6aadb42d0711a361585fb255560"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"4cb2f329084d9bc37c31d46232422b1893093649","unresolved":false,"context_lines":[{"line_number":31,"context_line":"connectivity."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Ibaaefcef2678cc5b985e7c00f05f91b6f02de3f8"},{"line_number":34,"context_line":"Partially-Closes-Bug: 1339206"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_ea20709c","line":34,"in_reply_to":"baada198_6947157b","updated":"2014-07-30 15:36:42.000000000","message":"thanks I didnt know what to call that","commit_id":"2aaf82d9fa6af6aadb42d0711a361585fb255560"}],"oslo/db/sqlalchemy/provision.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"78a77554e06ccf5b1216428c5642d811bf44fc39","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def drop_named_database(self, engine, ident, conditional\u003dFalse):"},{"line_number":190,"context_line":"        url \u003d self._provisioned_database_url(engine.url, ident)"},{"line_number":191,"context_line":"        filename \u003d url.database"},{"line_number":192,"context_line":"        if filename and (not conditional or os.access(filename)):"},{"line_number":193,"context_line":"            os.remove(filename)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def database_exists(self, engine, ident):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_49fb31be","line":192,"updated":"2014-07-30 13:34:26.000000000","message":"os.access() takes two arguments","commit_id":"2aaf82d9fa6af6aadb42d0711a361585fb255560"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"4cb2f329084d9bc37c31d46232422b1893093649","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def drop_named_database(self, engine, ident, conditional\u003dFalse):"},{"line_number":190,"context_line":"        url \u003d self._provisioned_database_url(engine.url, ident)"},{"line_number":191,"context_line":"        filename \u003d url.database"},{"line_number":192,"context_line":"        if filename and (not conditional or os.access(filename)):"},{"line_number":193,"context_line":"            os.remove(filename)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def database_exists(self, engine, ident):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8a2374a9","line":192,"in_reply_to":"baada198_49fb31be","updated":"2014-07-30 15:36:42.000000000","message":"oh right os.F_OK","commit_id":"2aaf82d9fa6af6aadb42d0711a361585fb255560"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"877e18f6ecbe5e8218c339b5788d54c9311a5fd1","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    def drop_named_database(self, engine, ident, conditional\u003dFalse):"},{"line_number":334,"context_line":"        \"\"\"Drop a database with the given name.\"\"\""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def drop_all_objects(self, engine):"},{"line_number":337,"context_line":"        \"\"\"Drop all database objects."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        Drops all database objects remaining on the default schema of the"}],"source_content_type":"text/x-python","patch_set":18,"id":"baada198_aa25b417","line":336,"updated":"2014-08-13 14:51:59.000000000","message":"I\u0027m OK with doing the minimum amount of work here and improving this in the corresponding Ilya\u0027s patch (the one he adds support of dropping ENUMs in).","commit_id":"ba755551ef0d08d9525ef8f3b8fbb442df80a67a"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"f11aaedeaa9f96712b6ed6a0df49532d9e6c5747","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    def drop_named_database(self, engine, ident, conditional\u003dFalse):"},{"line_number":336,"context_line":"        \"\"\"Drop a database with the given name.\"\"\""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def drop_all_objects(self, engine):"},{"line_number":339,"context_line":"        \"\"\"Drop all database objects."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        Drops all database objects remaining on the default schema of the"}],"source_content_type":"text/x-python","patch_set":23,"id":"1abeadc6_fef1ec6a","line":338,"updated":"2014-08-27 10:03:16.000000000","message":"Are you planning to overload this method at backend-specific implementation? And the function such as it is now guaranteed meets only the requirements of MySQL. Are you sure that the approach is all-purpose and we can just call super in any case and add backend-specific features, such as ENUM drop?\n\nAnd where is it done? I mean overloading of this method.","commit_id":"9d914bc14794688f8bf36f71e411eb403bb616b8"}]}
