)]}'
{"oslo/db/api.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"6edafc421f1c09210e6457e71f5534f0f02a289b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                # Import the untranslated name if we don\u0027t have a mapping"},{"line_number":178,"context_line":"                backend_path \u003d self._backend_mapping.get(self._backend_name,"},{"line_number":179,"context_line":"                                                         self._backend_name)"},{"line_number":180,"context_line":"                backend_mod \u003d importutils._import_module(backend_path)"},{"line_number":181,"context_line":"                self._backend \u003d backend_mod.get_backend()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __getattr__(self, key):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3f3936d8","line":180,"updated":"2014-08-04 12:32:39.000000000","message":"seems that importutils exports only try_import() as its public API, can we use it  here?","commit_id":"8c5968cb8d007e56679a47ec9ce98a8fcbf60244"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"10972b2d5fb8760b3f55281b8f9b4b6626ada82c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                # Import the untranslated name if we don\u0027t have a mapping"},{"line_number":178,"context_line":"                backend_path \u003d self._backend_mapping.get(self._backend_name,"},{"line_number":179,"context_line":"                                                         self._backend_name)"},{"line_number":180,"context_line":"                backend_mod \u003d importutils._import_module(backend_path)"},{"line_number":181,"context_line":"                self._backend \u003d backend_mod.get_backend()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __getattr__(self, key):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7f8e4ed2","line":180,"in_reply_to":"baada198_1f9e3206","updated":"2014-08-04 12:49:26.000000000","message":"*we can use it here...","commit_id":"8c5968cb8d007e56679a47ec9ce98a8fcbf60244"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b1792c6031f6ce423e8ea9e693609d7620714fb9","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                # Import the untranslated name if we don\u0027t have a mapping"},{"line_number":178,"context_line":"                backend_path \u003d self._backend_mapping.get(self._backend_name,"},{"line_number":179,"context_line":"                                                         self._backend_name)"},{"line_number":180,"context_line":"                backend_mod \u003d importutils._import_module(backend_path)"},{"line_number":181,"context_line":"                self._backend \u003d backend_mod.get_backend()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __getattr__(self, key):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1f9e3206","line":180,"in_reply_to":"baada198_3f3936d8","updated":"2014-08-04 12:48:58.000000000","message":"you are right, we can you it here, but we should check that import is finished successfully.\nDone in next patch.","commit_id":"8c5968cb8d007e56679a47ec9ce98a8fcbf60244"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"64e76489d63263120b623a0228db4ad57445fcfd","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                                         self._backend_name)"},{"line_number":180,"context_line":"                backend_mod \u003d importutils.try_import(backend_path)"},{"line_number":181,"context_line":"                if not backend_mod:"},{"line_number":182,"context_line":"                    raise ImportError(\"Backend import is failed.\")"},{"line_number":183,"context_line":"                self._backend \u003d backend_mod.get_backend()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def __getattr__(self, key):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4510f057","line":182,"updated":"2014-08-11 14:24:53.000000000","message":"Would it make sense to print the backend name?\n\n    if not backend_mod:\n        raise ImportError(\"Unable to import backend %s\" % self._backend_name)","commit_id":"87073f9ba29953ed09da11e6b0bc13d62c066705"},{"author":{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},"change_message_id":"cba336be6462a026a1378ce9576a3ff00db8895b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                                         self._backend_name)"},{"line_number":180,"context_line":"                backend_mod \u003d importutils.try_import(backend_path)"},{"line_number":181,"context_line":"                if not backend_mod:"},{"line_number":182,"context_line":"                    raise ImportError(\"Backend import is failed.\")"},{"line_number":183,"context_line":"                self._backend \u003d backend_mod.get_backend()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def __getattr__(self, key):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_97bddb05","line":182,"in_reply_to":"baada198_4510f057","updated":"2014-08-11 14:29:18.000000000","message":"That is good to have, right...","commit_id":"87073f9ba29953ed09da11e6b0bc13d62c066705"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b17bbc2dad39193e28e0494db34b125f3edaca62","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                                         self._backend_name)"},{"line_number":180,"context_line":"                backend_mod \u003d importutils.try_import(backend_path)"},{"line_number":181,"context_line":"                if not backend_mod:"},{"line_number":182,"context_line":"                    raise ImportError(\"Backend import is failed.\")"},{"line_number":183,"context_line":"                self._backend \u003d backend_mod.get_backend()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def __getattr__(self, key):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_777a0726","line":182,"in_reply_to":"baada198_4510f057","updated":"2014-08-11 14:34:54.000000000","message":"agreed. fixed","commit_id":"87073f9ba29953ed09da11e6b0bc13d62c066705"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"502b291d2e69f0932d7f37639e9c9ec3b78e6b54","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import time"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from oslo.utils import importutils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from oslo.db import exception"},{"line_number":34,"context_line":"from oslo.db.openstack.common.gettextutils import _LE"},{"line_number":35,"context_line":"from oslo.db import options"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_971ebb72","line":32,"updated":"2014-08-11 14:43:23.000000000","message":"redundant empty line","commit_id":"6065b21b15b1b772cea281a99704c3c8d92c61cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"df480ad867b75c08da62101a6e585eb36a5f2648","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import time"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from oslo.utils import importutils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from oslo.db import exception"},{"line_number":34,"context_line":"from oslo.db.openstack.common.gettextutils import _LE"},{"line_number":35,"context_line":"from oslo.db import options"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_fab8bee9","line":32,"in_reply_to":"baada198_971ebb72","updated":"2014-08-11 14:51:58.000000000","message":"disagree:)\ndespite the fact that `oslo.db` and `oslo.utils` are in one namespace, `oslo.utils` is a related third party library, while `oslo.db` is a local library, so this imports should be separated with one empty line.","commit_id":"6065b21b15b1b772cea281a99704c3c8d92c61cb"}],"tests/test_api.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"6daee4e5f3df39c69a708f386ef4218480e2cc74","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.db import api"},{"line_number":23,"context_line":"from oslo.db import exception"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from tests import utils as test_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"sqla \u003d importutils.try_import(\u0027sqlalchemy\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f3e295d2","line":24,"updated":"2014-08-04 15:28:37.000000000","message":"please remove this empty line","commit_id":"a873941689aeb8b174044843e70593e4fa5fa4d0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f0a25d0665bade0f1a94f14a8a18c37d522118f8","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.db import api"},{"line_number":23,"context_line":"from oslo.db import exception"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from tests import utils as test_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"sqla \u003d importutils.try_import(\u0027sqlalchemy\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f2944c8d","line":24,"in_reply_to":"baada198_f3e295d2","updated":"2014-08-04 15:33:59.000000000","message":"Done","commit_id":"a873941689aeb8b174044843e70593e4fa5fa4d0"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"64e76489d63263120b623a0228db4ad57445fcfd","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"sqla \u003d importutils.try_import(\u0027sqlalchemy\u0027)"},{"line_number":27,"context_line":"if not sqla:"},{"line_number":28,"context_line":"    raise ImportError(\"Error occurred during importing \u0027sqlalchemy\u0027.\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_backend():"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_97331bf6","line":28,"updated":"2014-08-11 14:24:53.000000000","message":"Would you consider a slight change?\n\n    raise ImportError(\"Unable to import module \u0027sqlalchemy\u0027.\")","commit_id":"87073f9ba29953ed09da11e6b0bc13d62c066705"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b17bbc2dad39193e28e0494db34b125f3edaca62","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"sqla \u003d importutils.try_import(\u0027sqlalchemy\u0027)"},{"line_number":27,"context_line":"if not sqla:"},{"line_number":28,"context_line":"    raise ImportError(\"Error occurred during importing \u0027sqlalchemy\u0027.\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_backend():"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_377def1e","line":28,"in_reply_to":"baada198_97331bf6","updated":"2014-08-11 14:34:54.000000000","message":"Done","commit_id":"87073f9ba29953ed09da11e6b0bc13d62c066705"}]}
