)]}'
{"tests/sqlalchemy/test_exc_filters.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"054a7bcb456021b7ece7c586ee9fc6e8d6bd4f56","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo.db.sqlalchemy import exc_filters"},{"line_number":25,"context_line":"from oslo.db.sqlalchemy import session"},{"line_number":26,"context_line":"from oslo.db.sqlalchemy import test_base"},{"line_number":27,"context_line":"from oslotest import base as oslo_test_base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_TABLE_NAME \u003d \u0027__tmp__test__tmp__\u0027"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_da8e4126","line":27,"updated":"2014-08-13 09:57:37.000000000","message":"nit: oslotest should be treated here as a 3rd party library","commit_id":"90c39feddd38a8d3ee59808fc179a3b2dccaf485"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"40aae30cab26a10a5cc2531fc24945359a32e93b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo.db.sqlalchemy import exc_filters"},{"line_number":25,"context_line":"from oslo.db.sqlalchemy import session"},{"line_number":26,"context_line":"from oslo.db.sqlalchemy import test_base"},{"line_number":27,"context_line":"from oslotest import base as oslo_test_base"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_TABLE_NAME \u003d \u0027__tmp__test__tmp__\u0027"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ab29df4_f75ee011","line":27,"in_reply_to":"baada198_da8e4126","updated":"2014-08-13 18:38:26.000000000","message":"Done","commit_id":"90c39feddd38a8d3ee59808fc179a3b2dccaf485"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"82cc042ce7c22497844ba2f29e67059ac27d2ab1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo.db.sqlalchemy import exc_filters"},{"line_number":26,"context_line":"from oslo.db.sqlalchemy import session"},{"line_number":27,"context_line":"from oslo.db.sqlalchemy import test_base"},{"line_number":28,"context_line":"from oslotest import base as oslo_test_base"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"_TABLE_NAME \u003d \u0027__tmp__test__tmp__\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ab29df4_57830ccc","line":28,"updated":"2014-08-13 18:51:51.000000000","message":"im trying to review -R to get rid of this and it\u0027s not working.   please hold...","commit_id":"f29472d7a235ed36dfba158e999e0bdb92cedc67"}],"tests/sqlalchemy/test_sqlalchemy.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"054a7bcb456021b7ece7c586ee9fc6e8d6bd4f56","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.addCleanup(self.test_table.drop, self.engine)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_plain_transaction(self):"},{"line_number":101,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":102,"context_line":"        trans \u003d conn.begin()"},{"line_number":103,"context_line":"        conn.execute("},{"line_number":104,"context_line":"            self.test_table.insert(),"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_dd5d5bed","line":101,"updated":"2014-08-13 09:57:37.000000000","message":"nit: can we add self.addCleanup(conn.close) here?","commit_id":"90c39feddd38a8d3ee59808fc179a3b2dccaf485"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"40aae30cab26a10a5cc2531fc24945359a32e93b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.addCleanup(self.test_table.drop, self.engine)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_plain_transaction(self):"},{"line_number":101,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":102,"context_line":"        trans \u003d conn.begin()"},{"line_number":103,"context_line":"        conn.execute("},{"line_number":104,"context_line":"            self.test_table.insert(),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ab29df4_1774349b","line":101,"in_reply_to":"baada198_dd5d5bed","updated":"2014-08-13 18:38:26.000000000","message":"good idea.  how about \"with self.engine.connect()\"?   Ill try that first.","commit_id":"90c39feddd38a8d3ee59808fc179a3b2dccaf485"}]}
