)]}'
{"oslo/db/sqlalchemy/provision.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"806028b5a41ed8ac4785c7e72fd987402f5e4746","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if provision_key in cls._provisioned_backend_by_token:"},{"line_number":79,"context_line":"            return cls._provisioned_backend_by_token[provision_key]"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            provisioned_db \u003d \\"},{"line_number":82,"context_line":"                cls._provisioned_backend_by_token[provision_key] \u003d \\"},{"line_number":83,"context_line":"                ProvisionedDatabase("},{"line_number":84,"context_line":"                    database_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_2a2fc7a2","line":81,"updated":"2014-08-26 14:36:02.000000000","message":"nit: Looks ugly. I like this style, like a \u003d b \u003d f(), but not in this particular case. Decompose it please.","commit_id":"86380da8a7c95a81976ef429a4f1084d7f293726"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"07de764aed944fb7147f650a7bf0e41f3137348c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if provision_key in cls._provisioned_backend_by_token:"},{"line_number":79,"context_line":"            return cls._provisioned_backend_by_token[provision_key]"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            provisioned_db \u003d \\"},{"line_number":82,"context_line":"                cls._provisioned_backend_by_token[provision_key] \u003d \\"},{"line_number":83,"context_line":"                ProvisionedDatabase("},{"line_number":84,"context_line":"                    database_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_d0ae0298","line":81,"in_reply_to":"1abeadc6_2a2fc7a2","updated":"2014-08-26 14:43:00.000000000","message":"I hate creating throwaway variable names though.  They confuse the namespace and lead to errors when that name is accidentally used later.  is that what you prefer?","commit_id":"86380da8a7c95a81976ef429a4f1084d7f293726"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"cbac8fc364c077230d35b6660688b0d36531ece3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if provision_key in cls._provisioned_backend_by_token:"},{"line_number":79,"context_line":"            return cls._provisioned_backend_by_token[provision_key]"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            provisioned_db \u003d \\"},{"line_number":82,"context_line":"                cls._provisioned_backend_by_token[provision_key] \u003d \\"},{"line_number":83,"context_line":"                ProvisionedDatabase("},{"line_number":84,"context_line":"                    database_type,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa98f980_04c92279","line":81,"in_reply_to":"1abeadc6_d0ae0298","updated":"2014-09-10 09:03:05.000000000","message":"No, I\u0027m talking about the same variables.\n\n     provisioned_db \u003d ProvisionedDatabase(...\n     cls._provisioned_backend_by_token[provision_key] \u003d provisioned_db\n\nIt is much easier to read.","commit_id":"86380da8a7c95a81976ef429a4f1084d7f293726"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"806028b5a41ed8ac4785c7e72fd987402f5e4746","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def __init__("},{"line_number":92,"context_line":"            self, database_type, db_token,"},{"line_number":93,"context_line":"            externally_managed, generate_schema):"},{"line_number":94,"context_line":"        self.provision_key \u003d (database_type, db_token)"},{"line_number":95,"context_line":"        self.backend \u003d Backend.backend_for_database_type(database_type)"},{"line_number":96,"context_line":"        self.db_token \u003d db_token"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_b57c1874","line":93,"updated":"2014-08-26 14:36:02.000000000","message":"nit: Please add an extra line, it is hard to see where arguments end.","commit_id":"86380da8a7c95a81976ef429a4f1084d7f293726"}],"oslo/db/sqlalchemy/test_base.py":[{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"806028b5a41ed8ac4785c7e72fd987402f5e4746","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        if self.SCHEMA_SCOPE:"},{"line_number":93,"context_line":"            # if SCHEMA_SCOPE is set, then this method definitely"},{"line_number":94,"context_line":"            # has to be implemented.  This is a guard against a test"},{"line_number":95,"context_line":"            # that inadvertently does schema setup within setUp()."},{"line_number":96,"context_line":"            raise NotImplementedError("}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_d55d147b","line":93,"updated":"2014-08-26 14:36:02.000000000","message":"How SCHEMA_SCOPE can become a set? And why is it happen only when the method doesn\u0027t implemented?","commit_id":"86380da8a7c95a81976ef429a4f1084d7f293726"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"07de764aed944fb7147f650a7bf0e41f3137348c","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        if self.SCHEMA_SCOPE:"},{"line_number":93,"context_line":"            # if SCHEMA_SCOPE is set, then this method definitely"},{"line_number":94,"context_line":"            # has to be implemented.  This is a guard against a test"},{"line_number":95,"context_line":"            # that inadvertently does schema setup within setUp()."},{"line_number":96,"context_line":"            raise NotImplementedError("}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_f0e69e15","line":93,"in_reply_to":"1abeadc6_d55d147b","updated":"2014-08-26 14:43:00.000000000","message":"SCHEMA_SCOPE is set at the class level on the test class.  if a test class wants to declare itself as part of a schema scope of \"nova\", it would say \"SCHEMA_SCOPE\u003d\u0027nova\u0027\" up above where you see that set to None right now.","commit_id":"86380da8a7c95a81976ef429a4f1084d7f293726"}]}
