)]}'
{"oslo/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"2543158d51cffa92126f110eb2c9e49a0dc40740","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    The difference between MODELS and MIGRATION scripts will be printed and"},{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    \"add_table\": description of the table from models"},{"line_number":266,"context_line":"    \"remove_table\": description of the table from database"},{"line_number":267,"context_line":"    \"add_column\": schema, table name, column description from models"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_eee811e4","line":264,"updated":"2014-08-21 17:34:24.000000000","message":"it\u0027s a list, (e.g. `[]`) of directives, what\u0027s the format of a directive?  A dictionary?\n\nif this is in pseudo-code form, should we use .rst formatting?  e.g. \n\n   with their description::\n\n        {\n            \"add_table\": description of the table from models,\n            \"remove_table\": ....","commit_id":"219682e6f4b5faa364487f847a5b09dd68a89bf1"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"d824da245abc1a3b5b231bd69ac3340f90b75ba6","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    The difference between MODELS and MIGRATION scripts will be printed and"},{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    \"add_table\": description of the table from models"},{"line_number":266,"context_line":"    \"remove_table\": description of the table from database"},{"line_number":267,"context_line":"    \"add_column\": schema, table name, column description from models"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3101806a","line":264,"in_reply_to":"1abeadc6_2e5bdff6","updated":"2014-08-21 23:27:50.000000000","message":"yup, that\u0027s what i had in mind, just so it shows what we\u0027re getting back (since it\u0027s showing code)","commit_id":"219682e6f4b5faa364487f847a5b09dd68a89bf1"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"37068ea8cd4472f22fad4cafbe50f430ac289cfc","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    The difference between MODELS and MIGRATION scripts will be printed and"},{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    \"add_table\": description of the table from models"},{"line_number":266,"context_line":"    \"remove_table\": description of the table from database"},{"line_number":267,"context_line":"    \"add_column\": schema, table name, column description from models"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_2e5bdff6","line":264,"in_reply_to":"1abeadc6_8e6153d5","updated":"2014-08-21 22:37:58.000000000","message":"Ok. What about if change this description to such form:\n[(\u0027add_table\u0027, description of the table)\n.....\n]\n?","commit_id":"219682e6f4b5faa364487f847a5b09dd68a89bf1"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a8d0c6befa2b1450dd6761467b60e20dc5ade6b8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    The difference between MODELS and MIGRATION scripts will be printed and"},{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    \"add_table\": description of the table from models"},{"line_number":266,"context_line":"    \"remove_table\": description of the table from database"},{"line_number":267,"context_line":"    \"add_column\": schema, table name, column description from models"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_8e6153d5","line":264,"in_reply_to":"1abeadc6_ebcd5932","updated":"2014-08-21 22:31:43.000000000","message":"OK, I just figured, if we are adding a description, why don\u0027t we make the format clear, since I didnt know what this returns and the new description didn\u0027t help ;)  we\u0027re looking to document field descriptions as well as the physical format, e.g. with those dictionaries you have, so if we are documenting physical format, we should do that consistently, e.g. make sure the full format is understood.","commit_id":"219682e6f4b5faa364487f847a5b09dd68a89bf1"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"c9b9864f51d3f58f4b6144445af360dae903ae46","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    The difference between MODELS and MIGRATION scripts will be printed and"},{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    \"add_table\": description of the table from models"},{"line_number":266,"context_line":"    \"remove_table\": description of the table from database"},{"line_number":267,"context_line":"    \"add_column\": schema, table name, column description from models"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_ebcd5932","line":264,"in_reply_to":"1abeadc6_eee811e4","updated":"2014-08-21 22:16:33.000000000","message":"As i know, diff is a list of tuples. Each tuple contains a name of the directive e.g. \"remove_table\" and some other elements that represent this directive. This is a text description of possible directives in the form: name of directive(first element in tuple) and the description of the other elements in a tuple in the order they appear.","commit_id":"219682e6f4b5faa364487f847a5b09dd68a89bf1"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"80d195f7035ab586fcab82ad576cb360cfc2586b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    [(\u0027add_table\u0027, description of the table from models),"},{"line_number":266,"context_line":"    (\u0027remove_table\u0027, description of the table from database),"},{"line_number":267,"context_line":"    (\u0027add_column\u0027, schema, table name, column description from models),"},{"line_number":268,"context_line":"    (\u0027remove_column\u0027, schema, table name, column description from database),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_ace365d7","line":265,"updated":"2014-08-22 12:09:26.000000000","message":"well, IMO it still hard to read. See comments to previous patch set","commit_id":"11c96bafa1d9c80bca176ec386d25bae6a8c65ce"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"7f83e1f47da47355ca2aa97d2ddc533245ac8f99","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    [(\u0027add_table\u0027, description of the table from models),"},{"line_number":266,"context_line":"    (\u0027remove_table\u0027, description of the table from database),"},{"line_number":267,"context_line":"    (\u0027add_column\u0027, schema, table name, column description from models),"},{"line_number":268,"context_line":"    (\u0027remove_column\u0027, schema, table name, column description from database),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_e9662a50","line":265,"in_reply_to":"1abeadc6_ace365d7","updated":"2014-08-22 14:05:16.000000000","message":"Seems that i don\u0027t know how to make this more readably. Can you provide description for one directive as example? Thanks.","commit_id":"11c96bafa1d9c80bca176ec386d25bae6a8c65ce"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"8f9c38f711b1c87df0a888b163e6cb478a946d8d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    [(\u0027add_table\u0027, description of the table from models),"},{"line_number":266,"context_line":"    (\u0027remove_table\u0027, description of the table from database),"},{"line_number":267,"context_line":"    (\u0027add_column\u0027, schema, table name, column description from models),"},{"line_number":268,"context_line":"    (\u0027remove_column\u0027, schema, table name, column description from database),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_7f9e4864","line":265,"in_reply_to":"1abeadc6_e9662a50","updated":"2014-08-22 14:52:50.000000000","message":"Maybe someone will suggest a better idea, but IMO, you can use something like\n\n (\n     \u0027modify_nullable\u0027,\n     schema,\n     table name,\n     column name,\n     {\n         \u0027existing_type\u0027: type of the column from database,\n         \u0027existing_server_default\u0027: default value of the column from database,\n     },\n     nullable from database,\n     nullable from models\n ),\n\n\nAlso you can add some example here","commit_id":"11c96bafa1d9c80bca176ec386d25bae6a8c65ce"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"0d6a01a7bf28c4f5f363bddd1b68cde7078f283c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    then compare the given metadata to the one reflected from the database."},{"line_number":261,"context_line":"    The difference between MODELS and MIGRATION scripts will be printed and"},{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    ["},{"line_number":266,"context_line":"        ("}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_4641fb61","line":263,"updated":"2014-08-28 16:23:39.000000000","message":"Perhaps, mentioning the following would make this more clear:\n\nThe return value is really a list of actions, that should be performed in order to make the current database schema state (i.e. migration scripts) consistent with models definitions. It\u0027s left up to developers to analyze the output and decide whether the models definitions or the migration scripts should be modified to make them consistent.","commit_id":"50e5d5cfb2f71c02714e09b081281184a594c8e6"},{"author":{"_account_id":12363,"name":"Oleksii Chuprykov","email":"a.chuprikoff@gmail.com","username":"ochuprykov"},"change_message_id":"3cf8f93ef4604c3bdb1cdb79f0d31e9137e3dfbb","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    then compare the given metadata to the one reflected from the database."},{"line_number":261,"context_line":"    The difference between MODELS and MIGRATION scripts will be printed and"},{"line_number":262,"context_line":"    the test will fail, if the difference is not empty. The return format is a"},{"line_number":263,"context_line":"    list of diff directives, each representing individual differences."},{"line_number":264,"context_line":"    Possible diff directives with their description:"},{"line_number":265,"context_line":"    ["},{"line_number":266,"context_line":"        ("}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_c437c3e1","line":263,"in_reply_to":"1abeadc6_4641fb61","updated":"2014-08-28 16:37:36.000000000","message":"It seems that you\u0027re right.  I will add this part of description in the next patch.","commit_id":"50e5d5cfb2f71c02714e09b081281184a594c8e6"}]}