)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9ab72c845a11ab22eef9a5242d372e877d08bc7e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get a tox environment for py34/py33 that doesn\u0027t stop the existing"},{"line_number":10,"context_line":"py26 and py27 to continue working with the adjusted test-requirements"},{"line_number":11,"context_line":"and requirements files (MySQL-python and sqlalchemy-migrate do not"},{"line_number":12,"context_line":"yet exist in 3.x)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that this does not fully make py34 work yet but it starts to work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da9df570_7a6ff692","line":11,"updated":"2014-09-23 07:40:37.000000000","message":"only test-requirements and MySQL-python","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a0cecc66b0fc6b71702e01f08c3321a7033d227d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Get a tox environment for py34/py33 that doesn\u0027t stop the existing"},{"line_number":10,"context_line":"py26 and py27 to continue working with the adjusted test-requirements"},{"line_number":11,"context_line":"and requirements files (MySQL-python and sqlalchemy-migrate do not"},{"line_number":12,"context_line":"yet exist in 3.x)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that this does not fully make py34 work yet but it starts to work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da9df570_dcd52cba","line":11,"in_reply_to":"da9df570_7a6ff692","updated":"2014-09-23 18:28:37.000000000","message":"Done","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"}],"test-requirements-py3.txt":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9ab72c845a11ab22eef9a5242d372e877d08bc7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"da9df570_5a96b295","line":1,"updated":"2014-09-23 07:40:37.000000000","message":"What is the reason of removing `pymysql` from here? If you suppose to have it in tox.ini (which is questionable) we can add MySQL-python there as well an keep general test-requirements","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a0cecc66b0fc6b71702e01f08c3321a7033d227d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"da9df570_9c99e421","line":1,"in_reply_to":"da9df570_5a96b295","updated":"2014-09-23 18:28:37.000000000","message":"It doesn\u0027t exist in the requirements repo, thus grenade fails...\n\nUnsure what else to do about that, better to have something being tested for mysql vs nothing, unless we want to try the battle of getting pymysql into requirements repo?","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"49207e83fe37b95f3a82b4bb2f8ac65eb4a755ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"da9df570_c4bb77e3","line":1,"in_reply_to":"da9df570_9acaad6c","updated":"2014-09-24 15:41:52.000000000","message":"Hmmm, ok, I can remove it from here until that gets merged I guess. Thanks for proposing it, last time I tried that they shot it down...","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d1bc56f07c0639995762a6a85a83ed0f5f79c8c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"da9df570_d9ed27f1","line":1,"in_reply_to":"da9df570_9c99e421","updated":"2014-09-24 12:29:56.000000000","message":"hmm, seems to be, that we have a single mysql connector in requirements - MySQL-python :(","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e88c7948725ac39039e9bbdc273c02390eeaaa05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""}],"source_content_type":"text/plain","patch_set":10,"id":"da9df570_9acaad6c","line":1,"in_reply_to":"da9df570_d9ed27f1","updated":"2014-09-24 14:11:22.000000000","message":"I\u0027ve made a patch to requirements - to add PyMySQL there [1] - but folks asked me to hold on with it until Kilo\n\n[1] https://review.openstack.org/#/c/123737","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"}],"tox.ini":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9ab72c845a11ab22eef9a5242d372e877d08bc7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.6"},{"line_number":3,"context_line":"envlist \u003d py26,py27,py33,py34,pep8"},{"line_number":4,"context_line":"# NOTE(dhellmann): We cannot set skipdist\u003dTrue"},{"line_number":5,"context_line":"# for oslo libraries because of the namespace package."},{"line_number":6,"context_line":"#skipsdist \u003d True"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da9df570_9abe5afe","line":3,"updated":"2014-09-23 07:40:37.000000000","message":"I\u0027m a bit confused to see py34 env here. Seems to be, that I miss something - should we support it?","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"9ab72c845a11ab22eef9a5242d372e877d08bc7e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"setenv \u003d"},{"line_number":14,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements-py2.txt"},{"line_number":17,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[testenv:sqla_09]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da9df570_fa63e6ae","line":16,"updated":"2014-09-23 07:40:37.000000000","message":"I really don\u0027t mind, but `oslo-incubator` has `test-requirements.txt` and `test-requirements-py3.txt` files","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d1bc56f07c0639995762a6a85a83ed0f5f79c8c9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"setenv \u003d"},{"line_number":14,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements-py2.txt"},{"line_number":17,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[testenv:sqla_09]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da9df570_59b937e8","line":16,"in_reply_to":"da9df570_1cac1435","updated":"2014-09-24 12:29:56.000000000","message":"ok, let someone else look at this","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a0cecc66b0fc6b71702e01f08c3321a7033d227d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"setenv \u003d"},{"line_number":14,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements-py2.txt"},{"line_number":17,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[testenv:sqla_09]"}],"source_content_type":"text/x-properties","patch_set":10,"id":"da9df570_1cac1435","line":16,"in_reply_to":"da9df570_fa63e6ae","updated":"2014-09-23 18:28:37.000000000","message":"Seems more obvious when you name the version its supposed to work with vs. not naming it imho.","commit_id":"91c749ce86cffb9cc5b0ac2503036496c0c2844c"}]}
