)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"7a990f85c80690f10e33878bfab55185108b45bf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Python3.x always will warn about scoping visibility issues"},{"line_number":14,"context_line":"when a exception is used later after it has been caught so"},{"line_number":15,"context_line":"make sure we initially set it to none."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia86a2bd1a46e57eaf47704eadc991fd0c9b08661"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a890539_44308be8","line":16,"updated":"2014-11-12 10:57:23.000000000","message":"1 - I suppose, that these changes should come separately\n\n2 - see similar code at https://github.com/openstack/oslo.db/blob/master/oslo/db/sqlalchemy/session.py#L577","commit_id":"6b1c554d3d6eac814526a38bed1ed4b91e4d54db"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"063f17b2669fa207a71ab0e334472411a0b03764","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Python3.x always will warn about scoping visibility issues"},{"line_number":14,"context_line":"when a exception is used later after it has been caught so"},{"line_number":15,"context_line":"make sure we initially set it to none."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia86a2bd1a46e57eaf47704eadc991fd0c9b08661"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a890539_b5169fef","line":16,"in_reply_to":"5a890539_44308be8","updated":"2014-11-13 08:26:17.000000000","message":"Will adjust. Thanks.","commit_id":"6b1c554d3d6eac814526a38bed1ed4b91e4d54db"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"95ab1af0dae3398c28fe1a1a6007f3eecf26513c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Python3.x always will warn about scoping visibility issues"},{"line_number":14,"context_line":"when a exception is used later after it has been caught so"},{"line_number":15,"context_line":"make sure we initially set it to none."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia86a2bd1a46e57eaf47704eadc991fd0c9b08661"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a890539_6a4233af","line":16,"in_reply_to":"5a890539_b5169fef","updated":"2014-11-17 09:32:33.000000000","message":"Sorry, I missed your patch  I9ea2bd6b3a8c392f8d27b0130dd6b7683fc44e7c\nCould you please change file `tests/sqlalchemy/test_exc_filters.py` in that patch?","commit_id":"6b1c554d3d6eac814526a38bed1ed4b91e4d54db"}],"tests/sqlalchemy/test_exc_filters.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"533d4f43b7741c3f6ef00a4b521c42e769dc4506","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            six.u(\u0027\\u2435\u0027).encode(\u0027ascii\u0027)"},{"line_number":182,"context_line":"        except UnicodeEncodeError as uee:"},{"line_number":183,"context_line":"            pass"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        self._run_test("},{"line_number":186,"context_line":"            \"postgresql\", six.u(\u0027select \\u2435\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_5d403aa5","line":183,"updated":"2014-09-24 17:30:19.000000000","message":"crap, I wrote this code.   this is very sad.","commit_id":"94edab032435b9aed100cd8aab4a44477d22ce49"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"8927f479c22b4fda3a49f5c9c7be9fcd5b726659","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # intentionally generate a UnicodeEncodeError, as its"},{"line_number":177,"context_line":"        # constructor is quite complicated and seems to be non-public"},{"line_number":178,"context_line":"        # or at least not documented anywhere."},{"line_number":179,"context_line":"        uee \u003d None"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            six.u(\u0027\\u2435\u0027).encode(\u0027ascii\u0027)"},{"line_number":182,"context_line":"        except UnicodeEncodeError as uee:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_a7a040a0","line":179,"updated":"2014-10-02 10:58:44.000000000","message":"please explain, what is the purpose of this change?","commit_id":"f02a1e775df3291855ceebfdd2e4c54bd8606b05"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"12973a94765bb64d5d8708a8e2a362e5ce73987c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # intentionally generate a UnicodeEncodeError, as its"},{"line_number":177,"context_line":"        # constructor is quite complicated and seems to be non-public"},{"line_number":178,"context_line":"        # or at least not documented anywhere."},{"line_number":179,"context_line":"        uee \u003d None"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            six.u(\u0027\\u2435\u0027).encode(\u0027ascii\u0027)"},{"line_number":182,"context_line":"        except UnicodeEncodeError as uee:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_749c4e5e","line":179,"in_reply_to":"baa201ad_1d909794","updated":"2014-10-13 17:34:17.000000000","message":"Its used in the below self._run_test; so its bad if its deleted. Thats mainly why I\u0027m doing this, so that it isn\u0027t deleted :)","commit_id":"f02a1e775df3291855ceebfdd2e4c54bd8606b05"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"6458c55d30f8bab2534f3a562cc07c83c0dce7c8","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # intentionally generate a UnicodeEncodeError, as its"},{"line_number":177,"context_line":"        # constructor is quite complicated and seems to be non-public"},{"line_number":178,"context_line":"        # or at least not documented anywhere."},{"line_number":179,"context_line":"        uee \u003d None"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            six.u(\u0027\\u2435\u0027).encode(\u0027ascii\u0027)"},{"line_number":182,"context_line":"        except UnicodeEncodeError as uee:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_1d909794","line":179,"in_reply_to":"baa201ad_7d56c02b","updated":"2014-10-13 08:22:08.000000000","message":"ok, I got this point, but anyway I confused, because `uee` variable will be deleted after exit from `except:` block on lines 182-183. Could you please explain this a bit?","commit_id":"f02a1e775df3291855ceebfdd2e4c54bd8606b05"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"945e3b29fa76fae33c826c798477ed80a23ca0cd","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # intentionally generate a UnicodeEncodeError, as its"},{"line_number":177,"context_line":"        # constructor is quite complicated and seems to be non-public"},{"line_number":178,"context_line":"        # or at least not documented anywhere."},{"line_number":179,"context_line":"        uee \u003d None"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            six.u(\u0027\\u2435\u0027).encode(\u0027ascii\u0027)"},{"line_number":182,"context_line":"        except UnicodeEncodeError as uee:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_dd516c37","line":179,"in_reply_to":"baa201ad_7dfa4044","updated":"2014-10-03 19:22:54.000000000","message":"Found @ http://legacy.python.org/dev/peps/pep-3110/","commit_id":"f02a1e775df3291855ceebfdd2e4c54bd8606b05"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d017ed337481232ce392598176b7fd6a5f0cb7d9","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # intentionally generate a UnicodeEncodeError, as its"},{"line_number":177,"context_line":"        # constructor is quite complicated and seems to be non-public"},{"line_number":178,"context_line":"        # or at least not documented anywhere."},{"line_number":179,"context_line":"        uee \u003d None"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            six.u(\u0027\\u2435\u0027).encode(\u0027ascii\u0027)"},{"line_number":182,"context_line":"        except UnicodeEncodeError as uee:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_7dfa4044","line":179,"in_reply_to":"baa201ad_a7a040a0","updated":"2014-10-03 19:18:15.000000000","message":"Exception scoping, from what I understand python 3 changed how exception variables that are declared in an exception will not appear in the scope of that environment unless the exception handler is called. So using \u0027uee\u0027 later can not be depended upon in the generic case (although this code will ensure it exists due to it always failing). Setting it beforehand makes sure that the uee variable is always set.\n\nThere is probably a pep-XYZ that explains this, but I can\u0027t find currently find it...","commit_id":"f02a1e775df3291855ceebfdd2e4c54bd8606b05"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"64097a7da2042db68f7ad8013e76ab4b1b630bb4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        # intentionally generate a UnicodeEncodeError, as its"},{"line_number":177,"context_line":"        # constructor is quite complicated and seems to be non-public"},{"line_number":178,"context_line":"        # or at least not documented anywhere."},{"line_number":179,"context_line":"        uee \u003d None"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            six.u(\u0027\\u2435\u0027).encode(\u0027ascii\u0027)"},{"line_number":182,"context_line":"        except UnicodeEncodeError as uee:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_7d56c02b","line":179,"in_reply_to":"baa201ad_dd516c37","updated":"2014-10-03 19:24:06.000000000","message":"A good explanation also @ http://stackoverflow.com/a/15078295","commit_id":"f02a1e775df3291855ceebfdd2e4c54bd8606b05"}],"tests/sqlalchemy/test_sqlalchemy.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"533d4f43b7741c3f6ef00a4b521c42e769dc4506","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                          expire_on_commit\u003dTrue)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def test_slave_connection(self):"},{"line_number":343,"context_line":"        paths \u003d self.create_tempfiles([(\u0027db.master\u0027, b\u0027\u0027), (\u0027db.slave\u0027, b\u0027\u0027)],"},{"line_number":344,"context_line":"                                      ext\u003d\u0027\u0027)"},{"line_number":345,"context_line":"        master_path \u003d \u0027sqlite:///\u0027 + paths[0]"},{"line_number":346,"context_line":"        slave_path \u003d \u0027sqlite:///\u0027 + paths[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_3d5ff673","line":343,"updated":"2014-09-24 17:30:19.000000000","message":"should we maybe make oslotest a little nicer here?  the b\u0027\u0027 is awkward.","commit_id":"94edab032435b9aed100cd8aab4a44477d22ce49"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"731ce5a14ff0c2afed7116b5d1b652fd202794b2","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                          expire_on_commit\u003dTrue)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def test_slave_connection(self):"},{"line_number":343,"context_line":"        paths \u003d self.create_tempfiles([(\u0027db.master\u0027, b\u0027\u0027), (\u0027db.slave\u0027, b\u0027\u0027)],"},{"line_number":344,"context_line":"                                      ext\u003d\u0027\u0027)"},{"line_number":345,"context_line":"        master_path \u003d \u0027sqlite:///\u0027 + paths[0]"},{"line_number":346,"context_line":"        slave_path \u003d \u0027sqlite:///\u0027 + paths[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_b22f87f5","line":343,"in_reply_to":"da9df570_3d5ff673","updated":"2014-09-25 02:36:52.000000000","message":"Likely, will propose a patch there.","commit_id":"94edab032435b9aed100cd8aab4a44477d22ce49"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"c0a965ad227dcd2f19a0241e5c5a9c70dc900682","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                          expire_on_commit\u003dTrue)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def test_slave_connection(self):"},{"line_number":343,"context_line":"        paths \u003d self.create_tempfiles([(\u0027db.master\u0027, b\u0027\u0027), (\u0027db.slave\u0027, b\u0027\u0027)],"},{"line_number":344,"context_line":"                                      ext\u003d\u0027\u0027)"},{"line_number":345,"context_line":"        master_path \u003d \u0027sqlite:///\u0027 + paths[0]"},{"line_number":346,"context_line":"        slave_path \u003d \u0027sqlite:///\u0027 + paths[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_f2baef6c","line":343,"in_reply_to":"da9df570_b22f87f5","updated":"2014-09-25 02:56:03.000000000","message":"Change @ https://review.openstack.org/#/c/123919/ for that in oslotest.","commit_id":"94edab032435b9aed100cd8aab4a44477d22ce49"}]}