)]}'
{"oslo_db/sqlalchemy/provision.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bb4ad91cf74e93dba4f240a6f250479c35885182","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def make(self, dependency_resources):"},{"line_number":68,"context_line":"        dependency_resources[\u0027db_token\u0027] \u003d db_token \u003d _random_ident()"},{"line_number":69,"context_line":"        backend \u003d dependency_resources[\u0027backend\u0027]"},{"line_number":70,"context_line":"        LOG.info("},{"line_number":71,"context_line":"            \"CREATE BACKEND %s TOKEN %s\", backend.engine.url, db_token)"},{"line_number":72,"context_line":"        backend.create_named_database(db_token, conditional\u003dTrue)"},{"line_number":73,"context_line":"        dependency_resources[\u0027engine\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_c8ffe500","line":70,"updated":"2015-01-06 11:50:56.000000000","message":"nit: \n\n LOG.info(_LI(\"CREATE ... \"))","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bb4ad91cf74e93dba4f240a6f250479c35885182","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def clean(self, resource):"},{"line_number":78,"context_line":"        resource.engine.dispose()"},{"line_number":79,"context_line":"        LOG.info("},{"line_number":80,"context_line":"            \"DROP BACKEND %s TOKEN %s\","},{"line_number":81,"context_line":"            resource.backend.engine, resource.db_token)"},{"line_number":82,"context_line":"        resource.backend.drop_named_database(resource.db_token)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_231dea62","line":80,"updated":"2015-01-06 11:50:56.000000000","message":"ditto","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"64afad0e31fb4b6224ef327fca4560d2a4950d0a","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def drop_additional_objects(self, conn):"},{"line_number":520,"context_line":"        if compat_utils.sqla_100:"},{"line_number":521,"context_line":"            from sqlalchemy import inspect"},{"line_number":522,"context_line":"            enums \u003d [e[\u0027name\u0027] for e in inspect(conn).get_enums()]"},{"line_number":523,"context_line":"        else:"},{"line_number":524,"context_line":"            enums \u003d conn.dialect._load_enums(conn).keys()"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a930d6b_8d198f7b","line":521,"updated":"2015-01-23 14:30:01.000000000","message":"this is redundant. It will work even without this import. \n\njust do: \n\n   enums \u003d [e[\u0027name\u0027] for e in sqlalchemy.inspect(conn).get_enums()]","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"adbea46f0062307264d42c00c076804ee269df63","unresolved":false,"context_lines":[{"line_number":524,"context_line":"Backend._setup()"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"def main(argv\u003dNone):"},{"line_number":528,"context_line":"    \"\"\"Command line interface to create/drop databases."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    ::create: Create test database with random names."}],"source_content_type":"text/x-python","patch_set":24,"id":"da86d52c_b6184876","side":"PARENT","line":527,"updated":"2015-02-04 11:16:57.000000000","message":"While we ended up not using this and I doubt anyone else is using it, maybe we should put a deprecation warning and retain this stuff for some time?","commit_id":"aa6fc4e2bd985c8a115de53f958ad16256a90243"}],"oslo_db/sqlalchemy/test_base.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bb4ad91cf74e93dba4f240a6f250479c35885182","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                    \u0027 test-requirements\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import os"},{"line_number":28,"context_line":"import six"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_db import exception"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_eea666aa","line":27,"updated":"2015-01-06 11:50:56.000000000","message":"should we re-group imports here?","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bb4ad91cf74e93dba4f240a6f250479c35885182","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    Place this in an __init__.py package file within the root of the test"},{"line_number":219,"context_line":"    suite, at the level where testresources loads it as a package::"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        from oslo.db.sqlalchemy import test_base"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        load_tests \u003d test_base.optimize_db_test_loader(__file__)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_633a92ce","line":221,"updated":"2015-01-06 11:50:56.000000000","message":"nit: \n\n from oslo_db.sqlalchemy import test_base","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"}],"oslo_db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"62ca5b530430970fe8672f5ad7108c1ea93c4c2b","unresolved":false,"context_lines":[{"line_number":565,"context_line":"                          \u0027 for running of this test: %s\u0027 % e)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        # drop all tables after a test run"},{"line_number":568,"context_line":"        self.addCleanup(functools.partial(self.db.backend.drop_all_objects,"},{"line_number":569,"context_line":"                                          self.get_engine()))"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        # run migration scripts"}],"source_content_type":"text/x-python","patch_set":24,"id":"da86d52c_a3c1b181","line":568,"updated":"2015-02-12 09:47:59.000000000","message":"nit:\n\n self.addCleanup(self.db.backend.drop_all_objects, self.get_engine())","commit_id":"6ccea346d9609d47b188b33c686f49ce3f4f9b14"}],"oslo_db/tests/sqlalchemy/__init__.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bb4ad91cf74e93dba4f240a6f250479c35885182","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo.db.sqlalchemy import test_base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"load_tests \u003d test_base.optimize_db_test_loader(__file__)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_43f596eb","line":16,"updated":"2015-01-06 11:50:56.000000000","message":"nit:\n\n from oslo_db.sqlalchemy import test_base","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"}],"oslo_db/tests/sqlalchemy/test_provision.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bb4ad91cf74e93dba4f240a6f250479c35885182","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from oslotest import base as oslo_test_base"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sqlalchemy import schema"},{"line_number":17,"context_line":"from sqlalchemy import types"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_e32cc24c","line":14,"updated":"2015-01-06 11:50:56.000000000","message":"nit: this should be in a single imports group with sqlalchemy","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"bb4ad91cf74e93dba4f240a6f250479c35885182","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from sqlalchemy import types"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo.db import exception"},{"line_number":20,"context_line":"from oslo.db.sqlalchemy import provision"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class RetainSchemaTest(oslo_test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a961159_0332aea6","line":20,"updated":"2015-01-06 11:50:56.000000000","message":"s/oslo.db/oslo_db","commit_id":"852d3ba943f68e8d8a98a11a2fb51be40a37bfce"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fcbbe894197a1a0a6679e477907ff64f34fd5c08","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        def gen_schema(engine):"},{"line_number":38,"context_line":"            metadata.create_all(engine, checkfirst\u003dFalse)"},{"line_number":39,"context_line":"        self._gen_schema \u003d gen_schema"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_once(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"da86d52c_ab69168d","line":38,"updated":"2015-02-02 17:22:16.000000000","message":"I assume checkfirst\u003dFalse is passed here to ensure the test would fail, if we tried to recreate the schema","commit_id":"73ad7a46e70a45cecd7a3fddb81a304a4243ebd3"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"e94277581dc31554752e935a01c43195fa05d86a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        def gen_schema(engine):"},{"line_number":38,"context_line":"            metadata.create_all(engine, checkfirst\u003dFalse)"},{"line_number":39,"context_line":"        self._gen_schema \u003d gen_schema"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_once(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"da86d52c_29cd205e","line":38,"in_reply_to":"da86d52c_ab69168d","updated":"2015-02-02 23:13:40.000000000","message":"yes its to ensure that the gen system doesn\u0027t get invoked except on a clean schema.","commit_id":"73ad7a46e70a45cecd7a3fddb81a304a4243ebd3"}],"oslo_db/tests/sqlalchemy/test_sqlalchemy.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fcbbe894197a1a0a6679e477907ff64f34fd5c08","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    def setUp(self):"},{"line_number":231,"context_line":"        super(MySQLModeTestCase, self).setUp()"},{"line_number":232,"context_line":"        mode_engine \u003d session.create_engine("},{"line_number":233,"context_line":"            self.engine.url,"},{"line_number":234,"context_line":"            mysql_sql_mode\u003dself.mysql_mode)"},{"line_number":235,"context_line":"        self.connection \u003d mode_engine.connect()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da86d52c_4bca5a50","line":233,"updated":"2015-02-02 17:22:16.000000000","message":"heh, we overwrote the engine here. good catch!","commit_id":"73ad7a46e70a45cecd7a3fddb81a304a4243ebd3"}],"requirements.txt":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fcbbe894197a1a0a6679e477907ff64f34fd5c08","unresolved":false,"context_lines":[{"line_number":13,"context_line":"sqlalchemy-migrate\u003e\u003d0.9.1,!\u003d0.9.2"},{"line_number":14,"context_line":"stevedore\u003e\u003d1.1.0  # Apache-2.0"},{"line_number":15,"context_line":"six\u003e\u003d1.7.0"},{"line_number":16,"context_line":"testresources\u003e\u003d0.2.4"},{"line_number":17,"context_line":"testscenarios\u003e\u003d0.4"}],"source_content_type":"text/plain","patch_set":23,"id":"da86d52c_f0c13fe5","line":16,"updated":"2015-02-02 17:22:16.000000000","message":"I wonder, if we should treat these dependencies like DBAPI drivers in SQLAlchemy or oslotest in test_base.py, so that projects wouldn\u0027t need to install these two, unless they use our test cases.","commit_id":"73ad7a46e70a45cecd7a3fddb81a304a4243ebd3"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"da28bf409b7834a384e8e581dbf202340812e76f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"sqlalchemy-migrate\u003e\u003d0.9.1,!\u003d0.9.2"},{"line_number":14,"context_line":"stevedore\u003e\u003d1.1.0  # Apache-2.0"},{"line_number":15,"context_line":"six\u003e\u003d1.7.0"},{"line_number":16,"context_line":"testresources\u003e\u003d0.2.4"},{"line_number":17,"context_line":"testscenarios\u003e\u003d0.4"}],"source_content_type":"text/plain","patch_set":23,"id":"da86d52c_db65e51e","line":16,"in_reply_to":"da86d52c_0955bc4f","updated":"2015-02-04 11:04:38.000000000","message":"Kind of :) this might be an overkill, though..","commit_id":"73ad7a46e70a45cecd7a3fddb81a304a4243ebd3"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"e94277581dc31554752e935a01c43195fa05d86a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"sqlalchemy-migrate\u003e\u003d0.9.1,!\u003d0.9.2"},{"line_number":14,"context_line":"stevedore\u003e\u003d1.1.0  # Apache-2.0"},{"line_number":15,"context_line":"six\u003e\u003d1.7.0"},{"line_number":16,"context_line":"testresources\u003e\u003d0.2.4"},{"line_number":17,"context_line":"testscenarios\u003e\u003d0.4"}],"source_content_type":"text/plain","patch_set":23,"id":"da86d52c_0955bc4f","line":16,"in_reply_to":"da86d52c_f0c13fe5","updated":"2015-02-02 23:13:40.000000000","message":"when a project like neutron uses oslo_db, they have it in requirements.txt.  So, if they wanted to use oslo_db.sqlalchemy.test_base in their own tests, they\u0027d....what exactly?   include the dependencies of oslo_db.sqlalchemy.test_base in their own requirements?","commit_id":"73ad7a46e70a45cecd7a3fddb81a304a4243ebd3"}]}
