)]}'
{"oslo_db/sqlalchemy/test_base.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"dfdb3b07b56c228764c3c08e07988f7991d253fb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.test \u003d test"},{"line_number":57,"context_line":"        self.skip_on_unavailable_db \u003d skip_on_unavailable_db"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setUp(self):"},{"line_number":60,"context_line":"        testresources.setUpResources("},{"line_number":61,"context_line":"            self.test, self.test.resources, testresources._get_result())"},{"line_number":62,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c73e74b7","line":59,"updated":"2015-07-09 13:22:25.000000000","message":"what if someone already relies on overriding of setUp() in sub classes?","commit_id":"c7ce2e158c5cad4f78530c3cdf8c0c0c7d064ab9"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"35a834d85bbbba85961e491ddab704cfdc0f03b9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.test \u003d test"},{"line_number":57,"context_line":"        self.skip_on_unavailable_db \u003d skip_on_unavailable_db"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setUp(self):"},{"line_number":60,"context_line":"        testresources.setUpResources("},{"line_number":61,"context_line":"            self.test, self.test.resources, testresources._get_result())"},{"line_number":62,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_ecda494b","line":59,"in_reply_to":"ba3cc151_aecb0471","updated":"2015-07-10 11:26:32.000000000","message":"Sorry, I must haven\u0027t been clear :(\n\nI mean, there might subclasses of DbFixture, which override setUp() for their own purpose and rely on super().setUp() call to execute DbFixture\u0027s set up logic and now that\u0027s not the case anymore.","commit_id":"c7ce2e158c5cad4f78530c3cdf8c0c0c7d064ab9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"aef85a97c3e02b4375be7eabb971a35c013a9859","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.test \u003d test"},{"line_number":57,"context_line":"        self.skip_on_unavailable_db \u003d skip_on_unavailable_db"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setUp(self):"},{"line_number":60,"context_line":"        testresources.setUpResources("},{"line_number":61,"context_line":"            self.test, self.test.resources, testresources._get_result())"},{"line_number":62,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_aecb0471","line":59,"in_reply_to":"ba3cc151_c73e74b7","updated":"2015-07-09 15:22:21.000000000","message":"Fixture.setUp ensures an error in _setUp will trigger registered cleanups:\n\n  def setUp(self):\n    \u003cA\u003e\n    super(self).setUp()\n    \u003cB\u003e\n\nBut an error in in \u003cA\u003e or \u003cB\u003e cannot be catched by Fixture.setUp so no cleanups triggered (which is the behavior without this change) so it breaks nothing!","commit_id":"c7ce2e158c5cad4f78530c3cdf8c0c0c7d064ab9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d028ff3b838efbbc586cbd3a73215004ff0f6d2e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.test \u003d test"},{"line_number":57,"context_line":"        self.skip_on_unavailable_db \u003d skip_on_unavailable_db"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setUp(self):"},{"line_number":60,"context_line":"        testresources.setUpResources("},{"line_number":61,"context_line":"            self.test, self.test.resources, testresources._get_result())"},{"line_number":62,"context_line":"        self.addCleanup("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_e7790284","line":59,"in_reply_to":"ba3cc151_ecda494b","updated":"2015-07-10 11:42:02.000000000","message":"Fixture.setUp calls _setUp so subclasses can still overload setUp (and call super.setUp) but it\u0027s better to overload _setUp as Fixture.setUp ensures to trigger cleanups but not subclasses setUp","commit_id":"c7ce2e158c5cad4f78530c3cdf8c0c0c7d064ab9"}]}