)]}'
{"oslo_db/sqlalchemy/migration_cli/ext_alembic.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"825bb20ad31a707636a0267283849df934f405f2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Since only alembic supports relative revisions, assume the"},{"line_number":101,"context_line":"        # revision belongs to this plugin."},{"line_number":102,"context_line":"        if rev_id:  # rev_id can be None, so the check is required"},{"line_number":103,"context_line":"            has_symbol \u003d set(rev_id).intersection([\u0027-\u0027, \u0027+\u0027])"},{"line_number":104,"context_line":"            if has_symbol:"},{"line_number":105,"context_line":"                return True"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_f4802ec1","line":103,"updated":"2015-08-20 11:23:04.000000000","message":"why not \n\n return \"+\" in rev_id or \"-\" in rev_id\n\n?","commit_id":"b724873542ed9cc7119879b737b26482d9094845"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c449dedaa534c2822cf9a72d7720aafd27da40f4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Since only alembic supports relative revisions, assume the"},{"line_number":101,"context_line":"        # revision belongs to this plugin."},{"line_number":102,"context_line":"        if rev_id:  # rev_id can be None, so the check is required"},{"line_number":103,"context_line":"            has_symbol \u003d set(rev_id).intersection([\u0027-\u0027, \u0027+\u0027])"},{"line_number":104,"context_line":"            if has_symbol:"},{"line_number":105,"context_line":"                return True"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_fa3ed789","line":103,"in_reply_to":"fa1b9901_f4802ec1","updated":"2015-08-20 11:54:40.000000000","message":"I\u0027ve used the regexp used in Alembic and removed this stuff with sets","commit_id":"b724873542ed9cc7119879b737b26482d9094845"}],"oslo_db/tests/sqlalchemy/test_migrate_cli.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"825bb20ad31a707636a0267283849df934f405f2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            self.assertIs(True, self.alembic.has_revision(None))"},{"line_number":109,"context_line":"            self.assertIs(True, self.alembic.has_revision(\u0027head\u0027))"},{"line_number":110,"context_line":"            # relative revision, should be True for alembic"},{"line_number":111,"context_line":"            self.assertIs(True, self.alembic.has_revision(\u0027+1\u0027))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_has_revision_negative(self, command):"},{"line_number":114,"context_line":"        with mock.patch((\u0027oslo_db.sqlalchemy.migration_cli.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_f457ce57","line":111,"updated":"2015-08-20 11:23:04.000000000","message":"nit: self.assertTrue","commit_id":"b724873542ed9cc7119879b737b26482d9094845"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"4c410fa95e517bc1781b4eee3d074a05c66db29c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            self.assertIs(True, self.alembic.has_revision(None))"},{"line_number":109,"context_line":"            self.assertIs(True, self.alembic.has_revision(\u0027head\u0027))"},{"line_number":110,"context_line":"            # relative revision, should be True for alembic"},{"line_number":111,"context_line":"            self.assertIs(True, self.alembic.has_revision(\u0027+1\u0027))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_has_revision_negative(self, command):"},{"line_number":114,"context_line":"        with mock.patch((\u0027oslo_db.sqlalchemy.migration_cli.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_5a8fc329","line":111,"in_reply_to":"fa1b9901_f457ce57","updated":"2015-08-20 11:56:21.000000000","message":"I want to be super accurate here. assertTrue might pass if mock or something else true-ish is returned. I want it to be only True.\n\nAlso, assertIs is used above.","commit_id":"b724873542ed9cc7119879b737b26482d9094845"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"825bb20ad31a707636a0267283849df934f405f2","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            self.assertIs(False, self.migrate.has_revision(\u0027test\u0027))"},{"line_number":202,"context_line":"            mocked.Collection().version.assert_called_once_with(\u0027test\u0027)"},{"line_number":203,"context_line":"            # relative revision, should be False for migrate"},{"line_number":204,"context_line":"            self.assertIs(False, self.migrate.has_revision(\u0027+1\u0027))"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"class TestMigrationManager(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_744c1ec8","line":204,"updated":"2015-08-20 11:23:04.000000000","message":"ditto","commit_id":"b724873542ed9cc7119879b737b26482d9094845"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c449dedaa534c2822cf9a72d7720aafd27da40f4","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            self.assertIs(False, self.migrate.has_revision(\u0027test\u0027))"},{"line_number":202,"context_line":"            mocked.Collection().version.assert_called_once_with(\u0027test\u0027)"},{"line_number":203,"context_line":"            # relative revision, should be False for migrate"},{"line_number":204,"context_line":"            self.assertIs(False, self.migrate.has_revision(\u0027+1\u0027))"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"class TestMigrationManager(test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_3ad52f1b","line":204,"in_reply_to":"fa1b9901_744c1ec8","updated":"2015-08-20 11:54:40.000000000","message":"I use assertIs above and suggest to use assertIs here for consistency.","commit_id":"b724873542ed9cc7119879b737b26482d9094845"}]}
