)]}'
{"oslo_db/api.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"60bd3ae2ef13376418fce08baabb9a5bfe0248fe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def __init__(self, retry_interval\u003d0, max_retries\u003d0, inc_retry_interval\u003d0,"},{"line_number":109,"context_line":"                 max_retry_interval\u003d0, retry_on_disconnect\u003dFalse,"},{"line_number":110,"context_line":"                 retry_on_deadlock\u003dFalse, retry_on_request\u003dFalse,"},{"line_number":111,"context_line":"                 trace_db_errors\u003dTrue, exception_checker\u003dlambda exc: False):"},{"line_number":112,"context_line":"        super(wrap_db_retry, self).__init__()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.db_error \u003d ()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_1845d8b2","line":111,"updated":"2015-09-11 22:18:42.000000000","message":"Another idea should this be a log level instead of a boolean?\n\nPerhaps named:\n\n  db_errors_log_level\u003dlogging.ERROR\n\nOr something...","commit_id":"703cfbca88022c12caf4abc8f927d30890bf9191"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a40efb2b9322b632ca017b18a45c8c4080613e61","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def __init__(self, retry_interval\u003d0, max_retries\u003d0, inc_retry_interval\u003d0,"},{"line_number":109,"context_line":"                 max_retry_interval\u003d0, retry_on_disconnect\u003dFalse,"},{"line_number":110,"context_line":"                 retry_on_deadlock\u003dFalse, retry_on_request\u003dFalse,"},{"line_number":111,"context_line":"                 trace_db_errors\u003dTrue, exception_checker\u003dlambda exc: False):"},{"line_number":112,"context_line":"        super(wrap_db_retry, self).__init__()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.db_error \u003d ()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_983fa8de","line":111,"in_reply_to":"da20952f_1845d8b2","updated":"2015-09-11 22:32:18.000000000","message":"Done","commit_id":"703cfbca88022c12caf4abc8f927d30890bf9191"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"07c6548957ef037a494ebcab8967e3c606f71100","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                if self.trace_db_errors:"},{"line_number":168,"context_line":"                    LOG.exception(_LE(\u0027DB error.\u0027))"},{"line_number":169,"context_line":"                else:"},{"line_number":170,"context_line":"                    LOG.debug(\"Retrying DB error. %s\", exc)"},{"line_number":171,"context_line":"            return True"},{"line_number":172,"context_line":"        return self.exception_checker(exc)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_98300857","line":170,"updated":"2015-09-11 22:17:47.000000000","message":"Do u still want the stack trace?\n\nIf so:\n\n  LOG.debug(\"Retrying DB error. %s\", exc_info\u003dTrue)","commit_id":"703cfbca88022c12caf4abc8f927d30890bf9191"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a40efb2b9322b632ca017b18a45c8c4080613e61","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                if self.trace_db_errors:"},{"line_number":168,"context_line":"                    LOG.exception(_LE(\u0027DB error.\u0027))"},{"line_number":169,"context_line":"                else:"},{"line_number":170,"context_line":"                    LOG.debug(\"Retrying DB error. %s\", exc)"},{"line_number":171,"context_line":"            return True"},{"line_number":172,"context_line":"        return self.exception_checker(exc)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d849a08f","line":170,"in_reply_to":"da20952f_98300857","updated":"2015-09-11 22:32:18.000000000","message":"Done","commit_id":"703cfbca88022c12caf4abc8f927d30890bf9191"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"21e6c5fde3f6d6d5ff4a61be551dee37e0e9bd2c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def __init__(self, retry_interval\u003d0, max_retries\u003d0, inc_retry_interval\u003d0,"},{"line_number":109,"context_line":"                 max_retry_interval\u003d0, retry_on_disconnect\u003dFalse,"},{"line_number":110,"context_line":"                 retry_on_deadlock\u003dFalse, retry_on_request\u003dFalse,"},{"line_number":111,"context_line":"                 trace_db_error_level\u003dLOG.exception,"},{"line_number":112,"context_line":"                 exception_checker\u003dlambda exc: False):"},{"line_number":113,"context_line":"        super(wrap_db_retry, self).__init__()"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_bbd8ec1e","line":111,"updated":"2015-09-14 15:46:04.000000000","message":"Hmmm, I\u0027d prefer this be the logging level vs the function itself.\n\nBut if u are going to keep providing a function then I\u0027d rather have the name of this argument be something different (because a function isn\u0027t really a logging level).\n\nPerhaps do this:\n\n  trace_db_error_level\u003dlogging.ERROR\n\nThen later:\n\n  LOG.log(self.trace_db_error_level, \u0027DB error.\u0027, exc_info\u003dTrue)\n\nThe above should be equivalent to what LOG.exception is doing internally anyway:\n\nhttps://github.com/python-git/python/blob/master/Lib/logging/__init__.py#L1058","commit_id":"3ec351932200e51b42b6691e8d6b299c7623eaa6"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f0d4dbd97fa5403f967af5884f6eb3ba95213e12","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def __init__(self, retry_interval\u003d0, max_retries\u003d0, inc_retry_interval\u003d0,"},{"line_number":109,"context_line":"                 max_retry_interval\u003d0, retry_on_disconnect\u003dFalse,"},{"line_number":110,"context_line":"                 retry_on_deadlock\u003dFalse, retry_on_request\u003dFalse,"},{"line_number":111,"context_line":"                 trace_db_error_level\u003dLOG.exception,"},{"line_number":112,"context_line":"                 exception_checker\u003dlambda exc: False):"},{"line_number":113,"context_line":"        super(wrap_db_retry, self).__init__()"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_d4024d3e","line":111,"in_reply_to":"ba15a1d1_bbd8ec1e","updated":"2015-09-14 16:45:36.000000000","message":"++, I like Joshua\u0027s idea on passing the log level","commit_id":"3ec351932200e51b42b6691e8d6b299c7623eaa6"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"6369d2e8cbdc7aaa5a294f7698c778d0f992e5cd","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def __init__(self, retry_interval\u003d0, max_retries\u003d0, inc_retry_interval\u003d0,"},{"line_number":109,"context_line":"                 max_retry_interval\u003d0, retry_on_disconnect\u003dFalse,"},{"line_number":110,"context_line":"                 retry_on_deadlock\u003dFalse, retry_on_request\u003dFalse,"},{"line_number":111,"context_line":"                 trace_db_error_level\u003dLOG.exception,"},{"line_number":112,"context_line":"                 exception_checker\u003dlambda exc: False):"},{"line_number":113,"context_line":"        super(wrap_db_retry, self).__init__()"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_54b339e9","line":111,"in_reply_to":"ba15a1d1_d4024d3e","updated":"2015-09-16 15:26:12.000000000","message":"+1","commit_id":"3ec351932200e51b42b6691e8d6b299c7623eaa6"}]}