)]}'
{"oslo_db/api.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cac8432beb3c036bec91e0a3621a2e55a099abad","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                # We got an unexpected exception so stop"},{"line_number":144,"context_line":"                                # retrying, log it and raise it up to the"},{"line_number":145,"context_line":"                                # caller."},{"line_number":146,"context_line":"                                LOG.exception(_LE(\u0027DB error.\u0027))"},{"line_number":147,"context_line":"                        else:"},{"line_number":148,"context_line":"                            LOG.exception(_LE(\u0027DB exceeded retry limit.\u0027))"},{"line_number":149,"context_line":"                            # if it\u0027s a RetryRequest, we need to unpack it"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_20add29a","line":146,"updated":"2015-12-08 21:37:21.000000000","message":"I wonder if this one is even necessary. Maybe it should be completely left up to the caller to determine if an exception is bad enough to dump into the log?","commit_id":"838e314a21fef9ca6cf99140b2400e0d3b68b109"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cacf73373b056b062aaf82bcc03a606b0d6af21e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                # We got an unexpected exception so stop"},{"line_number":144,"context_line":"                                # retrying, log it and raise it up to the"},{"line_number":145,"context_line":"                                # caller."},{"line_number":146,"context_line":"                                LOG.exception(_LE(\u0027DB error.\u0027))"},{"line_number":147,"context_line":"                        else:"},{"line_number":148,"context_line":"                            LOG.exception(_LE(\u0027DB exceeded retry limit.\u0027))"},{"line_number":149,"context_line":"                            # if it\u0027s a RetryRequest, we need to unpack it"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_8eacf78c","line":146,"in_reply_to":"7a740942_20add29a","updated":"2015-12-08 22:19:59.000000000","message":"I guess I don\u0027t have a strong preference. Nova doesn\u0027t do a lot of LOG.exception, so I\u0027m not even sure how this is logged in nova when we have a retry failure on deadlock. As it\u0027s a decorator in DB API methods, we hopefully just process the error at a high enough level and log it (but not guaranteed).  In any case, this is probably a 500 response to a user if we had a DBDeadlock.\n\nAlso, if we removed the error tracing here, I\u0027d probably also be consistent and do it below, which I think of think should be a separate change.","commit_id":"838e314a21fef9ca6cf99140b2400e0d3b68b109"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a1fa85c0a55b66b93f2b29f68749d21b3a79fbe0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                # We got an unexpected exception so stop"},{"line_number":144,"context_line":"                                # retrying, log it and raise it up to the"},{"line_number":145,"context_line":"                                # caller."},{"line_number":146,"context_line":"                                LOG.exception(_LE(\u0027DB error.\u0027))"},{"line_number":147,"context_line":"                        else:"},{"line_number":148,"context_line":"                            LOG.exception(_LE(\u0027DB exceeded retry limit.\u0027))"},{"line_number":149,"context_line":"                            # if it\u0027s a RetryRequest, we need to unpack it"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_4e34cffa","line":146,"in_reply_to":"7a740942_8eacf78c","updated":"2015-12-08 22:30:51.000000000","message":"Sounds good. Follow up later if it becomes an issue.","commit_id":"838e314a21fef9ca6cf99140b2400e0d3b68b109"}]}
