)]}'
{"oslo_db/sqlalchemy/exc_filters.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cfaec56a26e4518e3fccb47e18c42705d43ad409","unresolved":false,"context_lines":[{"line_number":281,"context_line":"@filters(\"mysql\", sqla_exc.DataError,"},{"line_number":282,"context_line":"         r\".*1264.*Out of range value for column.*\")"},{"line_number":283,"context_line":"@filters(\"mysql\", sqla_exc.InternalError,"},{"line_number":284,"context_line":"         r\"^.*\\b1366\\b.*Incorrect string value.*\")"},{"line_number":285,"context_line":"def _raise_data_error(error, match, engine_name, is_disconnect):"},{"line_number":286,"context_line":"    \"\"\"Raise DBDataError exception for different data errors.\"\"\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_25443048","line":284,"updated":"2016-01-11 20:18:23.000000000","message":"In this case, it\u0027s \"value:\" instead of \"value.\"","commit_id":"81c0b7fdb7823a3a6db90f1938b75d3a3a789023"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"12d61501c78f8c3423c7afaacb6b63649d863cd8","unresolved":false,"context_lines":[{"line_number":281,"context_line":"@filters(\"mysql\", sqla_exc.DataError,"},{"line_number":282,"context_line":"         r\".*1264.*Out of range value for column.*\")"},{"line_number":283,"context_line":"@filters(\"mysql\", sqla_exc.InternalError,"},{"line_number":284,"context_line":"         r\"^.*\\b1366\\b.*Incorrect string value:*\")"},{"line_number":285,"context_line":"def _raise_data_error(error, match, engine_name, is_disconnect):"},{"line_number":286,"context_line":"    \"\"\"Raise DBDataError exception for different data errors.\"\"\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4824db0b","line":284,"updated":"2016-01-11 21:00:14.000000000","message":"The pattern seems to be correct - I checked it against the error message in the bug description. Although, I\u0027d prefer it to look like patterns above for the sake of consistency (not sure why : is important and why it can\u0027t be .* and if we really need \\b)","commit_id":"71343139846ac2e228b3d9a62c8149fb6a47ae7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b749b384addf3ebfac90b46c7a3e3244d15467fd","unresolved":false,"context_lines":[{"line_number":281,"context_line":"@filters(\"mysql\", sqla_exc.DataError,"},{"line_number":282,"context_line":"         r\".*1264.*Out of range value for column.*\")"},{"line_number":283,"context_line":"@filters(\"mysql\", sqla_exc.InternalError,"},{"line_number":284,"context_line":"         r\"^.*\\b1366\\b.*Incorrect string value:*\")"},{"line_number":285,"context_line":"def _raise_data_error(error, match, engine_name, is_disconnect):"},{"line_number":286,"context_line":"    \"\"\"Raise DBDataError exception for different data errors.\"\"\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_f5d9c4f3","line":284,"in_reply_to":"da6ed579_48ec7b8f","updated":"2016-01-25 16:50:20.000000000","message":"Done","commit_id":"71343139846ac2e228b3d9a62c8149fb6a47ae7e"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"75b710dd83b958ef88fbb8c5bf1be79b1edeaa51","unresolved":false,"context_lines":[{"line_number":281,"context_line":"@filters(\"mysql\", sqla_exc.DataError,"},{"line_number":282,"context_line":"         r\".*1264.*Out of range value for column.*\")"},{"line_number":283,"context_line":"@filters(\"mysql\", sqla_exc.InternalError,"},{"line_number":284,"context_line":"         r\"^.*\\b1366\\b.*Incorrect string value:*\")"},{"line_number":285,"context_line":"def _raise_data_error(error, match, engine_name, is_disconnect):"},{"line_number":286,"context_line":"    \"\"\"Raise DBDataError exception for different data errors.\"\"\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_48ec7b8f","line":284,"in_reply_to":"da6ed579_af9806c1","updated":"2016-01-17 07:33:28.000000000","message":"That would be nice, but I don\u0027t think that would work due to InternalError vs Operational error and the way we use the exception type here: https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/exc_filters.py#L35-L53\n\nSo looks like we need to separate these.","commit_id":"71343139846ac2e228b3d9a62c8149fb6a47ae7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8def1ac0c2e9925da4a7749a063f8fd095add0ce","unresolved":false,"context_lines":[{"line_number":281,"context_line":"@filters(\"mysql\", sqla_exc.DataError,"},{"line_number":282,"context_line":"         r\".*1264.*Out of range value for column.*\")"},{"line_number":283,"context_line":"@filters(\"mysql\", sqla_exc.InternalError,"},{"line_number":284,"context_line":"         r\"^.*\\b1366\\b.*Incorrect string value:*\")"},{"line_number":285,"context_line":"def _raise_data_error(error, match, engine_name, is_disconnect):"},{"line_number":286,"context_line":"    \"\"\"Raise DBDataError exception for different data errors.\"\"\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_af9806c1","line":284,"in_reply_to":"fa69d971_4824db0b","updated":"2016-01-14 17:13:16.000000000","message":"Should I expand the top regex here to cover this case instead of adding a new regex?","commit_id":"71343139846ac2e228b3d9a62c8149fb6a47ae7e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7b6648c1e6af003d51f852f9eb8316475a112141","unresolved":false,"context_lines":[{"line_number":281,"context_line":"@filters(\"mysql\", sqla_exc.DataError,"},{"line_number":282,"context_line":"         r\".*1264.*Out of range value for column.*\")"},{"line_number":283,"context_line":"@filters(\"mysql\", sqla_exc.InternalError,"},{"line_number":284,"context_line":"         r\"^.*1366.*Incorrect string value:*\")"},{"line_number":285,"context_line":"def _raise_data_error(error, match, engine_name, is_disconnect):"},{"line_number":286,"context_line":"    \"\"\"Raise DBDataError exception for different data errors.\"\"\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_bf1a927b","line":284,"updated":"2016-01-29 21:09:31.000000000","message":"Does the full error message actually explain what is wrong with the string? If not, we should use a new function so we can raise a message of our own with a suggested reason for the error.","commit_id":"0a2881e9f5966bf0763d9613442eba2e80fa86e3"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"752c3a7baf0fe29a9b6f4dc94ef3e0be352f0e25","unresolved":false,"context_lines":[{"line_number":281,"context_line":"@filters(\"mysql\", sqla_exc.DataError,"},{"line_number":282,"context_line":"         r\".*1264.*Out of range value for column.*\")"},{"line_number":283,"context_line":"@filters(\"mysql\", sqla_exc.InternalError,"},{"line_number":284,"context_line":"         r\"^.*1366.*Incorrect string value:*\")"},{"line_number":285,"context_line":"def _raise_data_error(error, match, engine_name, is_disconnect):"},{"line_number":286,"context_line":"    \"\"\"Raise DBDataError exception for different data errors.\"\"\""},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_308c8fd9","line":284,"in_reply_to":"7a5de9d1_bf1a927b","updated":"2016-01-29 22:29:46.000000000","message":"the message itself indicates the value, as well as the datatype which might not be string, so we might consider catching that as well:  https://dev.mysql.com/doc/refman/5.5/en/error-messages-server.html#error_er_truncated_wrong_value_for_field \" Incorrect %s value: \u0027%s\u0027 for column \u0027%s\u0027 at row %ld \".   If this information was not in the message, there would not be a straightforward way of deriving the erroneous value since it can correspond to a SQL statement that has many parameters.","commit_id":"0a2881e9f5966bf0763d9613442eba2e80fa86e3"}]}