)]}'
{"oslo_db/sqlalchemy/migration.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f575135ee31c4637d31b4d68158d3d5988a11d27","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        meta \u003d sqlalchemy.MetaData()"},{"line_number":129,"context_line":"        meta.reflect(bind\u003dengine)"},{"line_number":130,"context_line":"        tables \u003d meta.tables"},{"line_number":131,"context_line":"        if (len(tables) \u003d\u003d 0 or \u0027alembic_version\u0027 in tables or"},{"line_number":132,"context_line":"                \u0027migrate_version\u0027 in tables):"},{"line_number":133,"context_line":"            db_version_control(engine, abs_path, version\u003dinit_version)"},{"line_number":134,"context_line":"            return versioning_api.db_version(engine, repository)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_07d08c1e","line":131,"updated":"2016-05-19 13:25:03.000000000","message":"Is this specifically for this case when you have multiple migration repos which all create tables in the same DB?\n\nDoes this conditional even make sense if we now ignore the presence of other tables if they were created by alembic / another migrate repo?\n\nI wonder if we should just drop it and allow putting a DB under version control with existing tables. Maybe issuing a warning in that case.","commit_id":"8eda40da25da2a05c19f9e68a3973986e4a38320"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"618ddddb7cd09e56546911690773e927cb1e08b7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        meta \u003d sqlalchemy.MetaData()"},{"line_number":129,"context_line":"        meta.reflect(bind\u003dengine)"},{"line_number":130,"context_line":"        tables \u003d meta.tables"},{"line_number":131,"context_line":"        if (len(tables) \u003d\u003d 0 or \u0027alembic_version\u0027 in tables or"},{"line_number":132,"context_line":"                \u0027migrate_version\u0027 in tables):"},{"line_number":133,"context_line":"            db_version_control(engine, abs_path, version\u003dinit_version)"},{"line_number":134,"context_line":"            return versioning_api.db_version(engine, repository)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_cab5ebee","line":131,"in_reply_to":"bab6814e_07d08c1e","updated":"2016-05-19 13:41:04.000000000","message":"Keystone has multiple migration repos which all create tables in the same DB. See:\n\nhttp://git.openstack.org/cgit/openstack/keystone/tree/keystone/contrib/federation/migrate_repo/versions\n\nand\n\nhttp://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/sql/migrate_repo/versions\n\nThe change is proposed because db_version wasn\u0027t working consistently.\n\nI\u0027m willing to change this to work either way.","commit_id":"8eda40da25da2a05c19f9e68a3973986e4a38320"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fabd467f93f38dd0462357747f20ca5410a2e28f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        meta \u003d sqlalchemy.MetaData()"},{"line_number":129,"context_line":"        meta.reflect(bind\u003dengine)"},{"line_number":130,"context_line":"        tables \u003d meta.tables"},{"line_number":131,"context_line":"        if (len(tables) \u003d\u003d 0 or \u0027alembic_version\u0027 in tables or"},{"line_number":132,"context_line":"                \u0027migrate_version\u0027 in tables):"},{"line_number":133,"context_line":"            db_version_control(engine, abs_path, version\u003dinit_version)"},{"line_number":134,"context_line":"            return versioning_api.db_version(engine, repository)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_127e1eae","line":131,"in_reply_to":"bab6814e_4d4ea03b","updated":"2017-03-02 13:42:55.000000000","message":"After revisiting this again, ^ seems to be an overkill, let\u0027s just make it work consistently.","commit_id":"8eda40da25da2a05c19f9e68a3973986e4a38320"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b5993506e057703ed69b310e3d00a5faa32e6985","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        meta \u003d sqlalchemy.MetaData()"},{"line_number":129,"context_line":"        meta.reflect(bind\u003dengine)"},{"line_number":130,"context_line":"        tables \u003d meta.tables"},{"line_number":131,"context_line":"        if (len(tables) \u003d\u003d 0 or \u0027alembic_version\u0027 in tables or"},{"line_number":132,"context_line":"                \u0027migrate_version\u0027 in tables):"},{"line_number":133,"context_line":"            db_version_control(engine, abs_path, version\u003dinit_version)"},{"line_number":134,"context_line":"            return versioning_api.db_version(engine, repository)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_4d4ea03b","line":131,"in_reply_to":"bab6814e_cab5ebee","updated":"2016-05-23 16:45:22.000000000","message":"Ok. How about we add a new parameter `strict` that will default to False. When it\u0027s True, db_version() will only try to put a DB under a version control if there are *no* tables?\n\nIf it\u0027s False (by default) db_version() will put the DB under version control, regardless of the fact if there are tables or not (including \"special\" tables like \"alembic_version\" or \"migrate_version\").\n\nAs is we don\u0027t account for the case of multiple migrations repos for the same DB, which migrate supports.","commit_id":"8eda40da25da2a05c19f9e68a3973986e4a38320"}]}