)]}'
{"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"087ae763ea1a130307b192621e78b2d297a66ff1","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if \u0027id\u0027 not in sort_keys:"},{"line_number":105,"context_line":"        # TODO(justinsb): If this ever gives a false-positive, check"},{"line_number":106,"context_line":"        # the actual primary key, rather than assuming its id"},{"line_number":107,"context_line":"        LOG.warning(_LW(\u0027Id not in sort_keys; is sort_keys unique?\u0027))"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_589b2766","side":"PARENT","line":105,"updated":"2016-06-08 15:37:33.000000000","message":"why wouldn\u0027t we want to actually do this?   are we paginating on unique keys that aren\u0027t primary key too ?","commit_id":"5484a4e86612d9b29c4aab260bc98ad41b8c70e2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"49cf1a626c9295703ad2558e2db9c8b09ff00a95","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if \u0027id\u0027 not in sort_keys:"},{"line_number":105,"context_line":"        # TODO(justinsb): If this ever gives a false-positive, check"},{"line_number":106,"context_line":"        # the actual primary key, rather than assuming its id"},{"line_number":107,"context_line":"        LOG.warning(_LW(\u0027Id not in sort_keys; is sort_keys unique?\u0027))"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_630bed8e","side":"PARENT","line":105,"in_reply_to":"3aaa91ec_c910b6ae","updated":"2016-08-29 13:45:07.000000000","message":"I have a fix for that: https://review.openstack.org/#/c/362061/1","commit_id":"5484a4e86612d9b29c4aab260bc98ad41b8c70e2"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a7ba844d556d86bd1ba68a594d10137383ce7940","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if \u0027id\u0027 not in sort_keys:"},{"line_number":105,"context_line":"        # TODO(justinsb): If this ever gives a false-positive, check"},{"line_number":106,"context_line":"        # the actual primary key, rather than assuming its id"},{"line_number":107,"context_line":"        LOG.warning(_LW(\u0027Id not in sort_keys; is sort_keys unique?\u0027))"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_c910b6ae","side":"PARENT","line":105,"in_reply_to":"3aaa91ec_e97f7264","updated":"2016-06-27 14:38:26.000000000","message":"that\u0027s totally doable.  but it\u0027s just a PITA to come up with :).","commit_id":"5484a4e86612d9b29c4aab260bc98ad41b8c70e2"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"e687dd238523ee2052a37b8c14b8c9522675202d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if \u0027id\u0027 not in sort_keys:"},{"line_number":105,"context_line":"        # TODO(justinsb): If this ever gives a false-positive, check"},{"line_number":106,"context_line":"        # the actual primary key, rather than assuming its id"},{"line_number":107,"context_line":"        LOG.warning(_LW(\u0027Id not in sort_keys; is sort_keys unique?\u0027))"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e97f7264","side":"PARENT","line":105,"in_reply_to":"7aa08908_589b2766","updated":"2016-06-27 14:35:50.000000000","message":"I believe, we do. At least based on the signature and docs of paginate_query() it should be possible.\n\nCan we maybe come up with a better check here and use the info from the metadata to understand whether there\u0027s a corresponding UNIQUE constraint or not? (just based on the models metadata, no reflection :) )","commit_id":"5484a4e86612d9b29c4aab260bc98ad41b8c70e2"}]}
