)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"0f5b4d21112c29aacdf381495f20e0aeebf2db28","unresolved":false,"context_lines":[{"line_number":15,"context_line":"to prevent usage of stale connections that may have been closed by"},{"line_number":16,"context_line":"server-side reapers."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"WIP: trying to get oslo.config to do something"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I5e39d5ac81eaa8d85b1dfb18862fe27695ab8b96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f436f4f_7706c822","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":46},"updated":"2017-08-15 11:33:55.000000000","message":"what do you mean ?","commit_id":"d07b1ff7048ed30110f5d7c29a47f28c3010f1c7"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"1fa847a7ac6119cb9838098329dd2187fb45668c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"to prevent usage of stale connections that may have been closed by"},{"line_number":16,"context_line":"server-side reapers."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"WIP: trying to get oslo.config to do something"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I5e39d5ac81eaa8d85b1dfb18862fe27695ab8b96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f436f4f_f1a6400f","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":46},"in_reply_to":"9f436f4f_7706c822","updated":"2017-08-15 14:29:30.000000000","message":"was referring to http://lists.openstack.org/pipermail/openstack-dev/2017-July/119843.html.   as the tests seem to pass on this I will take that out.","commit_id":"d07b1ff7048ed30110f5d7c29a47f28c3010f1c7"}],"oslo_db/options.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"5f9a3844f9cb7520aa2eb48f989c211d8946a31e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.IntOpt(\u0027connection_recycle_time\u0027,"},{"line_number":52,"context_line":"               default\u003d3600,"},{"line_number":53,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027idle_timeout\u0027,"},{"line_number":54,"context_line":"                                                  group\u003d\"DATABASE\"),"},{"line_number":55,"context_line":"                                cfg.DeprecatedOpt(\u0027idle_timeout\u0027,"},{"line_number":56,"context_line":"                                                  group\u003d\"database\"),"},{"line_number":57,"context_line":"                                cfg.DeprecatedOpt(\u0027sql_idle_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_4e71db43","line":54,"updated":"2017-07-18 15:10:00.000000000","message":"I don\u0027t understand what \"group\" is; I see the deprecated opts all have \"DATABASE\" uppercase, then neutron failed as its config in tempest uses \"database\" lowercase; why is there a \"group\" in DeprecatedOpt at all, the \"main\" variable names specify no \"group\" at all.   Just guessing here to make the gate pass.","commit_id":"cb1ccb1b69b5bc1f3f927a5f18e2d2be02de11b5"}],"oslo_db/sqlalchemy/enginefacade.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"09e4907b48a35ce7982bc98419b7378af739a6f0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self._engine_cfg \u003d {"},{"line_number":134,"context_line":"            \u0027sqlite_fk\u0027: _Default(False),"},{"line_number":135,"context_line":"            \u0027mysql_sql_mode\u0027: _Default(\u0027TRADITIONAL\u0027),"},{"line_number":136,"context_line":"            \u0027connection_recycle_time\u0027: _Default(3600),"},{"line_number":137,"context_line":"            \u0027connection_debug\u0027: _Default(0),"},{"line_number":138,"context_line":"            \u0027max_pool_size\u0027: _Default(),"},{"line_number":139,"context_line":"            \u0027max_overflow\u0027: _Default(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_87ee95b2","line":136,"updated":"2016-06-27 15:04:09.000000000","message":"shouldn\u0027t we have both the new and the old name here for the sake of backwards compatibility?","commit_id":"6d08775ca1bacd9565ea6954202678691da6f026"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"e3393f11d072e1b4da2b48a48228bceab3f27173","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self._engine_cfg \u003d {"},{"line_number":134,"context_line":"            \u0027sqlite_fk\u0027: _Default(False),"},{"line_number":135,"context_line":"            \u0027mysql_sql_mode\u0027: _Default(\u0027TRADITIONAL\u0027),"},{"line_number":136,"context_line":"            \u0027connection_recycle_time\u0027: _Default(3600),"},{"line_number":137,"context_line":"            \u0027connection_debug\u0027: _Default(0),"},{"line_number":138,"context_line":"            \u0027max_pool_size\u0027: _Default(),"},{"line_number":139,"context_line":"            \u0027max_overflow\u0027: _Default(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_e8cfe87c","line":136,"in_reply_to":"3aaa91ec_229eaf07","updated":"2016-06-29 15:56:46.000000000","message":"I\u0027m afraid, yes. At least Nova:\n\nhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L80-L110\n\nI think we only allow passing of these options directly in EngineFacade\u0027s (both the new and the legacy one). \n\nThis must be the first option name change since the facades were introduced. Previously we relied on the oslo.config and its deprecation mechanism. But looks like we need a bit more work here.","commit_id":"6d08775ca1bacd9565ea6954202678691da6f026"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"f04e01c14f163baf8ad780672ca5d38bc757ec71","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self._engine_cfg \u003d {"},{"line_number":134,"context_line":"            \u0027sqlite_fk\u0027: _Default(False),"},{"line_number":135,"context_line":"            \u0027mysql_sql_mode\u0027: _Default(\u0027TRADITIONAL\u0027),"},{"line_number":136,"context_line":"            \u0027connection_recycle_time\u0027: _Default(3600),"},{"line_number":137,"context_line":"            \u0027connection_debug\u0027: _Default(0),"},{"line_number":138,"context_line":"            \u0027max_pool_size\u0027: _Default(),"},{"line_number":139,"context_line":"            \u0027max_overflow\u0027: _Default(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_229eaf07","line":136,"in_reply_to":"3aaa91ec_87ee95b2","updated":"2016-06-27 15:23:54.000000000","message":"maybe.  How have we done all the other name changes in oslo_db.options?   Are people calling upon this option directly here and not via CONF ?","commit_id":"6d08775ca1bacd9565ea6954202678691da6f026"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"09e4907b48a35ce7982bc98419b7378af739a6f0","unresolved":false,"context_lines":[{"line_number":967,"context_line":"            exception.OsloDBDeprecationWarning,"},{"line_number":968,"context_line":"            stacklevel\u003d2)"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        if \u0027idle_timeout\u0027 in kwargs:"},{"line_number":971,"context_line":"            kwargs[\u0027connection_recycle_time\u0027] \u003d kwargs.pop(\u0027idle_timeout\u0027)"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"        if _factory:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_075e2576","line":970,"updated":"2016-06-27 15:04:09.000000000","message":"maybe put a comment here, that this is an old argument name?","commit_id":"6d08775ca1bacd9565ea6954202678691da6f026"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"0f5b4d21112c29aacdf381495f20e0aeebf2db28","unresolved":false,"context_lines":[{"line_number":1230,"context_line":"            \"oslo_db.sqlalchemy.enginefacade\","},{"line_number":1231,"context_line":"            exception.OsloDBDeprecationWarning,"},{"line_number":1232,"context_line":"            stacklevel\u003d2)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        if _factory:"},{"line_number":1235,"context_line":"            self._factory \u003d _factory"},{"line_number":1236,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_171adcca","side":"PARENT","line":1233,"updated":"2017-08-15 11:33:55.000000000","message":"unrelated change","commit_id":"92c5091d4c199ef18a8a3572e22ac6870af17c0c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"0f5b4d21112c29aacdf381495f20e0aeebf2db28","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        :param mysql_enable_ndb: enable MySQL Cluster (NDB) support"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        :param idle_timeout: connection pool recycle time,"},{"line_number":216,"context_line":"         defaults to 3600. Note the connection does not actually have to"},{"line_number":217,"context_line":"         be \"idle\" to be recycled."},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_57de24da","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":27},"updated":"2017-08-15 11:33:55.000000000","message":"need change to connection_recycle_time","commit_id":"d07b1ff7048ed30110f5d7c29a47f28c3010f1c7"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"1fa847a7ac6119cb9838098329dd2187fb45668c","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        :param mysql_enable_ndb: enable MySQL Cluster (NDB) support"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        :param idle_timeout: connection pool recycle time,"},{"line_number":216,"context_line":"         defaults to 3600. Note the connection does not actually have to"},{"line_number":217,"context_line":"         be \"idle\" to be recycled."},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_b1955889","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":27},"in_reply_to":"9f436f4f_57de24da","updated":"2017-08-15 14:29:30.000000000","message":"Done","commit_id":"d07b1ff7048ed30110f5d7c29a47f28c3010f1c7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"077c39fa8c46181fda6a1cb4b10f06c199e42baf","unresolved":false,"context_lines":[{"line_number":1230,"context_line":"            \"oslo_db.sqlalchemy.enginefacade\","},{"line_number":1231,"context_line":"            exception.OsloDBDeprecationWarning,"},{"line_number":1232,"context_line":"            stacklevel\u003d2)"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        if _factory:"},{"line_number":1235,"context_line":"            self._factory \u003d _factory"},{"line_number":1236,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f436f4f_fc49f55f","side":"PARENT","line":1233,"updated":"2017-08-21 06:32:25.000000000","message":"meh, unrelated whitespace :)","commit_id":"92c5091d4c199ef18a8a3572e22ac6870af17c0c"}],"oslo_db/sqlalchemy/engines.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"09e4907b48a35ce7982bc98419b7378af739a6f0","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def create_engine(sql_connection, sqlite_fk\u003dFalse, mysql_sql_mode\u003dNone,"},{"line_number":105,"context_line":"                  connection_recycle_time\u003d3600,"},{"line_number":106,"context_line":"                  connection_debug\u003d0, max_pool_size\u003dNone, max_overflow\u003dNone,"},{"line_number":107,"context_line":"                  pool_timeout\u003dNone, sqlite_synchronous\u003dTrue,"},{"line_number":108,"context_line":"                  connection_trace\u003dFalse, max_retries\u003d10, retry_interval\u003d10,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4722ed02","line":105,"updated":"2016-06-27 15:04:09.000000000","message":"ditto","commit_id":"6d08775ca1bacd9565ea6954202678691da6f026"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"e3393f11d072e1b4da2b48a48228bceab3f27173","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def create_engine(sql_connection, sqlite_fk\u003dFalse, mysql_sql_mode\u003dNone,"},{"line_number":105,"context_line":"                  connection_recycle_time\u003d3600,"},{"line_number":106,"context_line":"                  connection_debug\u003d0, max_pool_size\u003dNone, max_overflow\u003dNone,"},{"line_number":107,"context_line":"                  pool_timeout\u003dNone, sqlite_synchronous\u003dTrue,"},{"line_number":108,"context_line":"                  connection_trace\u003dFalse, max_retries\u003d10, retry_interval\u003d10,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_08ed14b7","line":105,"in_reply_to":"3aaa91ec_42ac9b35","updated":"2016-06-29 15:56:46.000000000","message":"I believe, we have not. Yep, looks like we should provide **kw.","commit_id":"6d08775ca1bacd9565ea6954202678691da6f026"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"f04e01c14f163baf8ad780672ca5d38bc757ec71","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def create_engine(sql_connection, sqlite_fk\u003dFalse, mysql_sql_mode\u003dNone,"},{"line_number":105,"context_line":"                  connection_recycle_time\u003d3600,"},{"line_number":106,"context_line":"                  connection_debug\u003d0, max_pool_size\u003dNone, max_overflow\u003dNone,"},{"line_number":107,"context_line":"                  pool_timeout\u003dNone, sqlite_synchronous\u003dTrue,"},{"line_number":108,"context_line":"                  connection_trace\u003dFalse, max_retries\u003d10, retry_interval\u003d10,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_42ac9b35","line":105,"in_reply_to":"3aaa91ec_4722ed02","updated":"2016-06-27 15:23:54.000000000","message":"so we\u0027ve never changed any of these names before? otherwise there\u0027d be a **kw here being used to catch them (that\u0027s how I\u0027d do that here).","commit_id":"6d08775ca1bacd9565ea6954202678691da6f026"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"0f5b4d21112c29aacdf381495f20e0aeebf2db28","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Core SQLAlchemy connectivity routines."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import debtcollector.renames"},{"line_number":20,"context_line":"import itertools"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_b7b43081","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":28},"updated":"2017-08-15 11:33:55.000000000","message":"need move into line 26","commit_id":"d07b1ff7048ed30110f5d7c29a47f28c3010f1c7"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"1fa847a7ac6119cb9838098329dd2187fb45668c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Core SQLAlchemy connectivity routines."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import debtcollector.renames"},{"line_number":20,"context_line":"import itertools"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_1140a406","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":28},"in_reply_to":"9f436f4f_b7b43081","updated":"2017-08-15 14:29:30.000000000","message":"Done","commit_id":"d07b1ff7048ed30110f5d7c29a47f28c3010f1c7"}]}