)]}'
{"oslo_db/options.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"4ad307be579486beb61e295bd7d03944c3ec69e6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":32,"context_line":"                    \u0027the database.\u0027,"},{"line_number":33,"context_line":"               secret\u003dTrue,"},{"line_number":34,"context_line":"               required\u003dTrue,"},{"line_number":35,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027sql_connection\u0027,"},{"line_number":36,"context_line":"                                                  group\u003d\u0027DEFAULT\u0027),"},{"line_number":37,"context_line":"                                cfg.DeprecatedOpt(\u0027sql_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b0a48057","line":34,"updated":"2016-07-04 14:02:24.000000000","message":"Won\u0027t this make all the downstream projects to fail on start, if ``connection`` is not set in the config file?\n\nI\u0027d expect them to be able to use parts of oslo.db, e.g. http://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/sqlalchemy/utils.py  or http://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/sqlalchemy/update_match.py , which are usable on their own, EngineFacade or any of the config options are not required for that.","commit_id":"579551ed61ea3f19a0a51584d24e1384b68c45c1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8ca63382ee53994bb7f6fafbd948937966ba1239","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               help\u003d\u0027The SQLAlchemy connection string to use to connect to \u0027"},{"line_number":32,"context_line":"                    \u0027the database.\u0027,"},{"line_number":33,"context_line":"               secret\u003dTrue,"},{"line_number":34,"context_line":"               required\u003dTrue,"},{"line_number":35,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027sql_connection\u0027,"},{"line_number":36,"context_line":"                                                  group\u003d\u0027DEFAULT\u0027),"},{"line_number":37,"context_line":"                                cfg.DeprecatedOpt(\u0027sql_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c34fbe68","line":34,"in_reply_to":"1aa78d24_b0a48057","updated":"2016-07-08 22:07:42.000000000","message":"I can undo this change. I believe most projects to require this option, but there might be some exception out there.","commit_id":"579551ed61ea3f19a0a51584d24e1384b68c45c1"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"4ad307be579486beb61e295bd7d03944c3ec69e6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"               help\u003d\u0027Minimum number of SQL connections to keep open in a \u0027"},{"line_number":68,"context_line":"                    \u0027pool.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027max_pool_size\u0027,"},{"line_number":70,"context_line":"               default\u003d5,"},{"line_number":71,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027sql_max_pool_size\u0027,"},{"line_number":72,"context_line":"                                                  group\u003d\u0027DEFAULT\u0027),"},{"line_number":73,"context_line":"                                cfg.DeprecatedOpt(\u0027sql_max_pool_size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3056d029","line":70,"updated":"2016-07-04 14:02:24.000000000","message":"This must be fine: if it\u0027s not set, we simply rely on the default value in SQLAlchemy - http://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/sqlalchemy/engines.py#n168 , which happened to be 5","commit_id":"579551ed61ea3f19a0a51584d24e1384b68c45c1"}]}