)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a5068d6e3963010db199849684c27239ae8c354b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"crashing or returning garbage, the function just returns None,"},{"line_number":13,"context_line":"indicating it does not know how to get it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The warning from pagine_query() is not emitted in this case, as there\u0027s"},{"line_number":16,"context_line":"no way to guess if the developer did wrong or not."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1291fe1f1e78471f18f230a66edff31ed199bc7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_d11d5274","line":15,"updated":"2016-09-02 08:47:19.000000000","message":"paginate_query()","commit_id":"5b10e3689088a841eadb5b37cb3d10f2c6634f86"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"52883ecd8a4e50370c8e8b6ba7aa27a02bbe91f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"utils: fix get_unique_keys() when model has no table attached to it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the internal SQLAlchemy __table__ to find unique keys on a model"},{"line_number":10,"context_line":"class does not work if the model is not attached to a class. In this"},{"line_number":11,"context_line":"case, it seems there is no way to find what the keys are: rather than"},{"line_number":12,"context_line":"crashing or returning garbage, the function just returns None,"},{"line_number":13,"context_line":"indicating it does not know how to get it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_3d780fc4","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":59},"updated":"2016-09-02 09:45:09.000000000","message":"Hmm, I wonder how you run into this: if you use declarative system (http://docs.sqlalchemy.org/en/latest/orm/extensions/declarative/) the mapping is performed at import time (if your classes are defined at module scope) and __table__ attribute must always be present.","commit_id":"7b14eef2e6a27d17652e4936e979043460c417e5"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"3ae3aa370594dfdc1a99e45c83fc65584ced2015","unresolved":false,"context_lines":[{"line_number":7,"context_line":"utils: fix get_unique_keys() when model has no table attached to it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using the internal SQLAlchemy __table__ to find unique keys on a model"},{"line_number":10,"context_line":"class does not work if the model is not attached to a class. In this"},{"line_number":11,"context_line":"case, it seems there is no way to find what the keys are: rather than"},{"line_number":12,"context_line":"crashing or returning garbage, the function just returns None,"},{"line_number":13,"context_line":"indicating it does not know how to get it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_1d142b4b","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":59},"in_reply_to":"fa7ab95a_3d780fc4","updated":"2016-09-02 09:46:27.000000000","message":"Ah, I see the ML thread: [openstack-dev] [oslo] [telemetry] Oslo.db 4.13.1 broke Gnocchi","commit_id":"7b14eef2e6a27d17652e4936e979043460c417e5"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fdb655b236428efc4d909015a870a389da64148b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The warning from paginate_query() is not emitted in this case, as"},{"line_number":16,"context_line":"there\u0027s no way to guess if the developer did wrong or not."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1291fe1f1e78471f18f230a66edff31ed199bc7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_a314fce8","line":17,"updated":"2016-09-02 10:08:08.000000000","message":"nit: perhaps we could file a LP bug for tracking this","commit_id":"7b14eef2e6a27d17652e4936e979043460c417e5"}],"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f84055f96549bde39373a2ff9bfa87ffead4e5ba","unresolved":false,"context_lines":[{"line_number":106,"context_line":"def _stable_sorting_order(model, sort_keys):"},{"line_number":107,"context_line":"    \"\"\"Check whetever the sorting order is stable."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    :return: True if it is stable, False if it\u0027s not, None if it\u0027s impossible"},{"line_number":110,"context_line":"    to determine."},{"line_number":111,"context_line":"    \"\"\""},{"line_number":112,"context_line":"    keys \u003d get_unique_keys(model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_9f31080e","line":109,"updated":"2016-09-02 12:31:18.000000000","message":"Not sure it\u0027s useful to differential None and True","commit_id":"7b14eef2e6a27d17652e4936e979043460c417e5"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fdb655b236428efc4d909015a870a389da64148b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    :rtype: sqlalchemy.orm.query.Query"},{"line_number":154,"context_line":"    :return: The query with sorting/pagination added."},{"line_number":155,"context_line":"    \"\"\""},{"line_number":156,"context_line":"    if _stable_sorting_order(model, sort_keys) is False:"},{"line_number":157,"context_line":"        LOG.warning(_LW(\u0027Unique keys not in sort_keys. \u0027"},{"line_number":158,"context_line":"                        \u0027The sorting order may be unstable.\u0027))"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_6394b48a","line":156,"updated":"2016-09-02 10:08:08.000000000","message":"Perhaps, raising an exception in get_unique_keys() would be a more clear way to signalize an error (and would allow to avoid manual propagation with if/return), but that would arguably be a bigger change to its API, so I don\u0027t mind...","commit_id":"7b14eef2e6a27d17652e4936e979043460c417e5"}]}
