)]}'
{"oslo_db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b8ed7e5ca10939f213040b33b9ab4e8b5a3e36d5","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        for a DB the given engine is connected to."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        \"\"\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def db_drop_tables(self):"},{"line_number":385,"context_line":"        \"\"\"Called during teardown to drop all tables associated with this test"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_d6fab274","line":383,"updated":"2016-12-05 10:31:47.000000000","message":"I\u0027m fine with making this overridable, although I\u0027m not really sure anyone wants to implement that themselves. Alternatively, I think we could simply create an instance of Backend explicitly here to avoid relying on the fact that the engine was created by `provision` module","commit_id":"f65fca61cd9edc2a9b1421e1f675dd6bb49b1d0b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"436b1074ca72cde309ba3d8e3964fb35fdff0df6","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        for a DB the given engine is connected to."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        \"\"\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def db_drop_tables(self):"},{"line_number":385,"context_line":"        \"\"\"Called during teardown to drop all tables associated with this test"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_790b918e","line":383,"in_reply_to":"3a71b18c_d6fab274","updated":"2016-12-05 10:49:37.000000000","message":"Agreed, I have removed that and creates new backend for the cleanup.","commit_id":"f65fca61cd9edc2a9b1421e1f675dd6bb49b1d0b"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b8ed7e5ca10939f213040b33b9ab4e8b5a3e36d5","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        \"\"\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def db_drop_tables(self):"},{"line_number":385,"context_line":"        \"\"\"Called during teardown to drop all tables associated with this test"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        It assumes the engine have been created with the \u0027provision\u0027 module."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_f67b2e26","line":384,"range":{"start_line":384,"start_character":8,"end_line":384,"end_character":22},"updated":"2016-12-05 10:31:47.000000000","message":"naming nit: let\u0027s make it \n\n  def drop_all_objects(self, engine):\n      ...\n\nas some backends (like PostgreSQL) can actually have non-table objects in schema (e.g. ENUMs)","commit_id":"f65fca61cd9edc2a9b1421e1f675dd6bb49b1d0b"}]}