)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"958a2c4b141dd50bb1bea89901c9a0d509e6d5aa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"to alter all the URLs that have already been copied into the database"},{"line_number":30,"context_line":"and alter the query parameters with each of those individually,"},{"line_number":31,"context_line":"and then restart *all* services who will all receive the parameter"},{"line_number":32,"context_line":"(no way to add params to just one controller)."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Nova\u0027s \"store the URL in the database\" feature only needs to be able"},{"line_number":35,"context_line":"to locate the host / database name of the alternate database,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f93b717_bb7b1a79","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":46},"updated":"2018-01-30 13:38:44.000000000","message":"well, technically you can just restart the one controller you wanted to test the new params on...","commit_id":"fca431097f1d0c6110d25599aceb25e125e5a84b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"be60a874729bead1dd364af6616df2602d748ddb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow connection query string to be passed separately."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Nova project has made the decision to store the entire"},{"line_number":10,"context_line":"contents of the \"sql_connection\" field in the database, with"},{"line_number":11,"context_line":"alterations to the host value, such that various \"cells\" database"},{"line_number":12,"context_line":"URLs can be located using Nova\u0027s database itself as a central"},{"line_number":13,"context_line":"registry of database URLs."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f93b717_2738433b","line":11,"range":{"start_line":10,"start_character":56,"end_line":11,"end_character":29},"updated":"2018-01-30 19:48:14.000000000","message":"Also expected is that each cell database could have a different username/password.","commit_id":"9993efdeef4606f78182d084e4120a158a4e64b8"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"b54cb5bc09fa743f877b31876d6c3bf93ad1357e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow connection query string to be passed separately."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Nova project has made the decision to store the entire"},{"line_number":10,"context_line":"contents of the \"sql_connection\" field in the database, with"},{"line_number":11,"context_line":"alterations to the host value, such that various \"cells\" database"},{"line_number":12,"context_line":"URLs can be located using Nova\u0027s database itself as a central"},{"line_number":13,"context_line":"registry of database URLs."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f93b717_7deedced","line":11,"range":{"start_line":10,"start_character":56,"end_line":11,"end_character":29},"in_reply_to":"5f93b717_2738433b","updated":"2018-01-30 21:05:38.000000000","message":"funny story, Nova\u0027s design here also prevents a configuration that is required by some regulatory bodies where each controller accesses the database using an individual username/password, e.g. nova0/password0 for controller0, nova1/password1 for controller1, etc.  My patch here does not address this but when I did have to demonstrate this working I again needed to use read_default_file which is a hack.\n\nNova\u0027s \"cells\" feature should not be storing URLs in the database, they should be in nova.conf like all other URLs and should be manually configured.    There are so many URLs, usernames, passwords, region names, etc. configured in nova.conf for keystone, neutron, cinder, etc., there are literally dozens of keys in this file hardcoded to things about the environment.     I find it baffling why this one particular kind of URL was made to be part of some kind of automatic \"guess the URL\" system that writes them into the database.   Nova doesn\u0027t start up a whole MySQLd server and configure it, someone has to do that manually.   Therefore connectivity to new databases should be going in nova.conf just like all the other multiple dozens of environment-level configurations.  Not to mention is Nova storing the plaintext password in the database itself as part of this URL?  another dealbreaker for many security standards.","commit_id":"9993efdeef4606f78182d084e4120a158a4e64b8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4dd7d5eea417978e4d6d7e5bcaf007dfbc84b9d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow connection query string to be passed separately."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Nova project has made the decision to store the entire"},{"line_number":10,"context_line":"contents of the \"sql_connection\" field in the database, with"},{"line_number":11,"context_line":"alterations to the host value, such that various \"cells\" database"},{"line_number":12,"context_line":"URLs can be located using Nova\u0027s database itself as a central"},{"line_number":13,"context_line":"registry of database URLs."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f93b717_dd87f0b4","line":11,"range":{"start_line":10,"start_character":56,"end_line":11,"end_character":29},"in_reply_to":"5f93b717_7deedced","updated":"2018-01-30 21:17:15.000000000","message":"How does the design prevent such a configuration? The idea was that each cell has an individual connection URL containing a potentially unique username/password. I\u0027m not aware of any way this cannot be configured. The \u0027nova-manage cell_v2 create_cell\u0027 command is how operators pass the DB URL and MQ URL per cell when they create a new cell.\n\nI\u0027m open to the idea of a better design that we could migrate to in the future. Are you suggesting the idea of keeping a list of cell database urls in the nova.conf? Because the main challenge we face is that we need a cell -\u003e DB URL mapping per cell. We chose to put this in the database. Else we need some other JSON-dict type of representation in nova.conf (or some other solution) that provides the cell DB URL for nova API to look up to read/write from cell databases.","commit_id":"9993efdeef4606f78182d084e4120a158a4e64b8"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"82cc4f23e6e4d7d41662bd71c2f24680199c23f3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow connection query string to be passed separately."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Nova project has made the decision to store the entire"},{"line_number":10,"context_line":"contents of the \"sql_connection\" field in the database, with"},{"line_number":11,"context_line":"alterations to the host value, such that various \"cells\" database"},{"line_number":12,"context_line":"URLs can be located using Nova\u0027s database itself as a central"},{"line_number":13,"context_line":"registry of database URLs."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f93b717_98a65653","line":11,"range":{"start_line":10,"start_character":56,"end_line":11,"end_character":29},"in_reply_to":"5f93b717_dd87f0b4","updated":"2018-01-30 22:28:44.000000000","message":"\u003e How does the design prevent such a configuration? The idea was that each cell has an individual connection URL containing a potentially unique username/password. I\u0027m not aware of any way this cannot be configured.\n\nWhen we run Nova in HA environments, multiple controllers run Nova services that all talk to the same database.   We had a requirement from a customer that, for security purposes, it would be impossible to use the username/password gleaned from a .conf file *outside* of that host.   MySQL allows this as when you create usernames in MySQL, you also get to set up the host that they are coming from, so you can make usernames like \"nova0%172.10.1.2\" and \"nova1%172.10.1.3\".  If I steal the username/password for \"nova1\", maybe because I saw a backup of the server or something, I can\u0027t use it, because I\u0027m not coming from 172.10.1.3.\n\nSo the solution for all the other services here, like keystone, neutron, etc. was to go into each .conf file and change the url from:\n\nmysql+pymysql://keystone:password@mysql_host/keystone\n\nto per-controller username/passwords, that is, on controller 0:\n\nmysql+pymysql://keystone0:some_password@mysql_host/keystone\n\non controller 1:\n\nmysql+pymysql://keystone1:some_other_password@mysql_host/keystone\n\netc.  The keystone1/some_other_password name is unusable coming from any host other than controller 1.\n\nWhen I ran this, Nova immediately failed.   The first service that did something ran whatever it is that generates a new URL, copied the URL with the \"nova0\" username into the cells database, and that became the authoritative URL for that \"cell\".  The URL was broken when used by any host other than that individual controller because that username only works from one place.  This is because the cells functionality doesn\u0027t care about the local nova.conf file once it has its database value. \n\n\n\u003e Are you suggesting the idea of keeping a list of cell database urls in the nova.conf? Because the main challenge we face is that we need a cell -\u003e DB URL mapping per cell. \n\nSo from a \"how to encode it in the conf file\" aspect, there are a lot of ways to do that.   But I get the impression that \"cells\" are intended to be sort of like tenants and that there may be some system where these tenants get created on the fly, and that\u0027s more the reason \"cells\" want to be dynamically created.   The URLs in the database thing strongly implies there\u0027s a notion of \"you can make as many cells as you want on the fly as you get new customers\".   Assuming that\u0027s the case it would be nice if we weren\u0027t forced into buying into that style of configuration if it does not apply.\n\nFrom a \"how to encode dozens of cells in the conf file\" perspective, there\u0027s lots of ways to do that, here\u0027s a typical one:\n\n[some_config]\ncells: cell1, cell2, my_crazy_cell\n\n[cell1]\nconnection: mysql+pymysql://foo:bar@host/dbname\n\n[cell2]\nconnection: mysql+pymysql://a:b@host/somedb\n\n[my_crazy_cell]\nconnection: mysql+pymysql://beep@host/dbname\n\nThe above would be a reasonable default for installations until an operator has the need to get into \"make dynamic cells on the fly\" use case, assuming that\u0027s even a use case.  \n\nThen you can just augment the configuration with a flag, such as \"dynamic_cells\u003dTrue\", where cell names that aren\u0027t in .conf are looked up in the existing cell database table.   Again the URLs that are stored in the database should also have some ability to draw from local conf file - such as if all of my databases were MySQL databases, I can make one change in the .conf file and change the driver from mysqldb to pymysql.   The URLs should be stored as individual fields - the database type (or if NULL use a default setting), the username / password (encrypted, hopefully, using a secret that is again in the .conf file) / hostname (or if NULL use a default setting from the .conf file) and the database name.\n\nBut this is again assuming the \"operators want to be able to click a button and add new tenants / cells\" use case, in which case how the MySQL databases get created is still something I\u0027d be curious about.","commit_id":"9993efdeef4606f78182d084e4120a158a4e64b8"}],"oslo_db/sqlalchemy/enginefacade.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c37b721adbb378809c7937449054ab840a98fc83","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        :param connection_debug: engine logging level, defaults to 0. set to"},{"line_number":221,"context_line":"         50 for INFO, 100 for DEBUG."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :param connection_parameters: additional parameters to append onto the"},{"line_number":224,"context_line":"         database URL query string, pass as \"param1\u003dvalue1\u0026param2\u003dvalue2\u0026...\""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        :param max_pool_size: max size of connection pool, uses CONF for"},{"line_number":227,"context_line":"         default"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_a61eaa5c","line":224,"range":{"start_line":223,"start_character":70,"end_line":224,"end_character":34},"updated":"2018-02-20 20:24:57.000000000","message":"nit: might be worth including \"at connect time\" like in the CONF option helpstring.","commit_id":"9993efdeef4606f78182d084e4120a158a4e64b8"}],"releasenotes/notes/add_connection_parameters-231aa7d8b7d2d416.yaml":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"52a1e7024a0dad8e9a0de3e80b130a1f97088942","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added new option connection_parameters which allows SQLAlchemy query"},{"line_number":5,"context_line":"    parameters to be stated separately from the URL itself, to allow"},{"line_number":6,"context_line":"    URL-persistence schemes like Nova cells to use controller-local"},{"line_number":7,"context_line":"    query parameters that aren\u0027t broadcast to all other servers."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_b42074b2","line":7,"updated":"2018-02-15 16:58:25.000000000","message":"I\u0027m confused by the use of \"query parameters\" and \"connection parameters\" to mean the same thing here.","commit_id":"9993efdeef4606f78182d084e4120a158a4e64b8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c37b721adbb378809c7937449054ab840a98fc83","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added new option connection_parameters which allows SQLAlchemy query"},{"line_number":5,"context_line":"    parameters to be stated separately from the URL itself, to allow"},{"line_number":6,"context_line":"    URL-persistence schemes like Nova cells to use controller-local"},{"line_number":7,"context_line":"    query parameters that aren\u0027t broadcast to all other servers."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_46448647","line":7,"in_reply_to":"3fa0c359_b42074b2","updated":"2018-02-20 20:24:57.000000000","message":"agreed. probably would be good to reword as \"DB URI parameters\".","commit_id":"9993efdeef4606f78182d084e4120a158a4e64b8"}]}
