)]}'
{"oslo_db/tests/sqlalchemy/test_utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98a8aca087c1695ae8f096d82e5fc2c56e7b2cbf","unresolved":false,"context_lines":[{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    @mock.patch(\u0027sqlalchemy.engine.base.Engine.connect\u0027)"},{"line_number":1002,"context_line":"    def test_ensure_backend_available(self, mock_connect):"},{"line_number":1003,"context_line":"        fake_connection \u003d mock.Mock()"},{"line_number":1004,"context_line":"        fake_connection.close()"},{"line_number":1005,"context_line":"        mock_connect.return_value \u003d fake_connection"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        eng \u003d provision.Backend._ensure_backend_available(self.connect_string)"},{"line_number":1008,"context_line":"        self.assertIsInstance(eng, sqlalchemy.engine.base.Engine)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2c72f9e5","line":1005,"range":{"start_line":1003,"start_character":0,"end_line":1005,"end_character":51},"updated":"2018-09-24 10:36:38.000000000","message":"Don\u0027t think this is correct. Mox works like so:\n\n  create stubs\n  specify what you expect to be called, in the order it should be called\n  replay all\n\nSo the \u0027fake_connection.close()\u0027 call is an expected call that we should be checking for. We shouldn\u0027t be calling it ourselves","commit_id":"710771485eb28a0262ebca61fa081402b13f0a38"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98a8aca087c1695ae8f096d82e5fc2c56e7b2cbf","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"        eng \u003d provision.Backend._ensure_backend_available(self.connect_string)"},{"line_number":1008,"context_line":"        self.assertIsInstance(eng, sqlalchemy.engine.base.Engine)"},{"line_number":1009,"context_line":"        self.assertEqual(self.connect_string, str(eng.url))"},{"line_number":1010,"context_line":"        mock_connect.assert_called_with()"},{"line_number":1011,"context_line":""},{"line_number":1012,"context_line":"    @mock.patch(\u0027sqlalchemy.engine.base.Engine.connect\u0027)"},{"line_number":1013,"context_line":"    def test_ensure_backend_available_no_connection_raises(self, mock_connect):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cc634519","line":1010,"range":{"start_line":1010,"start_character":0,"end_line":1010,"end_character":41},"updated":"2018-09-24 10:36:38.000000000","message":"This should read:\n\n  mock_connect.close.assert_called_with()","commit_id":"710771485eb28a0262ebca61fa081402b13f0a38"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98a8aca087c1695ae8f096d82e5fc2c56e7b2cbf","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"    @mock.patch(\u0027sqlalchemy.create_engine\u0027)"},{"line_number":1031,"context_line":"    def test_ensure_backend_available_no_dbapi_raises(self, mock_engine):"},{"line_number":1032,"context_line":"        log \u003d self.useFixture(fixtures.FakeLogger())"},{"line_number":1033,"context_line":"        mock_engine.side_effect \u003d \\"},{"line_number":1034,"context_line":"            ImportError(\"Can\u0027t import DBAPI module foobar\")"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        exc \u003d self.assertRaises("},{"line_number":1037,"context_line":"            exception.BackendNotAvailable,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ac47e97a","line":1034,"range":{"start_line":1033,"start_character":34,"end_line":1034,"end_character":24},"updated":"2018-09-24 10:36:38.000000000","message":"nit: Could you drop the \u0027/\u0027 and instead just wrap the string on the next line?","commit_id":"710771485eb28a0262ebca61fa081402b13f0a38"}]}