)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"2b07e59c5e9166d3dbba275fb2fa19b6b5480aa0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This flag is to be deprecated in SQLAlchemy version 1.3,"},{"line_number":10,"context_line":"as it is a leftover from the pre-Python 3 legacy days when"},{"line_number":11,"context_line":"DBAPIs under Python 2 would crash if you passed them a"},{"line_number":12,"context_line":"u\u0027\u0027 object.   While still available in 1.3, it will emit a"},{"line_number":13,"context_line":"deprecation warning, so it\u0027s time to stop using this flag and to"},{"line_number":14,"context_line":"locate any downstream Openstack projects that might be relying"},{"line_number":15,"context_line":"on its behavior in a Python 2 context; the flag has no real effect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_816a36e7","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":11},"updated":"2018-12-21 19:59:59.000000000","message":"This is more explicitly mentioned in the sqlalchemy issue, but these crashes are no longer an issue:\n\n\"All DBAPIs now accommodate Python u\u0027\u0027 directly, and in the case where the u\u0027\u0027 is to have non-ascii data, the Unicode datatype is used.\"\n\nSo this should be safe to do even though we still support python 2.","commit_id":"a6d2cc57d47f149398bf3817ebdfe15ff8d908e2"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fd8d508a620fbde0c41ffa5ae25d433b1897232c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This flag is to be deprecated in SQLAlchemy version 1.3,"},{"line_number":10,"context_line":"as it is a leftover from the pre-Python 3 legacy days when"},{"line_number":11,"context_line":"DBAPIs under Python 2 would crash if you passed them a"},{"line_number":12,"context_line":"u\u0027\u0027 object.   While still available in 1.3, it will emit a"},{"line_number":13,"context_line":"deprecation warning, so it\u0027s time to stop using this flag and to"},{"line_number":14,"context_line":"locate any downstream Openstack projects that might be relying"},{"line_number":15,"context_line":"on its behavior in a Python 2 context; the flag has no real effect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f769fc5_5cfe1106","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":11},"in_reply_to":"3f79a3b5_671a8a19","updated":"2018-12-22 12:45:54.000000000","message":"Agreed.","commit_id":"a6d2cc57d47f149398bf3817ebdfe15ff8d908e2"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"a163b45073decf3eafdb4271ed80a5ccadafbde4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This flag is to be deprecated in SQLAlchemy version 1.3,"},{"line_number":10,"context_line":"as it is a leftover from the pre-Python 3 legacy days when"},{"line_number":11,"context_line":"DBAPIs under Python 2 would crash if you passed them a"},{"line_number":12,"context_line":"u\u0027\u0027 object.   While still available in 1.3, it will emit a"},{"line_number":13,"context_line":"deprecation warning, so it\u0027s time to stop using this flag and to"},{"line_number":14,"context_line":"locate any downstream Openstack projects that might be relying"},{"line_number":15,"context_line":"on its behavior in a Python 2 context; the flag has no real effect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_a472e09c","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":11},"in_reply_to":"3f79a3b5_816a36e7","updated":"2018-12-21 20:26:45.000000000","message":"I just put up those docs today.  \n\nThere is one scenario where this can break.  if you do this:\n\n\n   # python 2 only\n   # Whatever.foo is String\n   # assume db value is non-ascii such as \u0027méil\u0027\n   my_value, \u003d session.query(Whatever.foo)(...).first()\n   my_value.encode(\u0027utf-8\u0027)  # this will break, because my_value is string not unicode\n\nso we\u0027d need to find if any projects are using the plain String type with non-ascii data.","commit_id":"a6d2cc57d47f149398bf3817ebdfe15ff8d908e2"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c1ace7691cfc12b976f8b40d4e7f5e9bb56ed582","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This flag is to be deprecated in SQLAlchemy version 1.3,"},{"line_number":10,"context_line":"as it is a leftover from the pre-Python 3 legacy days when"},{"line_number":11,"context_line":"DBAPIs under Python 2 would crash if you passed them a"},{"line_number":12,"context_line":"u\u0027\u0027 object.   While still available in 1.3, it will emit a"},{"line_number":13,"context_line":"deprecation warning, so it\u0027s time to stop using this flag and to"},{"line_number":14,"context_line":"locate any downstream Openstack projects that might be relying"},{"line_number":15,"context_line":"on its behavior in a Python 2 context; the flag has no real effect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_e4cbf87b","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":11},"in_reply_to":"3f79a3b5_a472e09c","updated":"2018-12-21 20:44:28.000000000","message":"Should we hold off on this until we\u0027ve audited the other projects\u0027 use then?","commit_id":"a6d2cc57d47f149398bf3817ebdfe15ff8d908e2"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"5967d6e0c6484d7e7b8f72fefe7ffbe33335960c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This flag is to be deprecated in SQLAlchemy version 1.3,"},{"line_number":10,"context_line":"as it is a leftover from the pre-Python 3 legacy days when"},{"line_number":11,"context_line":"DBAPIs under Python 2 would crash if you passed them a"},{"line_number":12,"context_line":"u\u0027\u0027 object.   While still available in 1.3, it will emit a"},{"line_number":13,"context_line":"deprecation warning, so it\u0027s time to stop using this flag and to"},{"line_number":14,"context_line":"locate any downstream Openstack projects that might be relying"},{"line_number":15,"context_line":"on its behavior in a Python 2 context; the flag has no real effect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_671a8a19","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":11},"in_reply_to":"3f79a3b5_e4cbf87b","updated":"2018-12-21 22:20:47.000000000","message":"We might want to do an audit, but thinking some more about this I realized that the pymysql and psycopg2 drivers I\u0027m pretty sure are returning all u\u0027\u0027 in all cases anyway these days.   pysqlite definitely is.   so I think we should go forward with it but be ready in case someone has a problem to go to their project and fix a String to Unicode issue.","commit_id":"a6d2cc57d47f149398bf3817ebdfe15ff8d908e2"}]}
