)]}'
{"oslo_db/sqlalchemy/utils.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b1f1c143bf1e93dede3241ef1de8a8a8036a44ff","unresolved":false,"context_lines":[{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"    \"\"\""},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"    _nested_trans \u003d None"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    def __init__(self, connection):"},{"line_number":1233,"context_line":"        self.connection \u003d connection"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_2fdfdf0d","line":1230,"updated":"2019-06-10 15:46:14.000000000","message":"This used to be an instance variable. Did you mean to make it a class variable with this change? It looks like this would be relevant to a specific connection, which is an instance variable.","commit_id":"459de143578367c00fb508edeea68eb96531724c"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"f34319abb2f596f439406a3bebac9f575e604394","unresolved":false,"context_lines":[{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"    \"\"\""},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"    _nested_trans \u003d None"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    def __init__(self, connection):"},{"line_number":1233,"context_line":"        self.connection \u003d connection"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_bdcea57f","line":1230,"in_reply_to":"9fb8cfa7_2fdfdf0d","updated":"2019-06-10 17:02:05.000000000","message":"it is still an instance level variable the moment the class is instantiated as _restart_nested() will set it.  this is just a default so that I don\u0027t need to set it in the constructor outside of _restart_nested(), as it looks leaky to me that we set _nested_trans to None then go right into _restart_nested() where we immediately set it to something else.   But I suppose it doesn\u0027t matter.","commit_id":"459de143578367c00fb508edeea68eb96531724c"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"f34319abb2f596f439406a3bebac9f575e604394","unresolved":false,"context_lines":[{"line_number":1232,"context_line":"    def __init__(self, connection):"},{"line_number":1233,"context_line":"        self.connection \u003d connection"},{"line_number":1234,"context_line":"        self._trans \u003d connection.begin()"},{"line_number":1235,"context_line":"        self._restart_nested()"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _restart_nested(self):"},{"line_number":1238,"context_line":"        if self._nested_trans is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_dda8398d","line":1235,"updated":"2019-06-10 17:02:05.000000000","message":"in __init__, we call _restart_nested()....","commit_id":"459de143578367c00fb508edeea68eb96531724c"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"f34319abb2f596f439406a3bebac9f575e604394","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"        self._restart_nested()"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"    def _restart_nested(self):"},{"line_number":1238,"context_line":"        if self._nested_trans is not None:"},{"line_number":1239,"context_line":"            self._nested_trans.rollback()"},{"line_number":1240,"context_line":"        self._nested_trans \u003d self.connection.begin_nested()"},{"line_number":1241,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5d9c4969","line":1238,"updated":"2019-06-10 17:02:05.000000000","message":"... where we would like to roll back _nested_trans if it is present.","commit_id":"459de143578367c00fb508edeea68eb96531724c"}]}