)]}'
{"id":"openstack%2Foslo.db~711221","triplet_id":"openstack%2Foslo.db~master~Ib3862fa9c090e185069809fffadd5814d93046eb","project":"openstack/oslo.db","branch":"master","topic":"heat_db_retries","hashtags":[],"change_id":"Ib3862fa9c090e185069809fffadd5814d93046eb","subject":"Allow infinite retrying on the expected db errors","status":"ABANDONED","created":"2020-03-04 13:15:28.000000000","updated":"2020-03-26 14:15:35.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"71e031366d881bd800a4ef711b3365bbbd4fe66b","_number":711221,"virtual_id_number":711221,"owner":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-03-25 09:02:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-03-26 08:53:13.000000000","_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"date":"2020-03-26 13:58:47.000000000","_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"date":"2020-03-26 11:07:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-05 09:47:29.000000000","updated_by":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"reviewer":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"state":"REVIEWER"},{"updated":"2020-03-11 14:52:50.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-03-24 11:20:49.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-03-25 09:02:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-26 11:07:34.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-03-26 13:58:47.000000000","updated_by":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"reviewer":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"state":"REVIEWER"}],"messages":[{"id":"74d2de60671ed27040f7bd58a27c384bba90ce59","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-04 13:15:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"196fc4a9796b0aa9d055ded83c2c672b61467522","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-03-04 13:36:06.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nHello,\n\nDo you think it\u0027s possible to implement some related tests in [1]?\n\n[1] https://github.com/openstack/oslo.db/blob/master/oslo_db/tests/test_api.py#L201","accounts_in_message":[],"_revision_number":1},{"id":"6fdfe18cb23e117753cad57819ef66486e049a9a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-04 15:09:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2086f5bcd86c4e3986a5a6a48803b8f5 : SUCCESS in 1h 47m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/545c3dd46d3547be8845f5523e0be882 : SUCCESS in 5m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/54e85a481a93438abdbc25c15bda6e7f : SUCCESS in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/089e5866d0224cb78827e112fce55bce : SUCCESS in 5m 43s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0bb609a8b3b949bbb12981ad8d2fb182 : SUCCESS in 8m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/90c818785bb948519dd3b89c88f87ad1 : SUCCESS in 6m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2bd5c6eadea54169a44b83c523cfada9 : SUCCESS in 5m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/167c89dccd3548a18abdde597fb6ca30 : SUCCESS in 6m 37s","accounts_in_message":[],"_revision_number":1},{"id":"9644954294a14514ee48334d18532619b7f30cc3","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-04 16:49:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9c5e49f2ad3d7625d530f1358aecbabf7ab53430","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-04 18:37:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/68736d2513e64bb4a0c911aad0ae2edb : SUCCESS in 1h 34m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6e3c147b0b6b4cbe92b3768a2160f234 : SUCCESS in 7m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bb01b3b65ac5444f96a665f730595f39 : SUCCESS in 6m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/72d99af342d548378a3976612391db06 : SUCCESS in 5m 54s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/98e1f4083f8c44d3809b42e31b9ea963 : SUCCESS in 6m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fa20f55934a64b058ae8453abed157b1 : SUCCESS in 7m 31s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fe98d154b0904fc5ad72382bd45a3991 : SUCCESS in 6m 48s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/19d285970ec34a9ab10440f40dde0801 : SUCCESS in 6m 44s","accounts_in_message":[],"_revision_number":2},{"id":"8a1a803dd0c489757b0f7120356175aafb04d35a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-03-11 14:52:50.000000000","message":"Patch Set 2: Code-Review-1\n\n(6 comments)\n\nLooks like I\u0027m not the first person to ask for tests here. Add those and we\u0027ll be much happier, I assure you :)","accounts_in_message":[],"_revision_number":2},{"id":"e302973935f75a68f8814e9d51c3bcbd1cfb9b7b","author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-03-11 14:55:19.000000000","message":"Patch Set 2:\n\ninfinite retries makes me a bit nervous, because that\u0027s how people perceive that an app is permanently \"hung\".   Just curious how do Nova etc. deal with this case, where the database can be stopped for any amount of time, and then upon starting it, they wake up?  does nova etc. have their own version of this decorator that retries infinitely or is there some other mechanism that is \"retrying\" ?","accounts_in_message":[],"_revision_number":2},{"id":"5de16ebd347e10025d4f47e82008f19068024184","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-11 14:55:32.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"b8eac8e2898d4b3cd5b202d148ac1f4714253d6d","author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-03-11 14:56:04.000000000","message":"Patch Set 2:\n\ntaht is, infinite \"retry\" on \"database is not available\" is useful, whereas infinite \"Retry\" on \"database is deadlocking\" is dangerous.","accounts_in_message":[],"_revision_number":2},{"id":"85a856abd6dcace258364f1c91184d0d48ab95db","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-11 15:04:17.000000000","message":"Patch Set 2:\n\nthat\u0027s correct but we only give users a tool, right?\nshall I prohibit its potential misuse?","accounts_in_message":[],"_revision_number":2},{"id":"85764891157ad4ee1a85928d3cada12b126e5dd5","author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-03-11 15:22:22.000000000","message":"Patch Set 2:\n\nI think we should be clear on the use case.  \n\nif the retry is infinite in a case where someone is waiting on their commandline to return a response, but the database is stopped, that\u0027s bad - their commandline will hang indefinitely rather than just saying, the database isn\u0027t running.\n\nif the retry is in a daemon process that represents that daemon\u0027s normal permanent process of getting work to do, and it wants to keep retrying until the database is started, that\u0027s good.\n\nbut nova, neutron, keystone etc and other services already do this somehow.   what is the mechanism by which they are doing this?","accounts_in_message":[],"_revision_number":2},{"id":"85cd6d17f062b3ec09ceb65c3e945bd580c27844","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-11 15:42:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4cfb6d68818ef84c60dd3dd8d2cd6abc1d44761f","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-11 15:48:26.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"fe982ae13d39b4a7b466438bde158045f254f8a8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-11 17:15:38.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0ffe4260dd384513b3b26d4bcb4c95cd : SUCCESS in 1h 26m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2c1365b87ffb431a81c0d2f317eb3fcb : SUCCESS in 5m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/98b0c57c94f541378ac419932f655f0d : FAILURE in 3m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/800741cd6a98407595655a7bbe4f09a6 : SUCCESS in 7m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5ac6a1af8244403cab34995f2642c7ab : SUCCESS in 5m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/05117844eb9a4915993e35e0ebde2a07 : SUCCESS in 7m 50s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9fde703e34ba40c59bd42cd3115a6159 : SUCCESS in 5m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/83a2cc5da47947b0b7cae132c3ec7a53 : SUCCESS in 4m 43s","accounts_in_message":[],"_revision_number":3},{"id":"8366209583e56f29c457b57aa35966fa76cab93a","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-12 08:09:42.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"6040dee9bb1c850cc56e9da0679c4a65adda323e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-12 09:40:42.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3cce702dbdad4097a47e52a32429291e : SUCCESS in 1h 26m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b3eeba1e03d5476a941e0ab3556c0f25 : SUCCESS in 4m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/128ea4904b514858b5708a23a284c928 : SUCCESS in 3m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b910f14999d74cf287e011c408d53778 : SUCCESS in 4m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7366afedeae54b92b5ec643a903dd7bd : SUCCESS in 5m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bd1dc90330fb43dc9f8d24923e0e75dc : SUCCESS in 5m 07s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/43f4f1b5bade453e9e85645bdd46c51a : SUCCESS in 4m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c8a139a53bc543deabe15611e7c2f88e : SUCCESS in 4m 22s","accounts_in_message":[],"_revision_number":4},{"id":"7d6e8f671241c9b11823f5df6fa8d85a585a163c","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-24 07:58:58.000000000","message":"Patch Set 4:\n\nhi, any updates for this?\nunit tests had been added","accounts_in_message":[],"_revision_number":4},{"id":"8a4836397a384643ecd0e563a5952619af131d44","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-03-24 11:15:08.000000000","message":"Patch Set 4: Code-Review-1\n\nShould be rebased on latest commit to avoid mox issues since mox have been dropped previously else unit tests will fail with this parent commit.","accounts_in_message":[],"_revision_number":4},{"id":"96bd8ad16d40c8433633ee0a44b37a6317c1e9be","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-03-24 11:20:49.000000000","message":"Patch Set 4:\n\n\u003e Should be rebased on latest commit to avoid mox issues since mox\n \u003e have been dropped previously else unit tests will fail with this\n \u003e parent commit.\n\nShould only be needed for local testing. In gate, and when merging, this will get rebased. So no need to rebase on its own otherwise.","accounts_in_message":[],"_revision_number":4},{"id":"a5fca44e0e1151bbfebd6ab12f2477e98e4cf8a3","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-25 07:27:01.000000000","message":"Patch Set 5: Patch Set 4 was rebased","accounts_in_message":[],"_revision_number":5},{"id":"e99fd5576447a1f1efb15edf72cc1e0bdff41e8a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-25 09:02:13.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/06f6742030804929939fad2a9fa01a0c : SUCCESS in 1h 34m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/97c0392fa0c541398d60f02c8b47f722 : SUCCESS in 5m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7eae12f1bdd24a3bbb8537f375c8b1ae : SUCCESS in 4m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c93aa5c9c1094826961144d0352af31b : SUCCESS in 5m 49s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/91ea9d76db73487e863d8159e13a855b : SUCCESS in 5m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/50c1dfd4ef8445f19fed6baeaec7df30 : SUCCESS in 6m 10s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c793fe0d02144d1b806da0af2cce7364 : SUCCESS in 5m 13s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4c2925e6f03f42caae03e5a7d19f0f56 : SUCCESS in 5m 27s","accounts_in_message":[],"_revision_number":5},{"id":"b2947164908ea83187b0ba15b179e24dfead60e4","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-03-25 10:55:33.000000000","message":"Patch Set 5: -Code-Review\n\n\u003e \u003e Should be rebased on latest commit to avoid mox issues since mox\n \u003e \u003e have been dropped previously else unit tests will fail with this\n \u003e \u003e parent commit.\n \u003e \n \u003e Should only be needed for local testing. In gate, and when merging,\n \u003e this will get rebased. So no need to rebase on its own otherwise.\n\nright","accounts_in_message":[],"_revision_number":5},{"id":"0f1c9ecaf2c0dbf7d82e99c416e16915060dfa47","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-03-25 14:16:27.000000000","message":"Patch Set 5:\n\n@Bogdan: thanks for unit tests.\n\nI agree with Mike we should be cautious with this kind of mechanism, to avoid.\n\n \u003e I think we should be clear on the use case.\n \u003e \n \u003e if the retry is infinite in a case where someone is waiting on\n \u003e their commandline to return a response, but the database is\n \u003e stopped, that\u0027s bad - their commandline will hang indefinitely\n \u003e rather than just saying, the database isn\u0027t running.\n \u003e \n \u003e if the retry is in a daemon process that represents that daemon\u0027s\n \u003e normal permanent process of getting work to do, and it wants to\n \u003e keep retrying until the database is started, that\u0027s good.\n \u003e \n \u003e but nova, neutron, keystone etc and other services already do this\n \u003e somehow.   what is the mechanism by which they are doing this?\n\n@Bogdan: have you some info to bring to the Mike\u0027s question?","accounts_in_message":[],"_revision_number":5},{"id":"fdaf7426d7b59fd88d282bfc3b2f73161953d0e4","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-03-25 14:17:37.000000000","message":"Patch Set 5:\n\n\u003e @Bogdan: thanks for unit tests.\n \u003e \n \u003e I agree with Mike we should be cautious with this kind of\n \u003e mechanism, to avoid.\n\nto avoid to hide some issues.\n\n \u003e \n \u003e \u003e I think we should be clear on the use case.\n \u003e \u003e\n \u003e \u003e if the retry is infinite in a case where someone is waiting on\n \u003e \u003e their commandline to return a response, but the database is\n \u003e \u003e stopped, that\u0027s bad - their commandline will hang indefinitely\n \u003e \u003e rather than just saying, the database isn\u0027t running.\n \u003e \u003e\n \u003e \u003e if the retry is in a daemon process that represents that daemon\u0027s\n \u003e \u003e normal permanent process of getting work to do, and it wants to\n \u003e \u003e keep retrying until the database is started, that\u0027s good.\n \u003e \u003e\n \u003e \u003e but nova, neutron, keystone etc and other services already do\n \u003e this\n \u003e \u003e somehow.   what is the mechanism by which they are doing this?\n \u003e \n \u003e @Bogdan: have you some info to bring to the Mike\u0027s question?","accounts_in_message":[],"_revision_number":5},{"id":"55be119c2e2742b96daf93e653617ec22b62deb2","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-26 08:53:13.000000000","message":"Patch Set 5:\n\nthat\u0027s correct but we only give users a tool, right?","accounts_in_message":[],"_revision_number":5},{"id":"4adc9c4ffa7f611b98cdabc3354199163e5b820a","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-03-26 11:07:34.000000000","message":"Patch Set 5:\n\n\u003e that\u0027s correct but we only give users a tool, right?\n\nIndeed, I think we can consider oslo.db as a tool for users.\n\nI think that these changes make sense for the case described in the story (the heat use case).\n\nAs I seen on nova, they always give a positive `max_retries` [1] to the wrapper so I don\u0027t we\u0027ll see side effects on nova.\n\nOther services should explicitely pass this value (`-1`) to activate this behaviour and the actual default value is `10`, so I don\u0027t think we risk to face related issues on classic usage and only the aware users aware will activate this behaviour. \n\nThen if we choose to move further with this feature then we should add a strong warning about hanging [2] (this help text looks wrong).\n\nAlso it could be worth to add related doc [3] and associated warn.\n\nAs Mike sayed:\n\n\u003e if the retry is infinite in a case where someone is waiting on their \u003e commandline to return a response, but the database is stopped, \n\u003e that\u0027s bad - their commandline will hang indefinitely rather than \n\u003e just saying, the database isn\u0027t running.\n\nI guess when operators use openstack commands with CLI or execute things through horizon we are in this case where things can hangs indefinitely, but as I sayed previously all service looks like to use positive values for now, and only aware user will activate this (heat in our case) so it will be an isolated, specific, and managed use case.\n\nPlease, can you add some doc and warnings to avoid side effects?\n\nThoughts?\n\n[1] https://github.com/openstack/nova/search?q\u003dwrap_db_retry\u0026unscoped_q\u003dwrap_db_retry\n\n[2] https://github.com/openstack/oslo.db/blob/master/oslo_db/options.py#L84,L86\n\n[3] https://github.com/openstack/oslo.db/blob/master/doc/source/user/usage.rst","accounts_in_message":[],"_revision_number":5},{"id":"aa50458287f8ada4a73895a02f068a4161854d92","author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-03-26 13:58:47.000000000","message":"Patch Set 5:\n\n\u003e that\u0027s correct but we only give users a tool, right?\n\noslo.db doesn\u0027t want to encourage a pattern that is never useful, however.  I\u0027ve yet to see how this -1 feature is to be used.   Again, services like Nova, Keystone have some non-oslo-db means of eventually connecting to the DB when the DB is down.\n\ndo you have a specific place you want to use this feature?","accounts_in_message":[],"_revision_number":5},{"id":"bc266c74449ff25d89a4038a4d597a2f633b763d","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2020-03-26 14:15:35.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"269dbb7d8d1d0c941f6407d118d88f8cf705a0ed","revisions":{"9712d43bdd924ccc55565627eeb937caa72bd62f":{"kind":"REWORK","_number":1,"created":"2020-03-04 13:15:28.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/21/711221/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/21/711221/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/1"}}},"commit":{"parents":[{"commit":"fafcbddec7deb3d96b4cb3b837912b8fcfb2debb","subject":"Merge \"gitignore: Add reno artefacts\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/fafcbddec7deb3d96b4cb3b837912b8fcfb2debb"}]}],"author":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-04 13:01:24.000000000","tz":60},"committer":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-04 13:15:26.000000000","tz":60},"subject":"Allow infinit retrying on the expected db errors","message":"Allow infinit retrying on the expected db errors\n\nWhen max_retries \u003d\u003d -1, retrying becomes infinit.\n\nStory: 2007328\ntask: 38849\n\nChange-Id: Ib3862fa9c090e185069809fffadd5814d93046eb\nSigned-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/9712d43bdd924ccc55565627eeb937caa72bd62f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/9712d43bdd924ccc55565627eeb937caa72bd62f"}]},"branch":"refs/heads/master"},"1e055d30d9781b35f6875da4f97fc8331c6a7d52":{"kind":"REWORK","_number":2,"created":"2020-03-04 16:49:06.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/21/711221/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/21/711221/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/2"}}},"commit":{"parents":[{"commit":"fafcbddec7deb3d96b4cb3b837912b8fcfb2debb","subject":"Merge \"gitignore: Add reno artefacts\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/fafcbddec7deb3d96b4cb3b837912b8fcfb2debb"}]}],"author":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-04 13:01:24.000000000","tz":60},"committer":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-04 16:49:00.000000000","tz":60},"subject":"Allow infinit retrying on the expected db errors","message":"Allow infinit retrying on the expected db errors\n\nWhen max_retries \u003d\u003d -1, retrying becomes infinit.\n\nStory: 2007328\ntask: 38849\n\nChange-Id: Ib3862fa9c090e185069809fffadd5814d93046eb\nSigned-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/1e055d30d9781b35f6875da4f97fc8331c6a7d52"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/1e055d30d9781b35f6875da4f97fc8331c6a7d52"}]},"branch":"refs/heads/master"},"0e9e70f4128ae9e5e66c277daf19708e797b5049":{"kind":"REWORK","_number":3,"created":"2020-03-11 15:42:48.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/21/711221/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/21/711221/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/3"}}},"commit":{"parents":[{"commit":"fafcbddec7deb3d96b4cb3b837912b8fcfb2debb","subject":"Merge \"gitignore: Add reno artefacts\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/fafcbddec7deb3d96b4cb3b837912b8fcfb2debb"}]}],"author":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-04 13:01:24.000000000","tz":60},"committer":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-11 15:39:30.000000000","tz":60},"subject":"Allow infinite retrying on the expected db errors","message":"Allow infinite retrying on the expected db errors\n\nWhen max_retries \u003d\u003d -1, retrying becomes infinite.\n\nStory: 2007328\ntask: 38849\n\nChange-Id: Ib3862fa9c090e185069809fffadd5814d93046eb\nSigned-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/0e9e70f4128ae9e5e66c277daf19708e797b5049"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/0e9e70f4128ae9e5e66c277daf19708e797b5049"}]},"branch":"refs/heads/master"},"9a16fd8554834610194eb0f2d30ad0130b09aa38":{"kind":"REWORK","_number":4,"created":"2020-03-12 08:09:42.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/21/711221/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/21/711221/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/4"}}},"commit":{"parents":[{"commit":"fafcbddec7deb3d96b4cb3b837912b8fcfb2debb","subject":"Merge \"gitignore: Add reno artefacts\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/fafcbddec7deb3d96b4cb3b837912b8fcfb2debb"}]}],"author":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-04 13:01:24.000000000","tz":60},"committer":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-12 08:09:34.000000000","tz":60},"subject":"Allow infinite retrying on the expected db errors","message":"Allow infinite retrying on the expected db errors\n\nWhen max_retries \u003d\u003d -1, retrying becomes infinite.\n\nStory: 2007328\ntask: 38849\n\nChange-Id: Ib3862fa9c090e185069809fffadd5814d93046eb\nSigned-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/9a16fd8554834610194eb0f2d30ad0130b09aa38"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/9a16fd8554834610194eb0f2d30ad0130b09aa38"}]},"branch":"refs/heads/master"},"269dbb7d8d1d0c941f6407d118d88f8cf705a0ed":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2020-03-25 07:27:01.000000000","uploader":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"ref":"refs/changes/21/711221/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/21/711221/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/21/711221/5"}}},"commit":{"parents":[{"commit":"bf5b45ebba24b4c8737c3197f2cd65f84fd2448c","subject":"Remove \u0027handle_connect_error\u0027","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/bf5b45ebba24b4c8737c3197f2cd65f84fd2448c"}]}],"author":{"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","date":"2020-03-04 13:01:24.000000000","tz":60},"committer":{"name":"Bogdan Dobrelya (bogdando)","email":"bdobreli@redhat.com","date":"2020-03-25 07:27:01.000000000","tz":0},"subject":"Allow infinite retrying on the expected db errors","message":"Allow infinite retrying on the expected db errors\n\nWhen max_retries \u003d\u003d -1, retrying becomes infinite.\n\nStory: 2007328\ntask: 38849\n\nChange-Id: Ib3862fa9c090e185069809fffadd5814d93046eb\nSigned-off-by: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/269dbb7d8d1d0c941f6407d118d88f8cf705a0ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/269dbb7d8d1d0c941f6407d118d88f8cf705a0ed"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}