)]}'
{"id":"openstack%2Foslo.db~734713","triplet_id":"openstack%2Foslo.db~master~Icdb2afd91f794c2ef588f92716b80389bae8a499","project":"openstack/oslo.db","branch":"master","topic":"bug/1882844","hashtags":[],"change_id":"Icdb2afd91f794c2ef588f92716b80389bae8a499","subject":"Send SSL parameter as a dict","status":"ABANDONED","created":"2020-06-09 22:32:11.000000000","updated":"2020-06-15 15:51:53.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"de09675581a63f2fefb4272986b9808e78955f75","_number":734713,"virtual_id_number":734713,"owner":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"date":"2020-06-15 11:06:59.000000000","_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-06-13 00:57:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":-1,"date":"2020-06-15 14:47:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"all":[{"value":-1,"date":"2020-06-15 15:29:31.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-13 00:57:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-15 11:06:59.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-06-15 14:47:46.000000000","updated_by":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"reviewer":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"state":"REVIEWER"}],"messages":[{"id":"664725b43df76ea3aafbf0ef6b5e9343fbc0827d","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2020-06-09 22:32:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e9a3200c492ddc16f19832ac6599c7c5769f0808","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2020-06-09 22:34:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"35c8603fbb137af44dd170d9504466cb768926d0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-10 00:03:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b9b5dcbabe874247a6a82af0291593a1 : SUCCESS in 1h 27m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6ef661d46fd34276aae8d6ed48e9946a : SUCCESS in 7m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a2ecc82cd9894de7beac021b1778e329 : SUCCESS in 4m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/95740e12add747b8a087c26434843c99 : SUCCESS in 6m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/355bbdd6243f46119fd629f77641ff6b : SUCCESS in 6m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9cb70ff10c444758bc019a9ae52edb3a : SUCCESS in 5m 10s","accounts_in_message":[],"_revision_number":2},{"id":"700784662f6ffe81486a5852ef73a3ee88a6ef05","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-10 12:16:14.000000000","message":"Patch Set 2:\n\nHello,\n\nPlease can you add related tests.","accounts_in_message":[],"_revision_number":2},{"id":"f46709c8097970c13628acc3297a39fbe93ad540","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2020-06-12 23:17:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"48e22756e2f6ca2cd9aa4f2e7d325ef46eb08826","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-13 00:57:58.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1b86486ae4d344398b41a18fa748187b : SUCCESS in 1h 39m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3fbd41f101de403cb66b3b061fac4bac : SUCCESS in 5m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b4653abe130f4ef8959d5e62d9349e4b : SUCCESS in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e375bc00d6cd403cbd41410c57ccd8d7 : SUCCESS in 25m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/67e607a5ecc9461890ef018c4c5eddb1 : SUCCESS in 5m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/55a2d18650484e279ca41c517ae6be6a : SUCCESS in 4m 29s","accounts_in_message":[],"_revision_number":3},{"id":"de2919d60802dec644c7c572c29576dc5903d7ba","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-15 11:06:59.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nHello,\n\nFirst thanks for your previous changes.\n\nI\u0027ve some minor concern about the keys management, see my inline comment.\n\nAlso I think an associated release note [1] (kind of \"features\") could be worth, it could help to highlight these changes for users.\n\n[1] https://docs.openstack.org/reno/latest/user/usage.html#creating-new-release-notes","accounts_in_message":[],"_revision_number":3},{"id":"f33685fe5131625936f2efe70f2b36d5c93977c7","author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-06-15 14:47:46.000000000","message":"Patch Set 3: Code-Review-1\n\nHi there -\n\nSQLAlchemy\u0027s pymysql dialect supports SSL parameters passed in the query string and this feature is unnecessary.  the two bugs on the SQLAlchemy side, one of which can be worked around and other hopefully can for the moment, however I will gladly release 1.3.18 with this added, are:\n\n1. the feature is not documented\n\n2. the \"check_hostname\" parameter is not supported yet.\n\nTo connect to pymysql with an SSL URL, use ssl_\u003ckeyname\u003e in the query string:\n\nfrom sqlalchemy import create_engine\n\ne \u003d create_engine(\n    \"mysql+pymysql://scott:tiger@localhost/test?\"\n    \"ssl_ca\u003d/path/to/ca\u0026ssl_capath\u003d/path/to/cas\u0026ssl_cipher\u003dtls1\u0026ssl_key\u003d/path_to_key\"\n)\n\nprint(e.dialect.create_connect_args(e.url))\n\n\noutput:\n\n[[], {\u0027host\u0027: \u0027localhost\u0027, \u0027db\u0027: \u0027test\u0027, \u0027user\u0027: \u0027scott\u0027, \u0027passwd\u0027: \u0027tiger\u0027, \u0027ssl\u0027: {\u0027ca\u0027: \u0027/path/to/ca\u0027, \u0027key\u0027: \u0027/path_to_key\u0027, \u0027capath\u0027: \u0027/path/to/cas\u0027, \u0027cipher\u0027: \u0027tls1\u0027}, \u0027client_flag\u0027: 2}]","accounts_in_message":[],"_revision_number":3},{"id":"b382b21e3692a31a18aac7143d6b36fcbe4c62f7","author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-06-15 14:54:15.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nI can\u0027t actually find any documentation on ssl-\u003echeck_hostname for any of: MySQL, MariaDB, or Galera.  Can you provide background on this parameter?     \n\nif this parameter was added in error, then we can assume this is only a documentation issue on the SQLAlchemy side.","accounts_in_message":[],"_revision_number":3},{"id":"c23b24c9cc6446ca9f2016f2702ef198a1c8665c","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2020-06-15 15:29:31.000000000","message":"Patch Set 3: Workflow-1\n\nMichael, thank you. I am not sure how I missed this. I am a bit embarrassed. I\u0027ll abandon this change and update the bug.","accounts_in_message":[],"_revision_number":3},{"id":"ce16b1a6e7eac1df18138cd9afbeabc1d5f56442","author":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"date":"2020-06-15 15:29:53.000000000","message":"Abandoned\n\nUnnecessary change.","accounts_in_message":[],"_revision_number":3},{"id":"4098f3c5e3da2698a98b9e45b14a07b7ad3770fe","author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-06-15 15:51:53.000000000","message":"Patch Set 3:\n\n\u003e Michael, thank you. I am not sure how I missed this. I am a bit\n \u003e embarrassed. I\u0027ll abandon this change and update the bug.\n\nit wasn\u0027t documented on my end (still isn\u0027t...) !   no worries at all :)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ab84d4f74aac5e6335bd1abced4ac483040a7099","revisions":{"8e87f483b2e69a9283e672c59832ff4846f0d889":{"kind":"REWORK","_number":1,"created":"2020-06-09 22:32:11.000000000","uploader":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"ref":"refs/changes/13/734713/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/13/734713/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/1"}}},"commit":{"parents":[{"commit":"c18a019484356ce15da4f60f9147f7e8c019ae0c","subject":"Fix pygments style","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/c18a019484356ce15da4f60f9147f7e8c019ae0c"}]}],"author":{"name":"David Ames","email":"david.ames@canonical.com","date":"2020-06-09 22:28:47.000000000","tz":-420},"committer":{"name":"David Ames","email":"david.ames@canonical.com","date":"2020-06-09 22:32:10.000000000","tz":-420},"subject":"Send SSL parameter as a dict","message":"Send SSL parameter as a dict\n\nCurrently, there is no way to send SSL parameters to pymsql. Pymsql\nexpects the parameter ssl to be a dictionary of settings. The current\nbehavior adds parameters to the URL as URL encoded settings but pymysql\ncannot consume these.\n\nChange-Id: Icdb2afd91f794c2ef588f92716b80389bae8a499\nCloses-Bug: #1882844\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/8e87f483b2e69a9283e672c59832ff4846f0d889"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/8e87f483b2e69a9283e672c59832ff4846f0d889"}]},"branch":"refs/heads/master"},"dd524a4d080c3b02d233a31118c45b1a839598f3":{"kind":"REWORK","_number":2,"created":"2020-06-09 22:34:40.000000000","uploader":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"ref":"refs/changes/13/734713/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/13/734713/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/2"}}},"commit":{"parents":[{"commit":"c18a019484356ce15da4f60f9147f7e8c019ae0c","subject":"Fix pygments style","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/c18a019484356ce15da4f60f9147f7e8c019ae0c"}]}],"author":{"name":"David Ames","email":"david.ames@canonical.com","date":"2020-06-09 22:28:47.000000000","tz":-420},"committer":{"name":"David Ames","email":"david.ames@canonical.com","date":"2020-06-09 22:34:29.000000000","tz":-420},"subject":"Send SSL parameter as a dict","message":"Send SSL parameter as a dict\n\nCurrently, there is no way to send SSL parameters to pymsql. Pymsql\nexpects the parameter ssl to be a dictionary of settings. The current\nbehavior adds parameters to the URL as URL encoded settings but pymysql\ncannot consume these.\n\nChange-Id: Icdb2afd91f794c2ef588f92716b80389bae8a499\nCloses-Bug: #1882844\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/dd524a4d080c3b02d233a31118c45b1a839598f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/dd524a4d080c3b02d233a31118c45b1a839598f3"}]},"branch":"refs/heads/master"},"ab84d4f74aac5e6335bd1abced4ac483040a7099":{"kind":"REWORK","_number":3,"created":"2020-06-12 23:17:22.000000000","uploader":{"_account_id":20805,"name":"David Ames","email":"david@davam.net","username":"thedac"},"ref":"refs/changes/13/734713/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.db","ref":"refs/changes/13/734713/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.db refs/changes/13/734713/3"}}},"commit":{"parents":[{"commit":"c18a019484356ce15da4f60f9147f7e8c019ae0c","subject":"Fix pygments style","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/c18a019484356ce15da4f60f9147f7e8c019ae0c"}]}],"author":{"name":"David Ames","email":"david.ames@canonical.com","date":"2020-06-09 22:28:47.000000000","tz":-420},"committer":{"name":"David Ames","email":"david.ames@canonical.com","date":"2020-06-12 23:17:15.000000000","tz":-420},"subject":"Send SSL parameter as a dict","message":"Send SSL parameter as a dict\n\nCurrently, there is no way to send SSL parameters to pymsql. Pymsql\nexpects the parameter ssl to be a dictionary of settings. The current\nbehavior adds parameters to the URL as URL encoded settings but pymysql\ncannot consume these.\n\nChange-Id: Icdb2afd91f794c2ef588f92716b80389bae8a499\nCloses-Bug: #1882844\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/ab84d4f74aac5e6335bd1abced4ac483040a7099"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.db/commit/ab84d4f74aac5e6335bd1abced4ac483040a7099"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}