)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"feea7bbaed7b7f0e0972f858b5855df8604292fe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to answer to the crypto challenge that it receives from the"},{"line_number":15,"context_line":"server. The authentication is transparent for oslo.db."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Since oslo.db depends on a PyMySQL version that supports"},{"line_number":18,"context_line":"auth_ed25519, add PyNaCl to the list of requirements so that"},{"line_number":19,"context_line":"oslo.db clients can always use auth_ed25519 if they want to."},{"line_number":20,"context_line":"By default, it is not is use and PyMySQL keeps connecting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_c7839854","line":17,"updated":"2020-10-06 14:35:19.000000000","message":"I\u0027m actually not seeing this.  it looks like test-requirements.txt and lower-constraints has PyMySQL \u003e\u003d0.7.6 right now, which is ancient.","commit_id":"baa74598501584f2b62c898fe4fd4133b08a90e0"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8db9b17bcfcce85dca377d5a9dbaada872974cc5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to answer to the crypto challenge that it receives from the"},{"line_number":15,"context_line":"server. The authentication is transparent for oslo.db."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Since oslo.db depends on a PyMySQL version that supports"},{"line_number":18,"context_line":"auth_ed25519, add PyNaCl to the list of requirements so that"},{"line_number":19,"context_line":"oslo.db clients can always use auth_ed25519 if they want to."},{"line_number":20,"context_line":"By default, it is not is use and PyMySQL keeps connecting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_ca339360","line":17,"in_reply_to":"9f560f44_c7839854","updated":"2020-10-07 08:22:52.000000000","message":"We can easily move to PyMySQL 0.10.0 since it\u0027s the version supported in global requirements upper-constraints.txt\n\n[1] https://opendev.org/openstack/requirements/src/branch/master/upper-constraints.txt#L389","commit_id":"baa74598501584f2b62c898fe4fd4133b08a90e0"}],"requirements.txt":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b2930da3d2229b3eb5f91b378119eae7ed200823","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":11,"context_line":"PyNaCl\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":12,"context_line":"SQLAlchemy\u003e\u003d1.2.0 # MIT"},{"line_number":13,"context_line":"sqlalchemy-migrate\u003e\u003d0.11.0 # Apache-2.0"},{"line_number":14,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_33ce1a2d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":26},"updated":"2020-10-06 12:23:02.000000000","message":"Even if your commit message is explicit it could be worth to add a comment above to explain why we put this line in our requirements and avoid that anybody try to drop it at each cycle.\n\nI doubt that everybody will read our git logs.","commit_id":"baa74598501584f2b62c898fe4fd4133b08a90e0"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8db9b17bcfcce85dca377d5a9dbaada872974cc5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":11,"context_line":"PyNaCl\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":12,"context_line":"SQLAlchemy\u003e\u003d1.2.0 # MIT"},{"line_number":13,"context_line":"sqlalchemy-migrate\u003e\u003d0.11.0 # Apache-2.0"},{"line_number":14,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_ea98171b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":26},"in_reply_to":"9f560f44_27a8948a","updated":"2020-10-07 08:22:52.000000000","message":"I agree for the justification side of these changes.\n\nI think you are right for the move to test-requirements.\n\nAFAIK PyMySQL is landed as a `BuildRequires` [1] and a `Requires` of our RPM so it will be present on the system during runtime, so I think it will be the same scenario for PyNaCl. I\u0027ll ensure that we will use the same way to define PyNaCl.\n\n[1] https://opendev.org/openstack/rpm-packaging/src/branch/master/openstack/oslo.db/oslo.db.spec.j2#L15\n[2] https://opendev.org/openstack/rpm-packaging/src/branch/master/openstack/oslo.db/oslo.db.spec.j2#L47","commit_id":"baa74598501584f2b62c898fe4fd4133b08a90e0"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"feea7bbaed7b7f0e0972f858b5855df8604292fe","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":11,"context_line":"PyNaCl\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":12,"context_line":"SQLAlchemy\u003e\u003d1.2.0 # MIT"},{"line_number":13,"context_line":"sqlalchemy-migrate\u003e\u003d0.11.0 # Apache-2.0"},{"line_number":14,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_27a8948a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":26},"in_reply_to":"9f560f44_33ce1a2d","updated":"2020-10-06 14:35:19.000000000","message":"I would note that pymysql is not here, it\u0027s in test-requirements.txt.   This makes sense because you don\u0027t need pymysql to run oslo.db, so it\u0027s hard to justify this being here.","commit_id":"baa74598501584f2b62c898fe4fd4133b08a90e0"},{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"76dc515f082d28f5b95b34f6777173e3b48d2a78","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":11,"context_line":"PyNaCl\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":12,"context_line":"SQLAlchemy\u003e\u003d1.2.0 # MIT"},{"line_number":13,"context_line":"sqlalchemy-migrate\u003e\u003d0.11.0 # Apache-2.0"},{"line_number":14,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_b676860b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":26},"in_reply_to":"9f560f44_ea98171b","updated":"2020-10-07 12:49:57.000000000","message":"I think we need to review internally as @dciabrin is not certain the current packaging for pynacl is going to work at the moment.","commit_id":"baa74598501584f2b62c898fe4fd4133b08a90e0"}]}